nova-serialproxy missing dependency on python-websockify

[Mike Joseph]

Description: Ubuntu 18.04.1 LTS
Release: 18.04

ii nova-serialproxy 2:17.0.5-0ubuntu2 all OpenStack Compute - serial proxy

It appears that the nova-serialproxy package depends on python-websockify, but no such dependency is currently declared for the package. When nova-serialproxy is installed without python-websockify, the following errors are observed in syslog:

Oct 22 08:13:42 ctrl01 nova-serialproxy[24100]: Traceback (most recent call last):
Oct 22 08:13:42 ctrl01 nova-serialproxy[24100]: File "/usr/bin/nova-serialproxy", line 6, in <module>
Oct 22 08:13:42 ctrl01 nova-serialproxy[24100]: from nova.cmd.serialproxy import main
Oct 22 08:13:42 ctrl01 nova-serialproxy[24100]: File "/usr/lib/python2.7/dist-packages/nova/cmd/serialproxy.py", line 22, in <module>
Oct 22 08:13:42 ctrl01 nova-serialproxy[24100]: from nova.cmd import baseproxy
Oct 22 08:13:42 ctrl01 nova-serialproxy[24100]: File "/usr/lib/python2.7/dist-packages/nova/cmd/baseproxy.py", line 29, in <module>
Oct 22 08:13:42 ctrl01 nova-serialproxy[24100]: from nova.console import websocketproxy
Oct 22 08:13:42 ctrl01 nova-serialproxy[24100]: File "/usr/lib/python2.7/dist-packages/nova/console/websocketproxy.py", line 29, in <module>
Oct 22 08:13:42 ctrl01 nova-serialproxy[24100]: import websockify
Oct 22 08:13:42 ctrl01 nova-serialproxy[24100]: ImportError: No module named websockify

However, if python-websockify is manually installed using apt, the errors resolve and the nova-serialproxy daemon is able to start.

[Corey Bryant (corey.bryant)]

Hi Mike,

There is outstanding work to do to handle security issues with websockify [1]. Can you use nova-spiceproxy instead?

Thanks,
Corey

[Corey Bryant (corey.bryant)]

Actually both nova-novncproxy and nova-spiceproxy are in universe due to [1]. We should be able to add python-websockify to the nova-novncproxy dependencies for now. Once we get the security issues fixed we can get it promoted to main where it will get security support.

[1] https://bugs.launchpad.net/bugs/1108935

[Corey Bryant (corey.bryant)]

s/nova-novncproxy/nova-serialproxy/ ^^