Notify-osd & XFCE

Bug #394432 reported by Sebastian Schepens
22
This bug affects 2 people
Affects Status Importance Assigned to Milestone
NULL Project
Invalid
Undecided
Unassigned
notify-osd (Ubuntu)
Triaged
Low
Mirco Müller

Bug Description

Notify-osd should check for XFCE's font settings as it checks for GNOME's.
I am using Xubuntu karmic, and after setting my fonts to Sans 8 and DPI 73, notify-osd settings remaind huge (after logging out obviously).
Now, searching in some other bug reports, i installed gconf-editor and editted GNOME's font settings to match my XFCE settings and relogged, now my notify-osd fonts have a correct size and are coherent with the desktop.
Notify-osd should check for XFCE settings if GNOME is no installed, so it is compatible with XFCE, cause i dont believe it should be that XFCE settings also change GNOME one's. Anyways notif-osd should somehow be compatible with XFCE.
I dont' believe this to be so hard of fixing, but i dont know, you tell me.

Revision history for this message
Sebastian Schepens (sebas-schep) wrote :

This should be fixed before karmic release as Xubuntu has adopted notify-osd

Revision history for this message
Steve Dodier-Lazaro (sidi) wrote :

This is not trivial, thus not a papercut.

Changed in hundredpapercuts:
status: New → Invalid
Revision history for this message
Steve Dodier-Lazaro (sidi) wrote :

Confirming, this is a serious issue for XFCE users, and Xubuntu switches to NotifyOsd.

Mirco : i hope we can talk about this bug on IRC when you're back from Guadec. It shouldn't be hard to fix if we work together.

Changed in notify-osd (Ubuntu):
status: New → Confirmed
Changed in notify-osd:
status: New → Confirmed
Revision history for this message
Sebastian Schepens (sebas-schep) wrote :

Thanks for paying attention, hope it's easy to fix!

Revision history for this message
Steve Dodier-Lazaro (sidi) wrote :

I'm gonna work on support for XFCE and xfconf.

Changed in notify-osd:
assignee: nobody → Steve Dodier (sidi)
status: Confirmed → In Progress
Revision history for this message
Steve Dodier-Lazaro (sidi) wrote :

I'm appending a patch, written against rev 356.

It adds the --with-xfconf configure option that will use Xfconf and XFCE's default values instead of Gconf / GNOME's.
Please check the two FIXME in the patch, Mirco. If anything else is needed from me, let me know.

The next step is to get a notify-osd-xfce package in universe. I really don't know anything about packaging, so I won't be able to manage this part. :)

Revision history for this message
Sebastian Schepens (sebas-schep) wrote :

Hey, good job, i0ll be waiting for the package then :)

Revision history for this message
Mirco Müller (macslow) wrote :

Steve, overall the patch seems ok. But I'm about to add several gconf-keys to notify-osd to tweak some rendering-parameters (title-/body-font, bubble-bg-color, bubble-bg-opacity, bubble-shadow-color, text-fg-color and text-shadow-color). Therefore your patch, being merged into notify-osd trunk, would introduce a dis-balance between notify-osd and "xfce-ified" notify-osd. Thus for the moment I'd rather see your patch being a Xubuntu-specific distro-patch until we can get a 100% feature-parity between GNOME- and XFCE-variants of notify-osd. Also I'd like to then split the gconf- and xconf-related code out into separate .c files for better isolation reasons. Needless to say unit-tests will be needed too as this is an additional requirement for notify-osd development since this (karmic) cycle.

Changed in notify-osd (Ubuntu):
importance: Undecided → Low
status: Confirmed → Triaged
Vish (vish)
affects: hundredpapercuts → null
Revision history for this message
Steve Dodier-Lazaro (sidi) wrote :
Mirco Müller (macslow)
Changed in notify-osd:
milestone: none → ubuntu-9.10
Changed in notify-osd (Ubuntu):
milestone: none → ubuntu-9.10
status: Triaged → In Progress
Changed in notify-osd:
importance: Undecided → Low
assignee: Steve Dodier (sidi) → Mirco Müller (macslow)
Changed in notify-osd (Ubuntu):
assignee: nobody → Mirco Müller (macslow)
Revision history for this message
David Barth (dbarth) wrote :

The patch is too invasive (and not up to date) to land at this stage. Mirco will help with landing that on trunk after reviewing the code.

Changed in notify-osd (Ubuntu):
milestone: ubuntu-9.10 → later
Changed in notify-osd:
milestone: ubuntu-9.10 → ubuntu-9.12
David Barth (dbarth)
Changed in notify-osd:
milestone: ubuntu-9.12 → none
Revision history for this message
Omer Akram (om26er) wrote :

changing the status to reflect the current state.

Changed in notify-osd:
status: In Progress → Confirmed
Changed in notify-osd (Ubuntu):
status: In Progress → Triaged
no longer affects: notify-osd
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.