Allow installation in custom prefix

[Michael Monreal]

Currently, notify-osd is not easily installable in a prefix other than /usr:

1.)
gcc -DHAVE_CONFIG_H -I. -I.. -Wall -Werror -std=c99 -pthread -DORBIT2=1 -I/opt/gnome2.24/include/glib-2.0 -I/opt/gnome2.24/lib/glib-2.0/include -I/opt/gnome2.24/include/gconf/2 -I/opt/gnome2.24/include/orbit-2.0 -I/usr/include/dbus-1.0 -I/usr/lib/dbus-1.0/include -I/opt/gnome2.24/include/gtk-2.0 -I/opt/gnome2.24/lib/gtk-2.0/include -I/opt/gnome2.24/include/atk-1.0 -I/opt/gnome2.24/include/cairo -I/opt/gnome2.24/include/pango-1.0 -I/opt/gnome2.24/include/glib-2.0 -I/opt/gnome2.24/lib/glib-2.0/include -I/opt/gnome2.24/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libpng12 -I/opt/gnome2.24/include/libwnck-1.0 -I/opt/gnome2.24/include/pango-1.0 -I/opt/gnome2.24/include/cairo -I/opt/gnome2.24/include/startup-notification-1.0 -I/opt/gnome2.24/include/glib-2.0 -I/opt/gnome2.24/lib/glib-2.0/include -I/opt/gnome2.24/include/gtk-2.0 -I/opt/gnome2.24/include/pixman-1 -I/opt/gnome2.24/lib/gtk-2.0/include -I/opt/gnome2.24/include/atk-1.0 -I/usr/include/freetype2 -I/usr/include/libpng12 -I/opt/gnome2.24/include/glib-2.0 -I/opt/gnome2.24/lib/glib-2.0/include -I/usr/include/dbus-1.0 -I/usr/lib/dbus-1.0/include -I../src -g -O2 -pipe -lm -Wall -Werror -std=c99 -MT test_modules-test-withlib.o -MD -MP -MF .deps/test_modules-test-withlib.Tpo -c -o test_modules-test-withlib.o `test -f 'test-withlib.c' || echo './'`test-withlib.c
test-withlib.c:31:30: error: libnotify/notify.h: No such file or directory
cc1: warnings being treated as errors
test-withlib.c: In function ‘test_withlib_get_server_information’:
test-withlib.c:51: error: implicit declaration of function ‘notify_init’
test-withlib.c:52: error: implicit declaration of function ‘notify_get_server_info’
test-withlib.c: In function ‘test_withlib_get_server_caps’:
test-withlib.c:67: error: implicit declaration of function ‘notify_get_server_caps’
test-withlib.c:67: error: assignment makes pointer from integer without a cast
test-withlib.c: In function ‘test_withlib_show_notification’:
test-withlib.c:88: error: ‘NotifyNotification’ undeclared (first use in this function)
test-withlib.c:88: error: (Each undeclared identifier is reported only once
test-withlib.c:88: error: for each function it appears in.)
test-withlib.c:88: error: ‘n’ undeclared (first use in this function)
test-withlib.c:92: error: implicit declaration of function ‘notify_notification_new’
test-withlib.c:95: error: implicit declaration of function ‘notify_notification_show’
test-withlib.c: In function ‘test_withlib_update_notification’:
test-withlib.c:104: error: ‘NotifyNotification’ undeclared (first use in this function)
test-withlib.c:104: error: ‘n’ undeclared (first use in this function)
test-withlib.c:116: error: implicit declaration of function ‘notify_notification_update’
test-withlib.c: In function ‘test_withlib_pass_icon_data’:
test-withlib.c:131: error: ‘NotifyNotification’ undeclared (first use in this function)
test-withlib.c:131: error: ‘n’ undeclared (first use in this function)
test-withlib.c:132: error: ‘GdkPixbuf’ undeclared (first use in this function)
test-withlib.c:132: error: ‘pixbuf’ undeclared (first use in this function)
test-withlib.c:138: error: implicit declaration of function ‘gdk_pixbuf_new_from_file_at_scale’
test-withlib.c:140: error: implicit declaration of function ‘notify_notification_set_icon_from_pixbuf’
test-withlib.c: In function ‘test_withlib_priority’:
test-withlib.c:153: error: ‘NotifyNotification’ undeclared (first use in this function)
test-withlib.c:153: error: ‘n1’ undeclared (first use in this function)
test-withlib.c:153: error: ‘n2’ undeclared (first use in this function)
test-withlib.c:153: error: left-hand operand of comma expression has no effect
test-withlib.c:153: error: ‘n3’ undeclared (first use in this function)
test-withlib.c:153: error: left-hand operand of comma expression has no effect
test-withlib.c:153: error: ‘n4’ undeclared (first use in this function)
test-withlib.c:153: error: left-hand operand of comma expression has no effect
test-withlib.c:167: error: implicit declaration of function ‘notify_notification_set_hint_string’
test-withlib.c:172: error: implicit declaration of function ‘notify_notification_set_urgency’
test-withlib.c:172: error: ‘NOTIFY_URGENCY_CRITICAL’ undeclared (first use in this function)
test-withlib.c: At top level:
test-withlib.c:188: error: expected ‘)’ before ‘*’ token
test-withlib.c: In function ‘test_withlib_actions’:
test-withlib.c:199: error: ‘NotifyNotification’ undeclared (first use in this function)
test-withlib.c:199: error: ‘n1’ undeclared (first use in this function)
test-withlib.c:204: error: implicit declaration of function ‘notify_notification_add_action’
test-withlib.c:207: error: ‘NotifyActionCallback’ undeclared (first use in this function)
test-withlib.c:207: error: expected ‘)’ before ‘callback’
test-withlib.c: In function ‘test_withlib_close_notification’:
test-withlib.c:221: error: ‘NotifyNotification’ undeclared (first use in this function)
test-withlib.c:221: error: ‘n’ undeclared (first use in this function)
test-withlib.c:234: error: implicit declaration of function ‘notify_notification_close’
test-withlib.c: In function ‘test_withlib_append_hint’:
test-withlib.c:246: error: ‘NotifyNotification’ undeclared (first use in this function)
test-withlib.c:246: error: ‘n’ undeclared (first use in this function)
test-withlib.c: In function ‘test_withlib_icon_only_hint’:
test-withlib.c:288: error: ‘NotifyNotification’ undeclared (first use in this function)
test-withlib.c:288: error: ‘n’ undeclared (first use in this function)
test-withlib.c: In function ‘test_withlib_swallow_markup’:
test-withlib.c:309: error: ‘NotifyNotification’ undeclared (first use in this function)
test-withlib.c:309: error: ‘n’ undeclared (first use in this function)
make[2]: *** [test_modules-test-withlib.o] Error 1
make[2]: Leaving directory `/home/nx/code/bzr/notify-osd/tests'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/home/nx/code/bzr/notify-osd'
make: *** [all] Error 2

=> it should search $PREFIX/include for includes, not only /usr/include

2.)

test -z "/usr/share/dbus-1/services" || /bin/mkdir -p "/usr/share/dbus-1/services"
 /usr/bin/install -c -m 644 'org.freedesktop.Notifications.service' '/usr/share/dbus-1/services/org.freedesktop.Notifications.service'
/usr/bin/install: cannot create regular file `/usr/share/dbus-1/services/org.freedesktop.Notifications.service': Permission denied
make[3]: *** [install-serviceDATA] Error 1
make[3]: Leaving directory `/home/nx/code/bzr/notify-osd/data'
make[2]: *** [install-am] Error 2
make[2]: Leaving directory `/home/nx/code/bzr/notify-osd/data'
make[1]: *** [install-recursive] Error 1
make[1]: Leaving directory `/home/nx/code/bzr/notify-osd/data'
make: *** [install-recursive] Error 1

=> It should not force the DBus service directory to be /usr/share/dbus-1/services but $PREFIX/share/dbus-1/services or better yet, provide a configure option to set it

[David Barth (dbarth)]

That's mostly an issue due to the test suite.