Dialogues are not HIG-compliant

Bug #332178 reported by Bruce Cowan on 2009-02-20
6
Affects Status Importance Assigned to Milestone
notify-osd (Ubuntu)
Medium
Cody Russell
Nominated for Jaunty by David Barth

Bug Description

Binary package hint: notify-osd

The dialogues that we're forced to now have are not HIG-compliant. They should have primary and secondary text, a decent-sized icon, and no seperator.

Alexander Sack (asac) wrote :

I agree that we should at least put some more work into these dialogs. You suggestions make sense. Patches welcome!

(In the end apps should honour the "actions" capability of notification daemons and dont send actions)

Changed in notify-osd:
importance: Undecided → Medium
status: New → Triaged

TBH, I don't want to help this project, but someone else can.

David Barth (dbarth) wrote :

Cody, can you take look at this one?

Matthew, can you outline the recommended changes?

Thanks

Changed in notify-osd:
assignee: nobody → bratsche
importance: Undecided → Medium
status: New → Triaged
Matthew Paul Thomas (mpt) wrote :

There should be:
(1) 12px spacing between the top of the text and the bottom of the title bar
(2) 12px spacing between the top edge of the icon and the bottom of the title bar
(3) 12px spacing between the left edge of the icon and the left edge of the window
(4) no separator in the window at all
(5) 24px spacing between the bottom of the text and the top of the buttons
(6) a distinction between the Cancel and OK buttons, which should have the same width as each other, and any other buttons, which should have unrelated widths.

Cody Russell (bratsche) wrote :

I still need to test to be sure that this will fix #6 from MPT's list, but I believe it fixes the other items.

tags: added: dxteam notifications
Cody Russell (bratsche) wrote :

Sorry to disappoint you mpt, but I don't think #6 is easily doable here and isn't really worth the effort.

The problem being that GtkButtonBox appears to enforce child widget sizing. This seems more that a little evil to me, and should perhaps be addressed in gtk+. When you insert the buttons, they get added with fill=FALSE, expand=TRUE. It should be a simple matter of using gtk_box_set_child_packing() to set expand=FALSE, but that doesn't work apparently because of this child size_request enforcement.

Matthew Paul Thomas (mpt) wrote :

Don't let this prevent you from fixing the other problems before the FinalFreeze.

However, from your description GtkButtonBox is doing exactly what it's supposed to <http://library.gnome.org/devel/gtk/unstable/GtkButtonBox.html>: "The main purpose of GtkButtonBox is to make sure the children have all the same size."

So, the Cancel and OK buttons should be in the GtkButtonBox, but any other buttons should be in something else (a GtkBox?) to the left of the GtkButtonBox.

Launchpad Janitor (janitor) wrote :

This bug was fixed in the package notify-osd - 0.9.10-0ubuntu1

---------------
notify-osd (0.9.10-0ubuntu1) jaunty; urgency=low

  * New upstream bug fix release:
    - Enforce 10-line-limit for body-message text if newline-characters are part of it.
    - Fixes DoS-like exploit-weakness of new append-functionality introduced with rev. 280.
    - Make fallback dialogs more HIG-compliant. (LP: #332178)
    - cairo_surface_t reference is lost when pointer is overwritten (LP: #356916)
    - priv->icon_pixbuf is overwritten before it's current reference is decreased (LP: #356927)
    - string from dbus_g_method_get_sender not freed (LP: #356858)
    - Notification entries are not appended unless a replace is used (LP: #337394)
    - Fix the workarea fallback case.

 -- Martin Pitt <email address hidden> Wed, 08 Apr 2009 16:14:08 -0700

Changed in notify-osd (Ubuntu):
status: Triaged → Fix Released
David Barth (dbarth) on 2009-04-09
Changed in notify-osd:
status: Triaged → Fix Released
Changed in notify-osd (Ubuntu):
assignee: nobody → Cody Russell (bratsche)
no longer affects: notify-osd
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers