node-mime-types FTBFS with node-mime 2.3.1

Bug #1793367 reported by Mauricio Faria de Oliveira on 2018-09-19
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
node-mime-types (Debian)
Fix Released
Unknown
node-mime-types (Ubuntu)
Undecided
Mauricio Faria de Oliveira

Bug Description

node-mime-types FTBFS with node-mime 2.3.1

node-mime 2.3.1 no longer ships /usr/share/node-mime/types.json,
leading to this build failure:

 ...
 # just copy the file from node-mime
 cp /usr/share/node-mime/types.json node_modules/mime-db/src/deb.types.json
 cp: cannot stat '/usr/share/node-mime/types.json': No such file or directory

 make[1]: *** [debian/rules:21: override_dh_auto_build] Error 1
 make[1]: Leaving directory '/tmp/autopkgtest.bNiyPN/build.yAz/src'
 make: *** [debian/rules:8: build] Error 2
 dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2
 ...

The new version ships /usr/share/node-mime/{standard,other}.json instead.
Debian upstream switched to only standard.json, not other.json.

With this patch from Debian, the package builds correctly:

 ...
 # just copy the file from node-mime
 cp /usr/share/node-mime/standard.json node_modules/mime-db/src/deb.types.json
 cd node_modules/mime-db/ && nodejs scripts/build
 make[1]: Leaving directory '/<<PKGBUILDDIR>>'
 ...

Changed in node-mime-types (Ubuntu):
status: New → In Progress
assignee: nobody → Mauricio Faria de Oliveira (mfo)
description: updated

The attachment "node-mime-types_node-mime-2.3.1.debdiff" seems to be a debdiff. The ubuntu-sponsors team has been subscribed to the bug report so that they can review and hopefully sponsor the debdiff. If the attachment isn't a patch, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are member of the ~ubuntu-sponsors, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issue please contact him.]

tags: added: patch
Changed in node-mime-types (Debian):
status: Unknown → New
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package node-mime-types - 2.1.17-1ubuntu1

---------------
node-mime-types (2.1.17-1ubuntu1) cosmic; urgency=medium

  * Fix FTBFS with node-mime 2.3.1 which does not ship
    /usr/share/node-mime/types.json anymore, but ships
    /usr/share/node-mime/{standard,other}.json instead.
    (LP: #1793367)
    - debian/control: update-maintainer.
    - debian/rules: update node-mime json filenames
      (upstream in Debian source git commit e4dbb89).

 -- Mauricio Faria de Oliveira <email address hidden> Wed, 19 Sep 2018 15:41:18 -0300

Changed in node-mime-types (Ubuntu):
status: In Progress → Fix Released
Changed in node-mime-types (Debian):
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.