libnginx-mod-nchan distributes old/incompatible module

Bug #1874831 reported by Damjan Georgievski on 2020-04-24
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
nginx (Ubuntu)
Status tracked in Groovy
Focal
Medium
Unassigned
Groovy
Medium
Thomas Ward

Bug Description

The libnginx-mod-nchan package which is built from the nginx source package distributes an old nchan module. The nginx source package has bundled nchan 1.0.8 which has known issues when running with nginx >= 1.13.10

The upstream issue documents that nginx has had some changes that break nchan < v1.2.0
https://github.com/slact/nchan/issues/460

Suggestion, update nchan to >= v1.2.0 (best v1.2.7).

this is the error I get when using the `nchan_publisher_upstream_request` directive:

2020/04/24 01:00:35 [error] 9#9: *6 nchan: unexpected publisher message request body buffer location. please report this to the nchan developers. while sending to client, client: 127.0.0.1, server: _, request: "POST /publish?topic=one HTTP/1.1", subrequest: "/authorize_pub", upstream: "http://127.0.0.1:5000/authorize_pub", host: "127.0.0.1"

ProblemType: Bug
DistroRelease: Ubuntu 20.04
Package: libnginx-mod-nchan 1.17.10-0ubuntu1
Uname: Linux 5.6.6-arch1-1 x86_64
ApportVersion: 2.20.11-0ubuntu27
Architecture: amd64
CasperMD5CheckResult: skip
Date: Fri Apr 24 16:53:56 2020
ProcEnviron:
 TERM=xterm
 PATH=(custom, no user)
SourcePackage: nginx
UpgradeStatus: No upgrade log present (probably fresh install)

Damjan Georgievski (gdamjan) wrote :
Changed in nginx (Ubuntu):
status: New → Triaged

Thanks for reporting this...

I have opened an issue upstream (Debian):

https://salsa.debian.org/nginx-team/nginx/-/issues/2

Let's see what maintainers say and then we check how to move further.

Changed in nginx (Ubuntu):
importance: Undecided → Medium
Changed in nginx (Ubuntu Focal):
status: New → Triaged
importance: Undecided → Medium
Thomas Ward (teward) wrote :

We are sufficiently diverged... I would have to evaluate any module changes in terms of features for an SRU but I can queue an updated module in the packaging for Ubuntu as well.

Thanks a lot for checking this @teward! Your call, I'd say only if you think its worth the time (versus benefit). Up to you! This will be in server's team queue until its incomplete/closed. Cheers!

Thomas Ward (teward) wrote :

rafaeldtinoco: I've added this to my queue for Groovy, which means I just have more package changes to implement heh.

Groovy set to In Progress for now as i'm already working on that packaging.

Changed in nginx (Ubuntu Groovy):
assignee: nobody → Thomas Ward (teward)
status: Triaged → In Progress
Thomas Ward (teward) wrote :

Hello.

There is a SUBSTANTIAL delta between the way things're packaged wrt nchan. As such, I've had to make minor alterations to the nchan source (removal of some binary files). AN updated nginx for Groovy has been uploaded to a PPA - https://launchpad.net/~teward/+archive/ubuntu/nginx-test - and soon a Focal upload will land there.

**Please test to make sure nchan works with these changes as intended.** If it does not, then this will need additional effort to make fully functional.

Damjan Georgievski (gdamjan) wrote :

I guess the Focal packages didn't appear yet? I'll try to test with the groovy package on top of Focal docker.

Damjan Georgievski (gdamjan) wrote :

I've tested my scenario and it works fine.

Just for completeness, tested on ubuntu focal 20.04 (amd64) docker image +
libnginx-mod-nchan 1.18.0-0ubuntu2 amd64
nginx-light 1.18.0-0ubuntu2 amd64

nchan is version 1.2.7

rhe configuration snippet used is:

location /publish {
  nchan_publisher;
  nchan_channel_id $arg_topic;
  nchan_publisher_upstream_request /authorize_pub;
}

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.