Upgraded nginx-upload-progress module has showstopper

Bug #1673056 reported by Daniel K. on 2017-03-15
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
nginx (Ubuntu)
High
Thomas Ward
Zesty
High
Unassigned
Artful
High
Thomas Ward

Bug Description

In the upgrade from Yakkety to Zesty of the Nginx package (http://packages.ubuntu.com/zesty/nginx-core), the nginx-upload-progress module (https://github.com/masterzen/nginx-upload-progress-module) was updated from 0.9.1 to 0.9.2.

However, 0.9.2 does not work without an additional patch that is only present on master at this time:
https://github.com/masterzen/nginx-upload-progress-module/commit/dd138546b16a01e9c09613d02211373baf1cac02

We encountered and fixed this issue a few months ago when we upgraded the (Phusion) Passenger related Nginx package (https://github.com/phusion/passenger_apt_automation/commit/58941455b2d30de09f2d32dd87ba1c3dc3742c6f).

Sorry if this isn't the proper reporting place, I just wanted to give a helpful heads up so you don't run into the same issue.

Nish Aravamudan (nacc) on 2017-03-20
Changed in nginx (Ubuntu):
status: New → Triaged
importance: Undecided → High
Thomas Ward (teward) on 2017-03-20
Changed in nginx (Ubuntu):
assignee: nobody → Thomas Ward (teward)
Thomas Ward (teward) wrote :

A version of this is currently test building in my own local builders, before I upload to Launchpad. I had tried building yesterday but my build environments decided to die on me, so I had to rebuild my chroots for building, which took a while.

Changed in nginx (Ubuntu):
status: Triaged → In Progress
Thomas Ward (teward) on 2017-04-26
Changed in nginx (Ubuntu):
status: In Progress → Triaged
Thomas Ward (teward) on 2017-04-26
Changed in nginx (Ubuntu Zesty):
status: New → Triaged
importance: Undecided → High
Changed in nginx (Ubuntu Artful):
status: Triaged → In Progress
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package nginx - 1.12.0-0ubuntu1

---------------
nginx (1.12.0-0ubuntu1) artful; urgency=medium

  * New upstream release: 1.12.0 Stable branch.
  * All remaining Ubuntu-specific and Debian-specific changes remain
    in place with this upload, the upstream version and code are the
    only bits that have been updated, except where indicated below.
  * Remaining changes:
    - d/modules/nginx-upload-progress/config: Apply upstream patch to
      fix an issue where the module does not properly function due to
      the wrong module type being set; this prevented the module from
      working when built. (LP: #1673056)
    - d/patches: The following patches were dropped from the package
      because the changes from the patches are already incorporated
      in 1.12.0:
      - 0004-SSL-error-messages-style.patch
      - 0005-SSL-style.patch
      - 0006-SSL-support-for-multiple-curves-ticket-885.patch
    - d/patches/perl-use-dpkg-buildflags.patch: Refreshed patch to
      remove fuzz from the patch.
    - d/modules/nginx-echo: Apply upstream diff/patch to fix an FTBFS
    - d/modules/nginx-lua: Apply upstream diff/patch to fix an FTBFS
    - d/modules/nginx-upstream-fair: Apply diff/patch from the Debian
      package maintainers' git repository to not use default_port to
      fix an FTBFS. (This will eventually be in Debian, and will get
      merged in then as well).

 -- Thomas Ward <email address hidden> Wed, 26 Apr 2017 12:02:33 -0400

Changed in nginx (Ubuntu Artful):
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers