code duplication between nginx-*.postinst and init script

Bug #1578344 reported by Simon Déziel on 2016-05-04
This bug affects 1 person
Affects Status Importance Assigned to Milestone
nginx (Debian)
Fix Released
nginx (Ubuntu)
Thomas Ward
Thomas Ward

Bug Description

I noticed the nginx-*.postinst files had the same logic that is implemented by "service nginx upgrade". Please find a patch dropping the duplicated code and reusing the one from the init script. This is the same patch that was attached to

Simon Déziel (sdeziel) wrote :
Thomas Ward (teward) on 2016-05-04
Changed in nginx (Ubuntu):
status: New → Incomplete
status: Incomplete → Triaged
importance: Undecided → Low
assignee: nobody → Thomas Ward (teward)

The attachment "nginx-postinst-code-dedup.patch" seems to be a patch. If it isn't, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are a member of the ~ubuntu-reviewers, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issues please contact him.]

tags: added: patch
Changed in nginx (Debian):
status: Unknown → New
Thomas Ward (teward) wrote :

For Debian, this should be fixed up there.

For Ubuntu, this may be picked up by me after the merge. This is dependent on whether Debian updates to fix this first or not.

Changed in nginx (Debian):
status: New → Fix Committed
Changed in nginx (Debian):
status: Fix Committed → Fix Released
Thomas Ward (teward) on 2018-05-15
Changed in nginx (Ubuntu Yakkety):
status: Triaged → Won't Fix
Changed in nginx (Ubuntu):
assignee: Thomas Ward (teward) → nobody
Simon Déziel (sdeziel) on 2018-05-15
Changed in nginx (Ubuntu):
status: Triaged → Fix Released
Simon Déziel (sdeziel) wrote :

I was too quick in marking this as fix released as I noticed that Bionic's version has duplicated code in nginx-core.postinst. This seems to be Ubuntu specific as Debian doesn't have the "-core" flavor.

Thomas Ward (teward) on 2018-05-15
Changed in nginx (Ubuntu):
status: Fix Released → Triaged
status: Triaged → In Progress
assignee: nobody → Thomas Ward (teward)
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package nginx - 1.14.0-0ubuntu2

nginx (1.14.0-0ubuntu2) cosmic; urgency=medium

  * debian/nginx-core.postinst: Make nginx-*.postinst use invoke-rc.d.
    (LP: #1578344)

 -- Thomas Ward <email address hidden> Tue, 15 May 2018 11:14:02 -0400

Changed in nginx (Ubuntu):
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.