init script return okayish error value (zero) when service start failed

[Vladislav Naumov]

steps to reproduce:

# echo GIBBERISH >> /etc/nginx/nginx.conf

# service nginx restart
 * Restarting nginx nginx [fail]

# echo $?
0

very nasty when combined with ansible/other configuration management tools: broken conffiles come unnoticed.

ProblemType: Bug
DistroRelease: Ubuntu 14.04
Package: nginx-common 1.4.6-1ubuntu3.3
ProcVersionSignature: Ubuntu 3.13.0-63.103-generic 3.13.11-ckt25
Uname: Linux 3.13.0-63-generic x86_64
ApportVersion: 2.14.1-0ubuntu3.13
Architecture: amd64
Date: Tue Oct 13 15:35:25 2015
PackageArchitecture: all
ProcEnviron:
 TERM=xterm
 PATH=(custom, no user)
 XDG_RUNTIME_DIR=<set>
 LANG=en_US.UTF-8
 SHELL=/bin/bash
SourcePackage: nginx
UpgradeStatus: No upgrade log present (probably fresh install)
modified.conffile..etc.default.nginx: [modified]
modified.conffile..etc.init.d.nginx: [modified]
mtime.conffile..etc.default.nginx: 2015-10-13T15:20:30.961938
mtime.conffile..etc.init.d.nginx: 2015-10-13T15:28:28.595936

[Thomas Ward (teward)]

NACK on the patch.

The proposed patch is not the correct approach to fix this or the master bug. Debian has fixes, I'll dig them up.