[SRU] FTBFS nfs-ganesha fails to build from source on Ubuntu Groovy (gcc-10)

[Chris MacNaughton]

[Impact]

When trying to build nfs-ganesha, it fails to build with many instances of:

> /usr/bin/ld: CMakeFiles/MainServices.dir/nfs_rpc_dispatcher_thread.c.o:./src/obj-x86_64-linux-gnu/MainNFSD/./src/include/nfs_init.h:53: multiple definition of `gsh_dbus_thrid'; CMakeFiles/MainServices.dir/nfs_worker_thread.c.o:./src/obj-x86_64-linux-gnu/MainNFSD/./src/include/nfs_init.h:53: first defined here
> /usr/bin/ld: CMakeFiles/MainServices.dir/nfs_init.c.o:./src/obj-x86_64-linux-gnu/MainNFSD/./src/include/nfs_init.h:53: multiple definition of `gsh_dbus_thrid'; CMakeFiles/MainServices.dir/nfs_worker_thread.c.o:./src/obj-x86_64-linux-gnu/MainNFSD/./src/include/nfs_init.h:53: first defined here

Debian has already landed a fix at https://salsa.debian.org/debian/nfs-ganesha/-/commit/2aaca7a4e59d092218705e192910b4d8bfb3169e

The fix linked above is an upstream patch to resolve the build on gcc-10

[Test Plan]
Reproducing the bug is as easy as attempting to build the package:

pull-lp-source nfs-ganesha groovy
sbuild -A -d groovy-amd64 nfs-ganesha_3.2-2ubuntu1.dsc

[Where problems could occur]

The SRU shouldn't change the current behaviour as it's just aligning compiler support to gcc-10.

Upstream nfs-ganesha and Debian have already included this patch so I expect the risk to be low.

[Brian Murray (brian-murray)]

Hello Chris, or anyone else affected,

Accepted nfs-ganesha into groovy-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/nfs-ganesha/3.2-2ubuntu2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-groovy to verification-done-groovy. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-groovy. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Brian Murray (brian-murray)]

Hello Chris, or anyone else affected,

Accepted nfs-ganesha into groovy-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/nfs-ganesha/3.2-2ubuntu3 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-groovy to verification-done-groovy. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-groovy. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Chris MacNaughton (chris.macnaughton)]

I can confirm that this builds successfully on groovy now. Additional verification is still pending for https://bugs.launchpad.net/ubuntu/+source/nfs-ganesha/+bug/1927208 before this can be released.

[Chris MacNaughton (chris.macnaughton)]

Log from the build:

+------------------------------------------------------------------------------+
| Summary |
+------------------------------------------------------------------------------+

Build Architecture: amd64
Build Type: binary
Build-Space: 164440
Build-Time: 115
Distribution: groovy-amd64
Host Architecture: amd64
Install-Time: 127
Job: nfs-ganesha_3.2-2ubuntu3.dsc
Lintian: warn
Machine Architecture: amd64
Package: nfs-ganesha
Package-Time: 304
Source-Version: 3.2-2ubuntu3
Space: 164440
Status: successful
Version: 3.2-2ubuntu3

[Launchpad Janitor (janitor)]

This bug was fixed in the package nfs-ganesha - 3.2-2ubuntu3

---------------
nfs-ganesha (3.2-2ubuntu3) groovy; urgency=medium

  * d/nfs-ganesha-ceph.install: Remove duplicate shared libraries for
    RADOS URLs and recovery. Already provided by nfs-ganesha.install
    (LP: #1927208).

nfs-ganesha (3.2-2ubuntu2) groovy; urgency=medium

  * d/nfs-ganesha-ceph.install: Include shared libraries for RADOS URLs
    and recovery (LP: #1927208).
  * d/p/fix-FTBFS-gcc-10.patch: fix FTBFS with gcc-10 (LP: #1927750).

 -- Chris MacNaughton <email address hidden> Fri, 14 May 2021 12:31:11 +0000

[Brian Murray (brian-murray)]

The verification of the Stable Release Update for nfs-ganesha has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.