[SRU]fix crash when suspend & resume when using WWAN with PIN set on SIM

Bug #1582301 reported by errors.ubuntu.com bug bridge on 2016-05-16
This bug affects 1 person
Affects Status Importance Assigned to Milestone
network-manager (Ubuntu)
Shih-Yuan Lee
Aron Xu

Bug Description

There is a rate of crash when doing suspend and resume test when using WWAN with PIN set on SIM.

[Test Case]
With WWAN enabled, and have PIN set on SIM, doing stress test of suspend & resume, some crash may be observed in network-manager.

Also the e.u.c should no longer receive the same crash reports after installing the update.

[Regression Potential]
The fix is checking a pointer before loop traverse which should be fair safe.

Original report:

The Ubuntu Error Tracker has been receiving reports about a problem regarding network-manager-applet. This problem was most recently seen with version 1.2.0-0ubuntu0.16.04.1, the problem page at https://errors.ubuntu.com/problem/e2c7668fff4fd9f50cb38d0308d51153640d5386 contains more details.

Sebastien Bacher (seb128) wrote :

The issue seems to be discussed on the upstream mailing list https://mail.gnome.org/archives/networkmanager-list/2016-May/msg00000.html

Changed in network-manager-applet (Ubuntu):
importance: Undecided → High
status: New → Confirmed
Shih-Yuan Lee (fourdollars) wrote :

The upstream suggested another solution for this issue at https://mail.gnome.org/archives/networkmanager-list/2016-May/msg00011.html.

Changed in network-manager-applet (Ubuntu):
assignee: nobody → Shih-Yuan Lee (fourdollars)
affects: network-manager-applet (Ubuntu) → network-manager (Ubuntu)
Changed in network-manager (Ubuntu):
assignee: Shih-Yuan Lee (fourdollars) → nobody
assignee: nobody → Shih-Yuan Lee (fourdollars)
Changed in network-manager (Ubuntu):
status: Confirmed → Triaged
Shih-Yuan Lee (fourdollars) wrote :
Changed in network-manager (Ubuntu):
status: Triaged → In Progress

The attachment "network-manager_1.2.2-0ubuntu2.debdiff" seems to be a debdiff. The ubuntu-sponsors team has been subscribed to the bug report so that they can review and hopefully sponsor the debdiff. If the attachment isn't a patch, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are member of the ~ubuntu-sponsors, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issue please contact him.]

tags: added: patch
Changed in network-manager:
importance: Unknown → Medium
status: Unknown → Confirmed
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package network-manager - 1.2.2-0ubuntu2

network-manager (1.2.2-0ubuntu2) yakkety; urgency=medium

  * debian/patches/libnm-Check-self-still-NMManager-or-not.patch: Avoid the
    crash of network-manager-applet. (LP: #1582301)

 -- Shih-Yuan Lee (FourDollars) <email address hidden> Wed, 18 May 2016 17:27:42 +0800

Changed in network-manager (Ubuntu):
status: In Progress → Fix Released
Changed in network-manager (Ubuntu Xenial):
importance: Undecided → High
status: New → In Progress
assignee: nobody → Aron Xu (happyaron)
Aron Xu (happyaron) on 2016-06-16
summary: - /usr/bin/nm-connection-
- editor:11:recheck_pending_activations:g_closure_invoke:signal_emit_unlocked_R:g_signal_emit_valist:g_signal_emit
+ [SRU]fix crash when suspend & resume when using WWAN with PIN set on SIM
Aron Xu (happyaron) on 2016-06-16
description: updated
Aron Xu (happyaron) on 2016-06-16
Changed in network-manager (Ubuntu Xenial):
status: In Progress → Triaged
Aron Xu (happyaron) on 2016-06-23
tags: added: desktop-trello-import

Hello errors.ubuntu.com, or anyone else affected,

Accepted network-manager into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/network-manager/1.2.2-0ubuntu0.16.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in network-manager (Ubuntu Xenial):
status: Triaged → Fix Committed
tags: added: verification-needed
Aron Xu (happyaron) wrote :

This works fine for me, marking as verification-done.

tags: added: verification-done
removed: verification-needed

The verification of the Stable Release Update for network-manager has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Launchpad Janitor (janitor) wrote :

This bug was fixed in the package network-manager - 1.2.2-0ubuntu0.16.04.1

network-manager (1.2.2-0ubuntu0.16.04.1) xenial; urgency=medium

  * Rebase to upstream 1.2.2 release, patches: (LP: #1589557)
    - dnsmasq-vpn-dns-filtering.patch: updated
    - nm-change-dnsmasq-parameters.diff: updated
    - 0001-dns-use-DBus-to-make-dnsmasq-nameserver-changes.patch: dropped
    - lp1574347-re-read-link-type-if-the-name-changed.diff: dropped
    - libnm-Check-self-still-NMManager-or-not.patch: (LP: #1582301)
    - libnm-don-t-require-initialized-out_encrypted-argume.patch:
      (LP: #1575614)

 -- Aron Xu <email address hidden> Sat, 04 Jun 2016 18:27:47 +0800

Changed in network-manager (Ubuntu Xenial):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.