[wily-proposed] --config option not respected any more (causes test failures)

Bug #1492168 reported by Martin Pitt on 2015-09-04
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
network-manager (Ubuntu)
High
Mathieu Trudel-Lapierre

Bug Description

Pretty much all NM integration tests fail on the wily-proposed version (1.0.4), as NM tears down the (fake) "remote" side of the hwsim wifi and veth interfaces. Turns out this is due to not respecting the local --config option any more, which blacklists these devices to avoid NM tearing them down at startup:

$ NetworkManager --log-level=debug --debug --config=/tmp/tmpyehdrfvu/NetworkManager.conf
NetworkManager-Message: <info> No config file found or given; using /etc/NetworkManager/NetworkManager.conf
NetworkManager[5227]: <info> Read config: /etc/NetworkManager/NetworkManager.conf
[...]

In the Ubuntu packaging bzr I reverted most of the disabling of tests, and also tuned the timeouts back down to reasonable values. On top of that, if you change

--- debian/tests/nm 2015-09-04 09:06:44 +0000
+++ debian/tests/nm 2015-09-04 09:07:05 +0000
@@ -75,7 +75,8 @@
                         blacklist += ';'
                     blacklist += 'mac:%s' % f.read().strip()

- conf = os.path.join(self.workdir, 'NetworkManager.conf')
+ #conf = os.path.join(self.workdir, 'NetworkManager.conf')
+ conf = '/etc/NetworkManager/NetworkManager.conf'
         extra_main = ''
         if not auto_connect:
             extra_main += 'no-auto-default=*\n'

to work around this bug, all the tests succeed again, at least on amd64. On i386 they still fail because NM crashes right away (bug 1492126).

Martin Pitt (pitti) on 2015-09-04
Changed in network-manager (Ubuntu):
assignee: nobody → Mathieu Trudel-Lapierre (mathieu-tl)
Changed in network-manager (Ubuntu):
status: New → In Progress
importance: Undecided → High
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package network-manager - 1.0.4-0ubuntu3

---------------
network-manager (1.0.4-0ubuntu3) wily; urgency=medium

  * New upstream NM release post-feature-freeze. (LP: #1493934)
    (previous revisions never transitioned from proposed)

  [ Martin Pitt ]
  * debian/tests/nm: Revert the previous disabling of tests, they are all
    conceptually still valid.
  * debian/tests/nm: Reduce timeouts to something reasonable; waiting 3
    minutes for detecing an AP should not count as "success", and it takes too
    long for tests to fail.
  * debian/tests/nm: Fix ColdplugWifi.test_no_ap: with 1.0 the state is now
    "UNAVAILABLE" instead of "DISCONNECTED"; so check for either.

  [ Mathieu Trudel-Lapierre ]
  * debian/patches/git_config_parse_cmdline_args_8a22a981.patch: don't shadow
    the config_cli parameter for early config with a local copy. (LP: #1492168)
  * d/p/0001-wwan-add-support-for-using-oFono-as-a-modem-manager.patch: fix
    signal handling for oFono using GDBus; it's a little simpler now, watching
    for signals in general and matching only ModemAdded/ModemRemoved. Inspired
    from urfkill code. (LP: #1492126)
  * debian/patches/git_fix_duplicate_unittest_names_7b70a840.patch: replace
    duplicate unit test names, which is a new restriction set by GLib.

 -- Mathieu Trudel-Lapierre <email address hidden> Thu, 10 Sep 2015 14:53:16 -0400

Changed in network-manager (Ubuntu):
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers