regression: Upstream DNS server failure when server doesn't push DOMAINs

[Francois Deppierraz]

The upgrade of network-manager-openvpn from 0.9.8.0 to 0.9.8.2 seems to expose a regression in setups where the openvpn server pushes default DNS servers to the clients without any explicit DOMAIN options.

Openvpn server configuration:

[...]
push "dhcp-option DNS 62.1.2.3"
push "dhcp-option DNS 62.1.2.4"
# no dhcp-option DOMAIN pushed
[...]

Here are the logs from the client before and after upgrading the network-manager-openvpn package:

network-manager-openvpn==0.9.8.0-2ubuntu1:

Mar 14 14:37:31 claw dnsmasq[2676]: setting upstream servers from DBus
Mar 14 14:37:31 claw dnsmasq[2676]: using nameserver 62.1.2.3#53
Mar 14 14:37:31 claw dnsmasq[2676]: using nameserver 62.1.2.4#53

network-manager-openvpn==0.9.8.2-1ubuntu4

Mar 14 14:48:27 claw dnsmasq[2676]: setting upstream servers from DBus
Mar 14 14:48:27 claw dnsmasq[2676]: using nameserver 62.1.2.3#53 for domain 62.in-addr.arpa
Mar 14 14:48:27 claw dnsmasq[2676]: using nameserver 62.1.2.4#53 for domain 62.in-addr.arpa

Result is that DNS resolution is now broken:

$ host www.ubuntu.com
Host www.ubuntu.com not found: 5(REFUSED)
$

[Francois Deppierraz (francois-ctrlaltdel)]

Tested on a trusty machine upgraded from saucy.