nm-applet leaks in get_best_icon_name_for_ap() (or its uses)
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
network-manager-applet (Ubuntu) |
Fix Released
|
High
|
Mathieu Trudel-Lapierre | ||
Natty |
Fix Released
|
High
|
Mathieu Trudel-Lapierre |
Bug Description
As found in the attached valgrind log for bug 708118; nm-applet appears to leak memory due to the use of get_best_
Indeed, it uses calls to g_strdup_printf() to generate a string to return, but the returned string is not freed by the callers.
For reference, one of the entries to this regard from the valgrind log:
==2475== 39 bytes in 3 blocks are definitely lost in loss record 6,865 of 11,591
==2475== at 0x4026654: malloc (vg_replace_
==2475== by 0x49257EF: __vasprintf_chk (vasprintf_
==2475== by 0x47F1642: g_vasprintf (stdio2.h:199)
==2475== by 0x47CAA21: g_strdup_vprintf (gstrfuncs.c:255)
==2475== by 0x47CAA53: g_strdup_printf (gstrfuncs.c:281)
==2475== by 0x806D2FB: get_best_
==2475== by 0x806F19B: wireless_
==2475== by 0x805D33A: status_
==2475== by 0x47A5450: g_idle_dispatch (gmain.c:4537)
==2475== by 0x47A9C07: g_main_
==2475== by 0x47AA3CF: g_main_
==2475== by 0x47AAA92: g_main_loop_run (gmain.c:3299)
==2475== by 0x8059346: main (main.c:101)
Changed in network-manager-applet (Ubuntu): | |
status: | New → In Progress |
importance: | Undecided → High |
assignee: | nobody → Mathieu Trudel-Lapierre (mathieu-tl) |
Changed in network-manager-applet (Ubuntu): | |
status: | Fix Released → In Progress |
This bug was fixed in the package network- manager- applet - 0.8.4~git. 20110228t141430 .abba62f- 0ubuntu1
--------------- manager- applet (0.8.4~ git.20110228t14 1430.abba62f- 0ubuntu1) natty; urgency=low
network-
* upstream snapshot 2011-02-28 14:14:30 (GMT) bb84f12875fd361 2b90ead434 update_ secrets( ) (LP: #721071) patches/ nm-applet- use-indicator. patch: Further update indicator icon_name_ for_ap( ). (LP: #724554) patches/ nm-applet- use-indicator. patch: Set indicator icon for mobile patches/ indicator- accessible- desc.patch: provide accessible
+ abba62fe1c22422
- editor: fix usage of nm_connection_
- release: bump version to 0.8.3.996 (0.8.4-beta2)
- mobile: fix path to GtkBuilder file
- applet: blacklist "Free Public Wifi" (LP: #659461)
- applet: consolidate manufacturer default SSID lists
- release: bump version to 0.8.3.995 (0.8.4-beta1)
- release: update NEWS with changes since 0.8.2
- editor: remove unused argument from CEPage 'initialized' signal
- bluetooth: don't create empty plugin dirs when disabled (bgo #641300)
- Updated Polish translation
* debian/
patch to fix memory leaks in get_best_
* debian/
according to the connection's current signal strength (LP: #726669)
* debian/
descriptions for the various icons and devices states for NetworkManager
(LP: #719736)
-- Mathieu Trudel-Lapierre <email address hidden> Fri, 04 Mar 2011 15:05:58 -0500