"Connection Established" is miscapitalized

Bug #367853 reported by Matthew Paul Thomas
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
network-manager-applet (Ubuntu)
Fix Released
Low
Mathieu Trudel-Lapierre

Bug Description

Ubuntu 9.04

1. Connect to the Internet.

What happens: A notification bubble appears with body text "Connection Established".
What should happen: The body text should say "Connection established". <https://wiki.ubuntu.com/NotifyOSD#Network%20Manager>

(This is the successor to bug 330526.)

tags: added: notifications
Changed in network-manager-applet (Ubuntu):
status: New → Confirmed
Revision history for this message
Timothy Arceri (t-fridey) wrote :

Its been over 3 years since this was reported surely this should be targeted for 13.04

Revision history for this message
Mathieu Trudel-Lapierre (cyphermox) wrote :

Surely the fact that this is a cosmetic bug should suggest that there are higher priorities, which could explain why I haven't touched this yet.

Additionally, I'm strongly objecting to carrying a distro patch just for decapitalizing an 'e'; especially when the exact behavior is likely to be very different on different languages; and because it would unnecessarily add to patch burden to carry a patch that needs to be regularly updated, just for one character to be changed. For example, on my own system (in french), the text is correctly capitalized.

I'm not a native english speaker, so I'm not totally familiar with how capitalization should work in such cases. Can you bring up evidence that this is incorrect use? With this, it should be trivial to bring up the issue upstream and have the string changed upstream.

Changed in network-manager-applet (Ubuntu):
status: Confirmed → Incomplete
importance: Undecided → Low
Revision history for this message
Timothy Arceri (t-fridey) wrote :

How rude. I spent most of my day off yesterday marking bugs in this project as duplicates. Or incomplete if they only had information that related to Ubuntu releases that are no longer supported. Also I was taking note of bugs which I could provide patches for even if that means sending them up stream. I would have assumed since the official design document says the letter should be lowercase then that's what's right. I only suggested this should be targeted for next release I never said you should do the work. I now wish I had spent my time helping a package maintainer who was a little more appreciative.

Changed in network-manager-applet (Ubuntu):
assignee: nobody → Timothy Arceri (t-fridey)
status: Incomplete → In Progress
Revision history for this message
Timothy Arceri (t-fridey) wrote :

Upstreams use of "Connection Established" is correct as its used as a title. There is usually a message that accompanies it. For wifi its "You are now connected to the Wi-Fi network '%s'."

However in Ubuntu we don't display this message. We display the Title as the message therefore it should be "Connection established" I'm not sure how we should solve this. Upstream is correct, and it is silly to have a patch just to change the case of one character downstream.

Matthew do you have any suggestions from a design perspective?

Changed in network-manager-applet (Ubuntu):
assignee: Timothy Arceri (t-fridey) → nobody
status: In Progress → Confirmed
Revision history for this message
Matthew Paul Thomas (mpt) wrote :

For why "You are now connected to the Wi-Fi network '%s'." was removed, see bug 330526.

I reported this bug. However, I would be even happier if the bubble just said "Connected". This would mirror the "Disconnected" message when the opposite happens.

Revision history for this message
Mathieu Trudel-Lapierre (cyphermox) wrote :

Timothy Arceri, sorry if I was rude, it wasn't the intent.

I'm very appreciative of the work, I just meant that since I'm not bad at English but not a native speaker, I would like to have a clearer idea of how the text should be before carying a patch at all, and before submitting one upstream.

Matthew, thanks. This sounds like a nice way to put it too -- I'm in the process of reviewing all of the patches for nm-applet; and the patches for these bugs are both very old, and regularly need to be updated to be applicable to the upstream code. I want to suggest them for inclusion upstream as soon as we reach a good conclusion (and I think we did), along with the other related changes in the notification bubbles. The only step left will be to verify how this compares to the Gnome Shell design for notifications, just to have an idea how well the patch might be received.

At this point, I'm assigning myself, for the patch to submit and verifying the Shell behavior.

Changed in network-manager-applet (Ubuntu):
status: Confirmed → Triaged
assignee: nobody → Mathieu Trudel-Lapierre (mathieu-tl)
status: Triaged → In Progress
Revision history for this message
Mathieu Trudel-Lapierre (cyphermox) wrote :

Seems like this has been fixed since the last comments, closing as Fix Released.

Changed in network-manager-applet (Ubuntu):
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.