GSM connection message too long in nm-applet

Bug #330608 reported by Cody Russell on 2009-02-17
2
Affects Status Importance Assigned to Milestone
network-manager-applet (Ubuntu)
Low
Unassigned

Bug Description

When you connect to a GSM network, Network Manager puts up a notification bubble with:
* title "Connection Established" (with upper-case "e")
* body "You are now connected to '%s'" OR "You are now connected to the GSM network."

This text is unnecessarily long, and the network name arguably should be more prominent because it is more variable while "Connection established" is always the same.

Instead, the bubble should appear with:
* title "%s" (just the name of the network) OR "GSM network"
* body "Connection established" (with lower-case "e").

Cody Russell (bratsche) wrote :
Pedro Villavicencio (pedro) wrote :

Alexander may you have a look to the patch? thanks.

Changed in network-manager-applet:
importance: Undecided → Low
status: New → Triaged
Alexander Sack (asac) wrote :

Thanks for the patch.

bzr commit -m '* fix LP: #330608 - GSM connection message too long in nm-applet
  - add patches/lp330608_dxteam_gsm_connect_text.patch
  - update patches/series' --fixes 'lp:330608'
Enter passphrase for key '/home/asac/.ssh/id_rsa':
Committing to: bzr+ssh://bazaar.launchpad.net/~network-manager/network-manager-applet/ubuntu.0.7.1/
modified changelog
added patches/lp330608_dxteam_gsm_connect_text.patch
modified patches/series
Committed revision 23.

Changed in network-manager-applet:
status: Triaged → Fix Committed
Alexander Sack (asac) wrote :

please remember to mark your branch as merged (so it disappears from the list). next time consider to use launchpad to request a merge. in that way it will automatically be moved to merged state.

Launchpad Janitor (janitor) wrote :

This bug was fixed in the package network-manager-applet - 0.7.1~rc3-0ubuntu1

---------------
network-manager-applet (0.7.1~rc3-0ubuntu1) jaunty; urgency=low

  * new upstream RC 0.7.1rc3
    + rev: 982
    + revision-id: svn-v3-trunk0:9c6bbc85-7128-0410-879a-9bbc9e4270e9:branches%2FNETWORKMANAGER_APPLET_0_7:1212
    + branch: http://bzr-playground.gnome.org/network-manager-applet/branches/NETWORKMANAGER_APPLET_0_7/
    - update .bzr-builddeb/default.conf
  * bump lower builds for network-manager build depends to >= 0.7.1~rc3
    - update control
  * fix LP: #328572 - Connecting/disconnecting notification changes; we apply the
    the "Connecting" part of this patch, as the disconnecting part would require
    string changes that need to be done upstream
    - add patches/lp328572-dxteam-connect-text.patch
    - update patches/series
  * fix LP: #330571 - Wired connected message in nm-applet too long
    - add patches/lp330571_dxteam_wired_connect_text.patch
    - update patches/series
  * fix LP: #330608 - GSM connection message too long in nm-applet
    - add patches/lp330608_dxteam_gsm_connect_text.patch
    - update patches/series
  * fix LP: #337960 - nm-applet jaunty icon changes - brought to you by d(u)xteam;
    we apply two patches: first patch changes the icon names referred to in notifications;
    second patch ships fallback icons for those names within network-manager-gnome
    package

 -- Alexander Sack <email address hidden> Thu, 05 Mar 2009 01:30:46 +0100

Changed in network-manager-applet:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers