| 2019-05-15 15:53:37 |
Mathieu Trudel-Lapierre |
bug |
|
|
added bug |
| 2019-05-15 15:53:48 |
Mathieu Trudel-Lapierre |
bug task added |
|
netplan |
|
| 2019-05-28 21:06:35 |
Launchpad Janitor |
netplan.io (Ubuntu): status |
New |
Confirmed |
|
| 2019-05-28 21:07:25 |
Ryan Harper |
netplan: status |
New |
Fix Committed |
|
| 2019-08-22 01:13:47 |
Launchpad Janitor |
netplan.io (Ubuntu): status |
Confirmed |
Fix Released |
|
| 2019-08-27 16:34:17 |
Mathieu Trudel-Lapierre |
description |
https://github.com/CanonicalLtd/netplan/blob/ea47bd4e1c5319b1a624ea61c843ee96e7c128da/src/networkd.c#L208
The separator used to add multiple ARP IP targets for the networkd renderer is ",".
Unfortunately, networkd doesn't allow that, but rather expects whitespace:
(in config_parse_arp_ip_target_address():)
[...]
for (;;) {
[...]
r = extract_first_word(&rvalue, &n, NULL, 0);
extract_first_word's third parameter is const char *separators; where NULL is handled like so (src/basic/extract-word.c:37):
if (!separators)
separators = WHITESPACE;
Finally:
src/basic/string-util.h:#define WHITESPACE " \t\n\r"
So; it doesn't handle commas for the list, just whitespace; so let's give it whitespace please :) |
[Impact]
Users of netplan who need to configure multiple values for ARP IP targets.
[Test case]
Write a valid configuration for a bond with multiple ARP IP targets:
network:
version: 2
renderer: networkd
bond:
bd0:
[...]
parameters:
arp-ip-targets: [ 192.168.3.56, 192.168.3.59 ]
Verify that the configuration is sucessfully applied, and shows up in the /sys filesystem for the affected device:
/sys/class/net/bd0/bonding/arp_ip_targets
[Regression potential]
This affects only this particular value and generating a valid configuration file for the networkd renderer. The existing configuration file generation is /invalid/, but working as the bad value is ignored by systemd-networkd. This changes the generation of the configuration file only, to write the proper sequence of values for ARPIPTargets=.
---
https://github.com/CanonicalLtd/netplan/blob/ea47bd4e1c5319b1a624ea61c843ee96e7c128da/src/networkd.c#L208
The separator used to add multiple ARP IP targets for the networkd renderer is ",".
Unfortunately, networkd doesn't allow that, but rather expects whitespace:
(in config_parse_arp_ip_target_address():)
[...]
for (;;) {
[...]
r = extract_first_word(&rvalue, &n, NULL, 0);
extract_first_word's third parameter is const char *separators; where NULL is handled like so (src/basic/extract-word.c:37):
if (!separators)
separators = WHITESPACE;
Finally:
src/basic/string-util.h:#define WHITESPACE " \t\n\r"
So; it doesn't handle commas for the list, just whitespace; so let's give it whitespace please :) |
|
| 2019-08-27 22:48:19 |
Brian Murray |
netplan.io (Ubuntu Bionic): status |
New |
Fix Committed |
|
| 2019-08-27 22:48:20 |
Brian Murray |
bug |
|
|
added subscriber Ubuntu Stable Release Updates Team |
| 2019-08-27 22:48:22 |
Brian Murray |
bug |
|
|
added subscriber SRU Verification |
| 2019-08-27 22:48:26 |
Brian Murray |
tags |
|
verification-needed verification-needed-bionic |
|
| 2019-09-30 21:49:28 |
Mathieu Trudel-Lapierre |
tags |
verification-needed verification-needed-bionic |
verification-done-bionic verification-needed |
|
| 2019-09-30 21:53:10 |
Mathieu Trudel-Lapierre |
tags |
verification-done-bionic verification-needed |
verification-done-bionic verification-done-disco |
|
| 2019-10-02 21:47:29 |
Brian Murray |
nominated for series |
|
Ubuntu Disco |
|
| 2019-10-02 21:47:29 |
Brian Murray |
bug task added |
|
netplan.io (Ubuntu Disco) |
|
| 2019-10-02 21:47:37 |
Brian Murray |
netplan.io (Ubuntu Disco): status |
New |
Fix Committed |
|
| 2019-10-02 21:54:51 |
Launchpad Janitor |
netplan.io (Ubuntu Disco): status |
Fix Committed |
Fix Released |
|
| 2019-10-02 21:55:08 |
Launchpad Janitor |
netplan.io (Ubuntu Bionic): status |
Fix Committed |
Fix Released |
|
| 2019-10-02 21:55:38 |
Brian Murray |
removed subscriber Ubuntu Stable Release Updates Team |
|
|
|
| 2021-03-25 12:14:05 |
Lukas Märdian |
netplan: status |
Fix Committed |
Fix Released |
|
