SRU ndctl into Bionic

Bug #1781268 reported by Andreas Hasenack on 2018-07-11
20
This bug affects 2 people
Affects Status Importance Assigned to Milestone
ndctl (Ubuntu)
Undecided
Andreas Hasenack
Bionic
Undecided
Unassigned

Bug Description

[Impact]
The support for Intel NVDIMM technology requires both kernel and userspace components. The kernel components have landed in 4.15 and are available in Bionic. In order for users to take advantage of NVDIMMs in their deployments, the following userspace packages are also needed in Bionic:

ndctl -- Utility library for managing the libnvdimm (non-volatile memory device) sub-system in the Linux kernel.
Upstream project: https://github.com/pmem/ndctl

PMDK -- persistent memory toolkit
Upstream project: https://github.com/pmem/pmdk/

This SRU is about ndctl; pmdk is being handled in bug #1781269. Both should be accepted at the same time.

This SRU falls under the hardware enablement category.

[Test Case]
* Install daxctl and ndctl
sudo apt install daxctl ndctl

* download the two dep8 test scripts:
wget https://git.launchpad.net/~usd-import-team/ubuntu/+source/ndctl/plain/debian/tests/daxctl-commands https://git.launchpad.net/~usd-import-team/ubuntu/+source/ndctl/plain/debian/tests/ndctl-commands

* execute them and verify exit status, which should be zero:
sh ./daxctl-commands; echo $?
sh ./ndctl-commands; echo $?

More detailed testing can be executed if the appropriate hardware is available.

[Regression Potential]
These are NEW packages for bionic. They were accepted into the archive after a lengthy review. It is lintian clear, with appropriate overrides or an explanation in README.source.

This package includes libraries, which could inadvertently become new dependencies. If a package has support for ndctl, for example, but it was always disabled because there was no ndctl in the archive, it could now be inadvertently enabled merely by having the lib*-dev package(s) installed.

Similarly, code paths in existing packages that would never have been traversed because of the lack of ndctl support, now could be exposed.

[Other Info]
Since the package doesn't exist in bionic, I don't think I can make an MP.

Here is the branch that represents the bionic source package, though:
https://code.launchpad.net/~ahasenack/ubuntu/+source/ndctl/+git/ndctl/+ref/bionic-ndctl. It's just cosmic with a changelog update for this sru.

You should be able to build a source package from that. Alternatively, you can download it from ppa:canonical-server/nvdimm, but the packages there have a ~ppaN suffix, so keep that in mind.

The git master branch at https://git.launchpad.net/~ahasenack/ubuntu/+source/ndctl/log/?h=master shows all the work that was put into this package to make it suitable for Ubuntu inclusion.
The bug at https://bugs.launchpad.net/bugs/1752378 also contains a lengthy history and discussions about some of the finer details, and is linked to from files in debian/* where further explanation was necessary about some behavior.

description: updated
Launchpad Janitor (janitor) wrote :

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in ndctl (Ubuntu):
status: New → Confirmed
description: updated
description: updated
description: updated
description: updated
description: updated
Changed in ndctl (Ubuntu):
milestone: ubuntu-18.04.1 → bionic-updates
status: Confirmed → In Progress
description: updated
description: updated
description: updated
description: updated
Robie Basak (racb) wrote :

Sponsored. Now in Bionic NEW.

Hello Andreas, or anyone else affected,

Accepted ndctl into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/ndctl/61.2-0ubuntu1~18.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-bionic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in ndctl (Ubuntu Bionic):
status: New → Fix Committed
tags: added: verification-needed verification-needed-bionic
Michael Reed (mreed8855) wrote :

I built and installed the packages and executed the tests. Both tests resulted in a return code of zero.

Here is the output:

ubuntu@R740xd-nvme-57:~/tests/ndtl_test$ sh ./daxctl-commands; echo $?
Available commands from daxctl --list-cmds:
version
list
help
Checking we have a working version command:
Version: 61.2+
0

ubuntu@R740xd-nvme-57:~/tests/ndtl_test$ sh ./ndctl-commands; echo $?
Available commands from ndctl --list-cmds:
version
enable-namespace
disable-namespace
create-namespace
destroy-namespace
check-namespace
enable-region
disable-region
enable-dimm
disable-dimm
zero-labels
read-labels
write-labels
init-labels
check-labels
inject-error
update-firmware
inject-smart
wait-scrub
start-scrub
list
help
Checking we have a working version command:
Version: 61.2+
0

Michael Reed (mreed8855) wrote :

This was verified without the hardware

tags: added: verification-done-bionic
removed: verification-needed verification-needed-bionic

Michael - Canonical has access to Apache Pass hardware.
Please work with Bradd Fig to get testing access.
Thanks

ndctl v62 will be the appropriate version to be updated.
Thanks

Łukasz Zemczak (sil2100) wrote :

Waiting for hardware-related verification.

Chris Halse Rogers (raof) wrote :

(Marking the non-Bionic task as Fix Released - ndctl 61.2-0ubuntu1 is now in cosmic/universe)

Changed in ndctl (Ubuntu):
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers