[SRU] nautilus-dropbox needs a dependency on libappindicator1

[Gilles Gravier]

[Impact]

 * On a fresh Ubuntu 13.10 Sucay Salamander installation, if a user install the Dropbox client from the Ubuntu archive (multiverse section) there is no icon in the notification area on the panel, even if the program works fine.

 * The fix is very easy, as adding `libappindicator1` in the the Recommends field.

[Test Case]

 * Simply, on a fresh installation of Ubuntu 13.10 install the Dropbox client (from the Ubuntu Software Center or via the command line using `sudo apt-get install nautilus-dropbox`).
 * Start the program someway (from the dash, for example).
 * Dropbox starts working (there are notification bubbles), but there is no notification icon on the panel.

[Regression Potential]

 * There is no potential regression.

 * I tested the fix both installing the fixed package in fresh Ubuntu installations and in installations with previous dropbox package, both for amd64 and i386 package.

[Other Info]
 * In trusty this was fixed in the version 1.6.0-2, with the same patch.
 * Attached to this bug there is the debdiff from the previous Ubuntu package 1.4.0-3 in saucy.

[Launchpad Janitor (janitor)]

Status changed to 'Confirmed' because the bug affects multiple users.

[Amr Ibrahim (amribrahim1987)]

Refer to this bug https://bugs.launchpad.net/ubuntu/+source/nautilus-dropbox/+bug/1211066

[Mattia Rizzolo (mapreri)]

I'm going to make a SRU...

[Gilles Gravier (gillesgravier)]

Thanks. It's a very simple change and shouldn't have side effects. (Has none that I noticed, once libappindicator1 is installed.

[clel (clel)]

Still there is the problem with Copy.com client mentioned here https://bugs.launchpad.net/ubuntu/+source/nautilus-dropbox/+bug/1211066

[Thomas Ward (teward)]

clel: Bug 1211066 is marked as a duplicate of this bug, if the root cause is the same then when this bug is fixed it should fix the other issues as quoted in Bug 1211066 and Bug 1228971 (which is also marked as a duplicate of this one).

[Mattia Rizzolo (mapreri)]

This debdiff fix the issue in trusty. Once it's uploaded to trusty, I can apply to an SRU for uploading the saucy debdiff to saucy.

[Chow Loong Jin (hyperair)]

I did some poking around, and it looks like dropbox directly uses libappindicator via ctypes rather than through the appindicator Python module, so it would be right to depend on libappindicator1 rather than python-appindicator.

[Chow Loong Jin (hyperair)]

Actually, I think it works without libappindicator on other DEs, so perhaps this should be Recommends instead. I'll make the change in Debian, thanks for the patch.

[Mattia Rizzolo (mapreri)]

I don't think uploading this to Debian is correct: Debian doesn't need it.
Its a only-Ubuntu issue related to how unity manage the panel...
Maybe we should reccomend it only in Ubuntu.

Anyway, I think that we should depends on it, since without that library
there is a feature (the indicator) that doesn't work.

[Chow Loong Jin (hyperair)]

On Wed, Nov 06, 2013 at 06:27:25AM -0000, Mattia Rizzolo wrote:
> I don't think uploading this to Debian is correct: Debian doesn't need it.
> Its a only-Ubuntu issue related to how unity manage the panel...
> Maybe we should reccomend it only in Ubuntu.

Debian also has parts of the indicator stack, so it might be useful there.

> Anyway, I think that we should depends on it, since without that library
> there is a feature (the indicator) that doesn't work.

It'll work in other desktop environment, meaning it's not strictly necessary. In
any case, recommends is installed by default, so I think it should be fine.

--
Kind regards,
Loong Jin

[Mattia Rizzolo (mapreri)]

On Nov 6, 2013 8:41 AM, "Chow Loong Jin" <email address hidden> wrote:
>
> On Wed, Nov 06, 2013 at 06:27:25AM -0000, Mattia Rizzolo wrote:
> > I don't think uploading this to Debian is correct: Debian doesn't need
it.
>
> Debian also has parts of the indicator stack, so it might be useful
> there.

OK. Can you upload (and sync) this on Debian today, so we can make an sru?
There are a lot of people complaining about this and I would like to see
this fixed

> > Anyway, I think that we should depends on it, since without that library
> > there is a feature (the indicator) that doesn't work.
>
> It'll work in other desktop environment, meaning it's not strictly
necessary. In
> any case, recommends is installed by default, so I think it should be
fine.

It's fine by me, even if I prefer to see it as a depends rather than a
reccomends, but it's fine anyway.

[Chow Loong Jin (hyperair)]

On Wed, Nov 06, 2013 at 08:31:58AM -0000, Mattia Rizzolo wrote:
> On Nov 6, 2013 8:41 AM, "Chow Loong Jin" <email address hidden> wrote:
> >
> > On Wed, Nov 06, 2013 at 06:27:25AM -0000, Mattia Rizzolo wrote:
> > > I don't think uploading this to Debian is correct: Debian doesn't need
> it.
> >
> > Debian also has parts of the indicator stack, so it might be useful
> > there.
>
> OK. Can you upload (and sync) this on Debian today, so we can make an sru?
> There are a lot of people complaining about this and I would like to see
> this fixed

Yeah, give me a couple of hours. /me is still at work. Do you want to work on
updating the SRU patch or shall I do it?

> > > Anyway, I think that we should depends on it, since without that library
> > > there is a feature (the indicator) that doesn't work.
> >
> > It'll work in other desktop environment, meaning it's not strictly
> necessary. In
> > any case, recommends is installed by default, so I think it should be
> fine.
>
> It's fine by me, even if I prefer to see it as a depends rather than a
> reccomends, but it's fine anyway.

--
Kind regards,
Loong Jin

[Mattia Rizzolo (mapreri)]

On Nov 6, 2013 10:11 AM, "Chow Loong Jin" <email address hidden> wrote:
> Yeah, give me a couple of hours. /me is still at work. Do you want to
work on
> updating the SRU patch or shall I do it?

I can do it in about 4 hours, now I am at school (10.20 am here).
I shall update patches on my own, so I can remove the old one and keep
clean the bug report.

[Mattia Rizzolo (mapreri)]

OK, so here is a (hoping final) debdiff for saucy, where I added a recommend on libappindicator1.

When you upload the package to sid and sync it in trusty I'll move on and change the title/description to request the SRU.

[Launchpad Janitor (janitor)]

This bug was fixed in the package nautilus-dropbox - 1.6.0-2

---------------
nautilus-dropbox (1.6.0-2) unstable; urgency=low

  * [207aa03] Add recommends on libappindicator1.
    Turns out dropbox uses it when it detects an appindicator-based environment.
    Thanks to Mattia Rizzolo <email address hidden> (LP: #1242413)

 -- Chow Loong Jin <email address hidden> Thu, 07 Nov 2013 12:10:09 +0800

[Julian Taylor (jtaylor)]

I have uploaded the sru to saucy-proposed, please test it when it has been accepted by the release team
note I changed the version to 1.4.0-3ubuntu0.13.10.1 as per https://wiki.ubuntu.com/SecurityTeam/UpdatePreparation#Update_the_packaging

[Stéphane Graber (stgraber)]

Hello Gilles, or anyone else affected,

Accepted nautilus-dropbox into saucy-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/nautilus-dropbox/1.4.0-3ubuntu0.13.10.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

[Gilles Gravier (gillesgravier)]

Hi!

Yes, enabling the -proposed repository and triggering an update automatically (with the update of nautilus-dropbox) triggers the installation of libappindicator1 and its dependency libindicator7.

So all good for me!

Thanks,
Gilles.

[Launchpad Janitor (janitor)]

This bug was fixed in the package nautilus-dropbox - 1.4.0-3ubuntu0.13.10.1

---------------
nautilus-dropbox (1.4.0-3ubuntu0.13.10.1) saucy-proposed; urgency=low

  * debian/control: Add a recommend on libappindicator1 in order to
    visualize the notification icon. (LP: #1242413)
 -- Mattia Rizzolo <email address hidden> Tue, 05 Nov 2013 14:26:12 +0100

[Chris Halse Rogers (raof)]

The verification of the Stable Release Update for nautilus-dropbox has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regresssions.

[Realramnit (realramnit)]

This bug also affects Ubuntu 14.04. as you can see thanks to the coverage in various blogs: http://itsfoss.com/solve-dropbox-icon-ubuntu-1310/

What is the best way of dealing with this? New Bug report?