| 2010-08-19 13:28:29 |
Folke Lemaitre |
bug |
|
|
added bug |
| 2010-08-19 15:37:51 |
Clint Byrum |
bug |
|
|
added subscriber Clint Byrum |
| 2010-08-19 16:46:41 |
Scott Moser |
mysql-dfsg-5.1 (Ubuntu): importance |
Undecided |
High |
|
| 2010-08-19 16:46:41 |
Scott Moser |
mysql-dfsg-5.1 (Ubuntu): status |
New |
Triaged |
|
| 2010-08-23 18:12:28 |
Clint Byrum |
bug task added |
|
upstart |
|
| 2010-08-26 12:12:44 |
Thierry Carrez |
mysql-dfsg-5.1 (Ubuntu): assignee |
|
Clint Byrum (clint-fewbar) |
|
| 2010-08-26 12:12:56 |
Thierry Carrez |
nominated for series |
|
Ubuntu Maverick |
|
| 2010-08-26 12:12:56 |
Thierry Carrez |
bug task added |
|
mysql-dfsg-5.1 (Ubuntu Maverick) |
|
| 2010-08-26 12:41:35 |
Thierry Carrez |
bug |
|
|
added subscriber Thierry Carrez |
| 2010-08-26 18:48:06 |
papukaija |
bug |
|
|
added subscriber papukaija |
| 2010-08-26 18:48:33 |
papukaija |
tags |
upstart |
lucid upstart |
|
| 2010-09-02 09:48:10 |
Thierry Carrez |
tags |
lucid upstart |
lucid server-mrs upstart |
|
| 2010-09-02 12:32:36 |
Scott James Remnant (Canonical) |
upstart: status |
New |
Invalid |
|
| 2010-09-08 16:39:23 |
Launchpad Janitor |
branch linked |
|
lp:~clint-fewbar/ubuntu/maverick/mysql-5.1/increase-killtimeout |
|
| 2010-09-08 17:14:13 |
Clint Byrum |
mysql-dfsg-5.1 (Ubuntu Maverick): status |
Triaged |
Confirmed |
|
| 2010-09-08 17:14:17 |
Clint Byrum |
mysql-dfsg-5.1 (Ubuntu Maverick): assignee |
Clint Byrum (clint-fewbar) |
|
|
| 2010-09-15 05:19:48 |
Clint Byrum |
tags |
lucid server-mrs upstart |
lucid patch server-mrs upstart |
|
| 2010-09-15 05:22:17 |
Clint Byrum |
nominated for series |
|
Ubuntu Lucid |
|
| 2010-09-15 19:33:45 |
Mathias Gug |
mysql-dfsg-5.1 (Ubuntu Maverick): assignee |
|
Clint Byrum (clint-fewbar) |
|
| 2010-09-15 19:33:49 |
Mathias Gug |
mysql-dfsg-5.1 (Ubuntu Maverick): status |
Confirmed |
In Progress |
|
| 2010-09-15 22:01:52 |
Mathias Gug |
mysql-dfsg-5.1 (Ubuntu Maverick): status |
In Progress |
Fix Released |
|
| 2010-09-15 22:03:53 |
Mathias Gug |
bug task added |
|
mysql-dfsg-5.1 (Ubuntu Lucid) |
|
| 2010-09-15 22:04:19 |
Mathias Gug |
mysql-dfsg-5.1 (Ubuntu Lucid): importance |
Undecided |
High |
|
| 2010-09-15 22:04:27 |
Mathias Gug |
mysql-dfsg-5.1 (Ubuntu Lucid): status |
New |
Incomplete |
|
| 2010-09-15 22:04:30 |
Mathias Gug |
mysql-dfsg-5.1 (Ubuntu Lucid): status |
Incomplete |
Confirmed |
|
| 2010-09-15 22:04:37 |
Mathias Gug |
mysql-dfsg-5.1 (Ubuntu Lucid): status |
Confirmed |
Triaged |
|
| 2010-09-19 23:05:46 |
Launchpad Janitor |
branch linked |
|
lp:ubuntu/mysql-5.1 |
|
| 2010-11-20 20:27:26 |
Launchpad Janitor |
branch linked |
|
lp:~clint-fewbar/ubuntu/lucid/mysql-dfsg-5.1/increase-killtimeout |
|
| 2010-11-20 20:38:40 |
Clint Byrum |
description |
Release: Ubuntu 10.04 LTS
Package Version: 5.1.41-3ubuntu12.6
Stopping a MySQL server can take some time, especially on a busy database. If mysqld gets killed while having open connections, then after the next start you will likely have a lot of tables corrupted.
The new upstart mechanism for starting/stopping mysql unfortunately behaves as follows on a "service mysql stop":
1. First it will send a TERM signal to mysqld which is perfectly fine as mysqld will do the same as if you would issue a mysqladmin shutdown command
2. If after 5 seconds the process is still not terminated, a KILL signal will be send. This is really a very big issue since on busy servers lots of myisam tables will be corrupted afterwards
Expected behaviour:
Send the term signal and wait for a certain amount of time (at least 1 minute). If still not stopped, then simply give an error about this to the user |
Release: Ubuntu 10.04 LTS
Package Version: 5.1.41-3ubuntu12.6
Stopping a MySQL server can take some time, especially on a busy database. If mysqld gets killed while having open connections, then after the next start you will likely have a lot of tables corrupted.
The new upstart mechanism for starting/stopping mysql unfortunately behaves as follows on a "service mysql stop":
1. First it will send a TERM signal to mysqld which is perfectly fine as mysqld will do the same as if you would issue a mysqladmin shutdown command
2. If after 5 seconds the process is still not terminated, a KILL signal will be send. This is really a very big issue since on busy servers lots of myisam tables will be corrupted afterwards
Expected behaviour:
Send the term signal and wait for a certain amount of time (at least 1 minute). If still not stopped, then simply give an error about this to the user
== SRU REPORT ==
=== IMPACT ===
This has very little impact on a normal running system. It may cause shutdown to take up to 5 minutes, but that is an acceptable trade off as recovering a system with crashed tables can take much, much longer.
=== DEV FIX ===
Raising kill timeout to 300 seconds seems a good trade off between shutdown potentially taking forever, and trying not to corrupt tables.
=== PATCH ===
See merge proposal
=== TEST CASE: ===
This is a race condition, so it is hard to reproduce reliably. However, if you:
1. create a very large innodb table
2. import a lot of data (inserting more MB of data than your drives can write in 5 seconds should work)
3. run a very long select on the data in one thread (SELECT * FROM table WHERE column like '%X%';)
4. DELETE that data in another thread
5. issue 'stop mysql' immediately after the delete returns.
6. check to see that mysqld was sent SIGKILL in /var/log/daemon.log
7. start mysql -- at this point InnoDB recovery will need to be run
Once the fix is applied, the SIGKILL should never be sent.
=== REGRESSION POTENTIAL ===
The only regression potential is mentioned in the IMPACT section, that the shutdown of a server or the mysql service may take up to 5 minutes. |
|
| 2010-11-20 22:30:17 |
papukaija |
removed subscriber papukaija |
|
|
|
| 2010-11-20 22:30:23 |
papukaija |
bug |
|
|
added subscriber papukaija |
| 2010-11-21 07:54:06 |
Clint Byrum |
bug |
|
|
added subscriber Ubuntu Stable Release Updates Team |
| 2010-12-01 19:50:58 |
Bryce Harrington |
mysql-dfsg-5.1 (Ubuntu Lucid): status |
Triaged |
Fix Committed |
|
| 2010-12-01 19:50:58 |
Bryce Harrington |
mysql-dfsg-5.1 (Ubuntu Lucid): assignee |
|
Clint Byrum (clint-fewbar) |
|
| 2010-12-03 15:50:29 |
Martin Pitt |
bug |
|
|
added subscriber SRU Verification |
| 2010-12-03 15:50:33 |
Martin Pitt |
tags |
lucid patch server-mrs upstart |
lucid patch server-mrs upstart verification-needed |
|
| 2010-12-03 16:22:37 |
Launchpad Janitor |
branch linked |
|
lp:ubuntu/lucid-proposed/mysql-dfsg-5.1 |
|
| 2010-12-05 21:29:24 |
Imre Gergely |
bug |
|
|
added subscriber Imre Gergely |
| 2010-12-06 15:12:23 |
Martin Pitt |
tags |
lucid patch server-mrs upstart verification-needed |
lucid patch server-mrs upstart verification-done |
|
| 2010-12-09 10:51:52 |
Launchpad Janitor |
mysql-dfsg-5.1 (Ubuntu Lucid): status |
Fix Committed |
Fix Released |
|
| 2010-12-16 16:06:25 |
Robert Citek |
bug |
|
|
added subscriber Robert Citek |
| 2011-09-19 21:26:44 |
Ubuntu Foundations Team Bug Bot |
tags |
lucid patch server-mrs upstart verification-done |
lucid patch server-mrs testcase upstart verification-done |
|
