Revision doesn't match upstream v2.0.2

[Peter Jonas]

This bug applies to musescore (2.0.2+dfsg-1) [universe] in the Wily repo.

Go to Help -> About. The following is displayed in the dialog:

Version: 2.0.2
Revision: 3543170

But the revision should be: f51dc11

The revision number should correspond to the first 7 digits of git commit code corresponding to the v2.0.2 tagged release:
https://github.com/musescore/MuseScore/tree/2.0.2

The revision number is specified in the code in the file mscore/revision.h. Simply change the number in this file to fix the bug.

Note to maintainer - updating the revision number automatically:
There is a Makefile target called "revision" (i.e. "make revision") that sets the revision number. Adding the appropriate command to debian/rules would set revision automatically. However, note the following:
- "make revision" only works in a git repository
- If using a downstream git repo you MUST use "make revision" BEFORE committing to a downstream repository. (i.e. "revision" should match the upstream git revision, not the downstream git revision).

I help maintain the MuseScore PPA on Launchpad (https://launchpad.net/~mscore-ubuntu) and regularly contribute to the upstream code.

[James Cowgill (jcowgill)]

Hi,

This is fixed in the Debian repository here (for 2.0.3):
http://anonscm.debian.org/cgit/pkg-multimedia/musescore.git

It'll be uploaded to Debian and should get into yakkety at some point.

Having said that I'm not really a fan of having upstream do this because it seems very fragile and requires manual steps which distributors must follow. It seems almost inevitable that someone will forget to do this again for a future release.

James

[James Cowgill (jcowgill)]

Wait I just realized you were the person who actually fixed it! Thanks. What you've added was probably the best solution even if I still don't like what upstream has done with this.

[Peter Jonas (shoogle)]

Thanks,

Actually, I fixed it ;)

Tracking bugs by revision number works very well for upstream, and if that interferes with Debian packaging then they would see that as Debian's problem. In any case, I was given commit access to the Debian repository recently, and made the fix in such a way that the revision will be set automatically each time new upstream code gets imported via uscan, so there is no chance of somebody forgetting to do it.

Unfortunately I haven't been given access to the Debian archive so I can't upload the package into Debian, but hopefully the actual maintainer will get around to doing it soon.

Peter

[Peter Jonas (shoogle)]

Looks like our posts crossed!

[Launchpad Janitor (janitor)]

This bug was fixed in the package musescore - 2.0.3+dfsg1-2

---------------
musescore (2.0.3+dfsg1-2) unstable; urgency=medium

  * Team upload.
  * Only install /usr/share/mscore symlink when building arch:all packages.

 -- James Cowgill <email address hidden> Sun, 17 Jul 2016 16:19:05 +0100