Update munin to bugfix release 1.4.6

[Daniel Hahler]

1.4.6 is a bugfix release, containing a lot of fixes.

It has been updated in Debian and should get into Ubuntu for Oneiric.

Upstream changelog: http://munin-monitoring.org/browser/tags/1.4.6/ChangeLog

[Scott Kitterman (kitterman)]

Bugfix only, so no FFe needed.

[Martin Pitt (pitti)]

Unsubscribing release team; bug fixes don't violate freezes.

[Daniel Hahler (blueyed)]

Subscribing ubuntu-sponsors (for main).

[Jamie Strandboge (jdstrand)]

Thanks Daniel for the debdiff. I am going to NAK this version because the changelog did not capture all of the changes in the bug:
* debian/munin-node.dirs is updated for upstart
* upstream_bug_832.patch is added
* upstream_add-timeout-to-legal-options.patch is added

Also the following Ubuntu only patches do not follow DEP-3, so they are difficult to verify:
* upstream_add-timeout-to-legal-options.patch
* lp_840449_sensors_fan_minimum_is_optional.patch
* upstream_bug_884_fixed_in_trunk.patch
* upstream_bug_937_fixed_in_trunk.patch
* lp_800845_postfix_mailvolume_missing_logfile.patch

Please update the changelog and add DEP-3 comments. It would also be good to forward these patches to Debian (using 'submittodebian') so we can avoid merging these in the future. Once this is done, please feel free to resubscribe ubuntu-sponsors. Thanks!

[Ubuntu Foundations Team Bug Bot (crichton)]

The attachment "Debdiff against Debian" of this bug report has been identified as being a patch in the form of a debdiff. The ubuntu-sponsors team has been subscribed to the bug report so that they can review and hopefully sponsor the debdiff. In the event that this is in fact not a patch you can resolve this situation by removing the tag 'patch' from the bug report and editing the attachment so that it is not flagged as a patch. Additionally, if you are member of the ubuntu-sponsors please also unsubscribe the team from this bug report.

[This is an automated message performed by a Launchpad user owned by Brian Murray. Please contact him regarding any issues with the action taken in this bug report.]

[Daniel Hahler (blueyed)]

This should address all the issues pointed out by Jamie (Thanks!).

[James Page (james-page)]

Hi Daniel

Thanks for taking the time to prepare a revised debdiff for this upgrade.

Looking at the debdiff and reviewing Jamie previous comments I have the following feedback:

1) debian/munin-node.postinst is modified in the debdiff but not mentioned in the merge changelog entry; I assume that this is something todo with the upstart conversion but this should be documented for future merges.

2) debian/changelog - some of the changelog comments for Fixes have got muddled with the Merge comment - makes it a little difficult to read; please could you also annotate the entry for upstream_bug_832.patch including the LP bug report?

Great job on tagging the patches - I reviewed and they all appear to make sense to me. Ditto Jamie's comment re submission back to Debian if they have not been submitted already.

Cheers

James

[Daniel Hahler (blueyed)]

I don't understand what you mean with the beginning of comment 2:
  > 2) debian/changelog - some of the changelog comments for Fixes have got muddled with the Merge comment - makes it a little difficult to read

Also, this is the entry for upstream_bug_832.patch, which is annotated already:
     - debian/patches/upstream_bug_832.patch (backported upstream fix):
       Fix "munin-cgi-graph fails on multigraphs" (LP: #729719)

I do not want to forward anything to Debian before it has been uploaded to Ubuntu.

I'm attaching a new debdiff fixing the first issue.

Please feel free to change minor things like this in debian/changelog or any patch headers when sponsoring the upload.

[Daniel Hahler (blueyed)]

Actually, I am not attaching it again (which would need a new full review).
Please just add the file "debian/munin.postinst" to the list of the third "Remaining changes" list for "Convert to upstart" in debian/changelog to fix issue 1).

[Marc Deslauriers (mdeslaur)]

1.4.6 is now in Precise. I'm closing this bug.

[Daniel Hahler (blueyed)]

I've opened bug 879853 to request upload / merging of this debdiff instead.