plugin postfix_mailvolume invalid output when log file missing

Bug #800845 reported by Breena Kermott on 2011-06-22
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
munin
Fix Released
Unknown
munin (Ubuntu)
Low
Unassigned

Bug Description

Package: munin-node
Version: 1.4.5-1ubuntu2 (and earlier)

Given:

Host has no /var/log/syslog file

Error output:

 [WARNING] munin_set_var_loc: Setting unknown option 'value' at <removed for security>;<removed for security>;postfix_mailvolume;delivered:

Issue:

Default log file does not exist and no override logfile set results in invalid output (wrong name label)

Default log file:
my $LOGDIR = $ENV{'logdir'} || '/var/log';
my $LOGFILE = $ENV{'logfile'} || 'syslog';

Graph config callout:

if ( $ARGV[0] and $ARGV[0] eq "config" ) {
    print "graph_title Postfix bytes throughput\n";
    print "graph_args --base 1000 -l 0\n";
    print "graph_vlabel bytes / \${graph_period}\n";
    print "graph_scale yes\n";
    print "graph_category postfix\n";
    print "volume.label throughput\n";
    print "volume.type DERIVE\n";
    print "volume.min 0\n";
    exit 0;
}

Output on log file missing:

if (! -f $logfile) {
    print "delivered.value U\n";
    exit 1;
}

Fix:

s/delivered.value/volume.value/

Diff: (file: /usr/share/munin/plugins/postfix_mailvolume)

if (! -f $logfile) {
- print "delivered.value U\n";
+ print "volume.value U\n";
    exit 1;
}

ProblemType: Bug
DistroRelease: Ubuntu 10.10
Package: munin-node 1.4.5-1ubuntu2
ProcVersionSignature: Ubuntu 2.6.35-24.42-generic 2.6.35.8
Uname: Linux 2.6.35-24-generic x86_64
Architecture: amd64
Date: Wed Jun 22 11:57:00 2011
InstallationMedia: Ubuntu 10.10 "Maverick Meerkat" - Release amd64 (20101007)
PackageArchitecture: all
ProcEnviron:
 LANG=en_US.utf8
 SHELL=/bin/bash
SourcePackage: munin

Related branches

Breena Kermott (b-kermott) wrote :
Dave Walker (davewalker) on 2011-07-15
Changed in munin (Ubuntu):
importance: Undecided → Low
status: New → Triaged
Daniel Hahler (blueyed) on 2011-09-03
Changed in munin (Ubuntu):
status: Triaged → In Progress
Changed in munin:
status: Unknown → New
Changed in munin:
status: New → Fix Released
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package munin - 1.4.6-2ubuntu2

---------------
munin (1.4.6-2ubuntu2) precise; urgency=low

  * Fix sensors_fan for sensors output without minimum values
    (LP: #840449).
    - debian/patches/lp_840449_sensors_fan_minimum_is_optional.patch
  * Fix "mysql_ plugin fails when MySQL compiled without INNODB"
    (LP: #757617)
    - debian/patches/upstream_bug_884_fixed_in_trunk.patch
  * Fix munin_stats plugin: missing newline in "config"
    (LP: #830564).
    - debian/patches/upstream_bug_937_fixed_in_trunk.patch
  * Fix postfix_mailvolume when logfile is missing
    (LP: #800845).
 -- Chuck Short <email address hidden> Fri, 06 Jan 2012 08:54:54 -0500

Changed in munin (Ubuntu):
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.