[SRU] irqstats is confused by 2.6.24 /proc/interrupts

[Christian Kujau]

Binary package hint: munin

This is basically just copying http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=463721

The "irqstats" plugin cannot handle the new /proc/interrupts format and emits warnings on every run:

> Argument "shootdowns" isn't numeric in addition (+) at /etc/munin/plugins/irqstats line 62, <$in> line 18.

Since Hardy (LTS!) ships with linux-image-2.6.24, this (cosmetic) bug could be worth fixing.
Upstream fixed this with a one-liner: http://munin.projects.linpro.no/ticket/598

Thanks,
Christian.

# lsb_release -rd
Description: Ubuntu 8.04.2
Release: 8.04
# apt-cache policy munin-node
munin-node:
  Installed: 1.2.5-2ubuntu3.1
  Candidate: 1.2.5-2ubuntu3.1
  Version table:
 *** 1.2.5-2ubuntu3.1 0
        500 http://de.archive.ubuntu.com hardy-updates/main Packages
        100 /var/lib/dpkg/status
     1.2.5-2ubuntu3 0
        500 http://de.archive.ubuntu.com hardy/main Packages

[Chuck Short (zulcss)]

Hi,

Can you test the version in my ppa (http://launchpad.net/~zulcss/+archive/ppa)?

Thanks
chuck

[Christian Kujau (christiank)]

On Tue, 30 Jun 2009, Chuck Short wrote:
> Can you test the version in my ppa
> (http://launchpad.net/~zulcss/+archive/ppa)?

Yup, I've installed your version (for 8.04) and it does contain the
correct plugin now, thanks!

Btw, the changelog of your version only mentions the irqstats fix, will
the munin-node.postinst change be in the final version too?

Thanks again,
Christian.

[Chuck Short (zulcss)]

Great!

Thanks for testing please open up another bug that you mentioned.

Regards
chuck

[Chuck Short (zulcss)]

The 2.6.24 changed the format of the of /proc/interrupts. This has caused the irqstats plugin for munin to fail with the above error message. This has been fixed in later releases. I have attached the patch that fixes this issue.

TEST CASE:
  1. Install munin for hardy.
  2. Enable the irqstats plugin.
  3. Check to see if you get the following message:

> Argument "shootdowns" isn't numeric in addition (+) at /etc/munin/plugins/irqstats line 62, <$in> line 18.

There should be little impact to munin by adding this patch.

If you have any questions please let me know.

Regards
chuck

[Daniel Hahler (blueyed)]

The patch is still not applied - is this still an issue?

[Christian Kujau (christiank)]

The bug has been fixed for 8.04, although the changelog is missing the LP#:

munin (1.2.5-2ubuntu3.2) hardy; urgency=low
  * Added patch to fix irqstats using the 2.6.24 kernel.
 -- Chuck Short <email address hidden> Tue, 30 Jun 2009 10:34:39 -0400

And /usr/share/munin/plugins/irqstats is indeed working correctly with 2.6.24 now.

[Christian Kujau (christiank)]

Whoops, too soon: when I looked at the changelog, I forgot that this is still Chuck's version of munin-node[0] that is installed on my system. So no, the bug is still present in hardy/8.04 and it would be most helpful if someone was able to upload Chuck's version[1] to the official archives. Later Ubuntu versions seem to be fine, as the bug has been fixed upstream.

[0] http://launchpad.net/~zulcss/+archive/ppa
[1] https://launchpad.net/~zulcss/+archive/ppa/+files/munin-node_1.2.5-2ubuntu3.2_all.deb

[John Dong (jdong)]

Is this waiting for a SRU ACK? If the patch is the one from comment #1, it looks reasonable for Hardy, pleace proceed.

[Daniel Hahler (blueyed)]

Yes, that's the patch.
Comment #6 has the debdiff (http://launchpadlibrarian.net/29931439/munin.patch).

So, Chuck, please upload your fix.

[Rolf Leggewie (r0lf)]

Hardy has seen the end of its life and is no longer receiving any updates. Marking the Hardy task for this ticket as "Won't Fix".