2011-02-04 17:23:55 |
dann frazier |
bug |
|
|
added bug |
2011-02-04 17:28:32 |
Launchpad Janitor |
branch linked |
|
lp:~dannf/ubuntu/natty/multipath-tools/free_waiter-race |
|
2011-02-09 21:28:50 |
Serge Hallyn |
multipath-tools (Ubuntu): status |
New |
Confirmed |
|
2011-02-09 21:30:16 |
Serge Hallyn |
multipath-tools (Ubuntu): assignee |
|
Serge Hallyn (serge-hallyn) |
|
2011-02-09 21:30:23 |
Serge Hallyn |
multipath-tools (Ubuntu): importance |
Undecided |
Low |
|
2011-02-09 21:50:42 |
Serge Hallyn |
branch linked |
|
lp:~serge-hallyn/ubuntu/natty/multipath-tools/free_waiter-race |
|
2011-02-09 21:52:46 |
Serge Hallyn |
multipath-tools (Ubuntu): status |
Confirmed |
In Progress |
|
2011-02-11 17:15:11 |
Launchpad Janitor |
multipath-tools (Ubuntu): status |
In Progress |
Fix Released |
|
2011-06-03 21:23:12 |
Serge Hallyn |
description |
Binary package hint: multipath-tools
I received a coredump from a customer (running a lucid-based system).
Analyzing the core from multipathd shows that we are crashing in waiter.c::free_waiter().
void free_waiter (void *data)
{
struct event_thread *wp = (struct event_thread *)data;
/*
* indicate in mpp that the wp is already freed storage
*/
lock(wp->vecs->lock);
if (wp->mpp)
/*
* be careful, mpp may already be freed -- null if so
*/
wp->mpp->waiter = NULL;
else
condlog(3, "free_waiter, mpp freed before wp=%p,", wp);
unlock(wp->vecs->lock); <<< Crashing here
if (wp->dmt)
dm_task_destroy(wp->dmt);
FREE(wp);
}
The lock is NULL:
(gdb) print wp->vecs->lock
$3 = (pthread_mutex_t *) 0x0
This appears to be the upstream issue fixed here:
http://git.kernel.org/gitweb.cgi?p=linux/storage/multipath-tools/.git;a=commitdiff;h=a403f57b991f3be7c7ea6250d95fad1554c9d6ca
This fix is currently missing from all versions of multipath-tools in lucid->natty.
(The original customer issue was filed in the private bug #712875.) |
Binary package hint: multipath-tools
==========================================
SRU Justification:
1. Impact: segv on multipathd shutdown
2. How bug was addressed: a patch was cherrypicked from upstream which fixes this
3. Minimal patch: see patch in attached bzr tree
4. TEST CASE: stop multipathd.
5. Regression potential: none, this patch was taken from upstream.
==========================================
I received a coredump from a customer (running a lucid-based system).
Analyzing the core from multipathd shows that we are crashing in waiter.c::free_waiter().
void free_waiter (void *data)
{
struct event_thread *wp = (struct event_thread *)data;
/*
* indicate in mpp that the wp is already freed storage
*/
lock(wp->vecs->lock);
if (wp->mpp)
/*
* be careful, mpp may already be freed -- null if so
*/
wp->mpp->waiter = NULL;
else
condlog(3, "free_waiter, mpp freed before wp=%p,", wp);
unlock(wp->vecs->lock); <<< Crashing here
if (wp->dmt)
dm_task_destroy(wp->dmt);
FREE(wp);
}
The lock is NULL:
(gdb) print wp->vecs->lock
$3 = (pthread_mutex_t *) 0x0
This appears to be the upstream issue fixed here:
http://git.kernel.org/gitweb.cgi?p=linux/storage/multipath-tools/.git;a=commitdiff;h=a403f57b991f3be7c7ea6250d95fad1554c9d6ca
This fix is currently missing from all versions of multipath-tools in lucid->natty.
(The original customer issue was filed in the private bug #712875.) |
|
2011-06-03 21:23:23 |
Serge Hallyn |
bug |
|
|
added subscriber Ubuntu Stable Release Updates Team |
2011-06-03 21:23:58 |
Serge Hallyn |
nominated for series |
|
Ubuntu Lucid |
|
2011-06-03 21:23:58 |
Serge Hallyn |
bug task added |
|
multipath-tools (Ubuntu Lucid) |
|
2011-06-03 21:23:58 |
Serge Hallyn |
nominated for series |
|
Ubuntu Maverick |
|
2011-06-03 21:23:58 |
Serge Hallyn |
bug task added |
|
multipath-tools (Ubuntu Maverick) |
|
2011-06-06 20:12:48 |
Clint Byrum |
multipath-tools (Ubuntu Lucid): status |
New |
Fix Committed |
|
2011-06-06 20:12:52 |
Clint Byrum |
bug |
|
|
added subscriber SRU Verification |
2011-06-06 20:12:53 |
Clint Byrum |
tags |
|
verification-needed |
|
2011-06-07 03:28:18 |
Clint Byrum |
multipath-tools (Ubuntu Lucid): importance |
Undecided |
Low |
|
2011-06-07 03:28:18 |
Clint Byrum |
multipath-tools (Ubuntu Lucid): status |
Fix Committed |
Triaged |
|
2011-06-07 03:28:29 |
Clint Byrum |
tags |
verification-needed |
|
|
2011-09-19 21:44:17 |
Ubuntu Foundations Team Bug Bot |
tags |
|
testcase |
|
2014-11-21 18:29:38 |
Rolf Leggewie |
multipath-tools (Ubuntu Maverick): status |
New |
Won't Fix |
|
2015-06-17 11:40:51 |
Rolf Leggewie |
multipath-tools (Ubuntu Lucid): status |
Triaged |
Won't Fix |
|