| 2023-10-31 22:12:49 |
Mauricio Faria de Oliveira |
bug |
|
|
added bug |
| 2023-10-31 22:13:23 |
Mauricio Faria de Oliveira |
nominated for series |
|
Ubuntu Mantic |
|
| 2023-10-31 22:13:23 |
Mauricio Faria de Oliveira |
bug task added |
|
multipath-tools (Ubuntu Mantic) |
|
| 2023-10-31 22:13:23 |
Mauricio Faria de Oliveira |
nominated for series |
|
Ubuntu Noble |
|
| 2023-10-31 22:13:23 |
Mauricio Faria de Oliveira |
bug task added |
|
multipath-tools (Ubuntu Noble) |
|
| 2023-10-31 22:13:23 |
Mauricio Faria de Oliveira |
nominated for series |
|
Ubuntu Jammy |
|
| 2023-10-31 22:13:23 |
Mauricio Faria de Oliveira |
bug task added |
|
multipath-tools (Ubuntu Jammy) |
|
| 2023-10-31 22:13:23 |
Mauricio Faria de Oliveira |
nominated for series |
|
Ubuntu Lunar |
|
| 2023-10-31 22:13:23 |
Mauricio Faria de Oliveira |
bug task added |
|
multipath-tools (Ubuntu Lunar) |
|
| 2023-10-31 22:13:23 |
Mauricio Faria de Oliveira |
nominated for series |
|
Ubuntu Focal |
|
| 2023-10-31 22:13:23 |
Mauricio Faria de Oliveira |
bug task added |
|
multipath-tools (Ubuntu Focal) |
|
| 2023-10-31 22:13:31 |
Mauricio Faria de Oliveira |
multipath-tools (Ubuntu Noble): status |
New |
Fix Released |
|
| 2023-10-31 22:13:33 |
Mauricio Faria de Oliveira |
multipath-tools (Ubuntu Mantic): status |
New |
Fix Released |
|
| 2023-10-31 22:13:43 |
Mauricio Faria de Oliveira |
multipath-tools (Ubuntu Lunar): status |
New |
In Progress |
|
| 2023-10-31 22:13:47 |
Mauricio Faria de Oliveira |
multipath-tools (Ubuntu Lunar): importance |
Undecided |
Medium |
|
| 2023-10-31 22:13:49 |
Mauricio Faria de Oliveira |
multipath-tools (Ubuntu Lunar): assignee |
|
Mauricio Faria de Oliveira (mfo) |
|
| 2023-10-31 22:13:54 |
Mauricio Faria de Oliveira |
multipath-tools (Ubuntu Jammy): status |
New |
In Progress |
|
| 2023-10-31 22:13:57 |
Mauricio Faria de Oliveira |
multipath-tools (Ubuntu Jammy): importance |
Undecided |
Medium |
|
| 2023-10-31 22:13:59 |
Mauricio Faria de Oliveira |
multipath-tools (Ubuntu Jammy): assignee |
|
Mauricio Faria de Oliveira (mfo) |
|
| 2023-10-31 22:14:03 |
Mauricio Faria de Oliveira |
multipath-tools (Ubuntu Focal): status |
New |
In Progress |
|
| 2023-10-31 22:14:06 |
Mauricio Faria de Oliveira |
multipath-tools (Ubuntu Focal): importance |
Undecided |
Medium |
|
| 2023-10-31 22:14:09 |
Mauricio Faria de Oliveira |
multipath-tools (Ubuntu Focal): assignee |
|
Mauricio Faria de Oliveira (mfo) |
|
| 2023-11-07 19:23:35 |
Mauricio Faria de Oliveira |
description |
[Impact]
* There are corner cases in which multipathd
might segfault if device-mapper parameters
for a multipath map are returned as NULL.
* This is apparently a rare error condition,
but it's been reported and fixed upstream.
* However, older releases need the patch too,
for another SRU, so we take it individually
to perform synthetic tests on the commit.
* commit 7439a41 ("dm_get_map: fix segfault
when can't found target") [1]
[Test Steps]
* Synthetic reproducer available with GDB,
(comments #1 and #2).
* Create a VM with a multipath disk.
* Attach GDB to multipathd.
* Break on the device-mapper function
that returns a map's info/parameters.
* Let it finish that function, and set
parameters to NULL.
* Let multipathd run.
* Expected: multipathd continues to run.
* Actual: multipathd hits a segfault.
[Regression Potential]
* The change is just a NULL pointer check,
which returns early from the function.
* Theoretically, regressions would manifest
in the dm_get_map() function, and likely
show as incomplete information on status
of multipath maps or paths.
* It's not expected to regress to another
segmentation fault, as the function path
is shorter if the condition happens, and
only accesses memory that was initialized
and checked before (the dm_task variable).
* Any regression should be easy to catch,
as dm_get_map() runs periodically on the
path checkers in multipathd (the daemon)
and commands in multipath (the cli tool).
[Other Info]
* The commit [1] is present in Mantic and later.
$ git describe --contains 7439a41
0.9.0^2~8
$ rmadison -a source multipath-tools
...
multipath-tools | 0.8.8-1ubuntu2.2 | lunar-proposed | source
multipath-tools | 0.9.4-5ubuntu3 | mantic | source
multipath-tools | 0.9.4-5ubuntu3 | noble | source
[1] https://github.com/opensvc/multipath-tools/commit/7439a41 |
[Impact]
* There are corner cases in which multipathd
might segfault if device-mapper parameters
for a multipath map are returned as NULL.
* This is apparently a rare error condition,
but it's been reported and fixed upstream.
* However, older releases need the patch too,
for another SRU, so we take it individually
to perform synthetic tests on the commit.
* commit 7439a41 ("dm_get_map: fix segfault
when can't found target") [1]
[Test Steps]
* Synthetic reproducer available with GDB,
(comments #1 and #2).
* Create a VM with a multipath disk.
* Attach GDB to multipathd.
* Break on the device-mapper function
that returns a map's info/parameters.
* Let it finish that function, and set
parameters to NULL.
* Let multipathd run.
* Expected: multipathd continues to run.
* Actual: multipathd hits a segfault.
[Regression Potential]
* The change is just a NULL pointer check,
which returns early from the function
(with the same error code as already used
previously in that function).
* Theoretically, regressions would manifest
in the dm_get_map() function, and likely
show as incomplete information on status
of multipath maps or paths.
* It's not expected to regress to another
segmentation fault, as the function path
is shorter if the condition happens, and
only accesses memory that was initialized
and checked before (the dm_task variable).
* Any regression should be easy to catch,
as dm_get_map() runs periodically on the
path checkers in multipathd (the daemon)
and commands in multipath (the cli tool).
[Other Info]
* The commit [1] is present in Mantic and later.
$ git describe --contains 7439a41
0.9.0^2~8
$ rmadison -a source multipath-tools
...
multipath-tools | 0.8.8-1ubuntu2.2 | lunar-proposed | source
multipath-tools | 0.9.4-5ubuntu3 | mantic | source
multipath-tools | 0.9.4-5ubuntu3 | noble | source
[1] https://github.com/opensvc/multipath-tools/commit/7439a41 |
|
| 2023-11-07 20:55:02 |
Mauricio Faria de Oliveira |
description |
[Impact]
* There are corner cases in which multipathd
might segfault if device-mapper parameters
for a multipath map are returned as NULL.
* This is apparently a rare error condition,
but it's been reported and fixed upstream.
* However, older releases need the patch too,
for another SRU, so we take it individually
to perform synthetic tests on the commit.
* commit 7439a41 ("dm_get_map: fix segfault
when can't found target") [1]
[Test Steps]
* Synthetic reproducer available with GDB,
(comments #1 and #2).
* Create a VM with a multipath disk.
* Attach GDB to multipathd.
* Break on the device-mapper function
that returns a map's info/parameters.
* Let it finish that function, and set
parameters to NULL.
* Let multipathd run.
* Expected: multipathd continues to run.
* Actual: multipathd hits a segfault.
[Regression Potential]
* The change is just a NULL pointer check,
which returns early from the function
(with the same error code as already used
previously in that function).
* Theoretically, regressions would manifest
in the dm_get_map() function, and likely
show as incomplete information on status
of multipath maps or paths.
* It's not expected to regress to another
segmentation fault, as the function path
is shorter if the condition happens, and
only accesses memory that was initialized
and checked before (the dm_task variable).
* Any regression should be easy to catch,
as dm_get_map() runs periodically on the
path checkers in multipathd (the daemon)
and commands in multipath (the cli tool).
[Other Info]
* The commit [1] is present in Mantic and later.
$ git describe --contains 7439a41
0.9.0^2~8
$ rmadison -a source multipath-tools
...
multipath-tools | 0.8.8-1ubuntu2.2 | lunar-proposed | source
multipath-tools | 0.9.4-5ubuntu3 | mantic | source
multipath-tools | 0.9.4-5ubuntu3 | noble | source
[1] https://github.com/opensvc/multipath-tools/commit/7439a41 |
[Impact]
* There are corner cases in which multipathd
might segfault if device-mapper parameters
for a multipath map are returned as NULL.
* This is apparently a rare error condition,
but it's been reported and fixed upstream:
commit 7439a41 ("dm_get_map: fix segfault
when can't found target") [1]
* The SRU in bug 2039719 (Focal) needs this,
so we take it individually as separete SRU
to perform synthetic tests on the commit
and verify correct behavior.
* Focal does not segfault if params are NULL
since it uses `snprintf(..., "%s", params)`,
which handles a string NULL pointer well,
while newer releases use `strdup(params)`,
which does not.
However, Focal should still get the patch
since a multipath map _without parameters_
is _invalid_, and should not be passed on
within multipathd (might lead to issues).
Details: the device-mapper multipath target
_requires_ 4 parameters: features, hardware
handler, path groups, and next path group;
linux/drivers/md/dm-mpath.c:multipath_ctr():
Without parameters:
$ sudo dmsetup create mpath-test --table '0 1048576 multipath'
device-mapper: reload ioctl on mpath-test (253:3) failed: Invalid argument
Command failed.
With 4 parameters:
$ sudo dmsetup create mpath-test --table '0 1048576 multipath 0 0 0 0'
$ sudo dmsetup table --target multipath
mpath-test: 0 1048576 multipath 0 0 0 0
$ sudo dmsetup remove mpath-test
[Test Steps]
* Synthetic reproducer available with GDB,
(comments #1 and #2).
* Create a VM with a multipath disk.
* Attach GDB to multipathd.
* Break on the device-mapper function
that returns a map's info/parameters.
* Let it finish that function, and set
parameters to NULL.
* Let multipathd run.
Jammy/Lunar:
* Expected: multipathd continues to run.
* Actual: multipathd hits a segfault.
Focal:
* Expected: map without parameters returns error.
* Actual: map without parameters returns normally.
[Regression Potential]
* The change is just a NULL pointer check,
which returns early from the function
(with the same error code as already used
previously in that function).
* Theoretically, regressions would manifest
in the dm_get_map() function, and likely
show as incomplete information on status
of multipath maps or paths.
* It's not expected to regress to another
segmentation fault, as the function path
is shorter if the condition happens, and
only accesses memory that was initialized
and checked before (the dm_task variable).
* Any regression should be easy to catch,
as dm_get_map() runs periodically on the
path checkers in multipathd (the daemon)
and commands in multipath (the cli tool).
[Other Info]
* The commit [1] is present in Mantic and later.
$ git describe --contains 7439a41
0.9.0^2~8
$ rmadison -a source multipath-tools
...
multipath-tools | 0.8.8-1ubuntu2.2 | lunar-proposed | source
multipath-tools | 0.9.4-5ubuntu3 | mantic | source
multipath-tools | 0.9.4-5ubuntu3 | noble | source
[1] https://github.com/opensvc/multipath-tools/commit/7439a41 |
|
| 2023-11-15 22:46:35 |
Robie Basak |
multipath-tools (Ubuntu Lunar): status |
In Progress |
Fix Committed |
|
| 2023-11-15 22:46:36 |
Robie Basak |
bug |
|
|
added subscriber Ubuntu Stable Release Updates Team |
| 2023-11-15 22:46:37 |
Robie Basak |
bug |
|
|
added subscriber SRU Verification |
| 2023-11-15 22:46:39 |
Robie Basak |
tags |
|
verification-needed verification-needed-lunar |
|
| 2023-11-15 22:46:47 |
Robie Basak |
multipath-tools (Ubuntu Jammy): status |
In Progress |
Fix Committed |
|
| 2023-11-15 22:46:50 |
Robie Basak |
tags |
verification-needed verification-needed-lunar |
verification-needed verification-needed-jammy verification-needed-lunar |
|
| 2023-11-15 22:47:05 |
Robie Basak |
multipath-tools (Ubuntu Focal): status |
In Progress |
Fix Committed |
|
| 2023-11-15 22:47:07 |
Robie Basak |
tags |
verification-needed verification-needed-jammy verification-needed-lunar |
verification-needed verification-needed-focal verification-needed-jammy verification-needed-lunar |
|
| 2023-12-06 22:36:21 |
Jorge Merlino |
tags |
verification-needed verification-needed-focal verification-needed-jammy verification-needed-lunar |
verification-done-focal verification-needed verification-needed-jammy verification-needed-lunar |
|
| 2023-12-07 15:11:34 |
Jorge Merlino |
tags |
verification-done-focal verification-needed verification-needed-jammy verification-needed-lunar |
verification-done-focal verification-done-lunar verification-needed verification-needed-jammy |
|
| 2023-12-07 16:45:42 |
Jorge Merlino |
tags |
verification-done-focal verification-done-lunar verification-needed verification-needed-jammy |
verification-done-focal verification-done-jammy verification-done-lunar verification-needed |
|
| 2023-12-07 19:47:02 |
Launchpad Janitor |
multipath-tools (Ubuntu Lunar): status |
Fix Committed |
Fix Released |
|
| 2023-12-07 19:47:07 |
Andreas Hasenack |
removed subscriber Ubuntu Stable Release Updates Team |
|
|
|
| 2023-12-07 19:47:22 |
Launchpad Janitor |
multipath-tools (Ubuntu Jammy): status |
Fix Committed |
Fix Released |
|
| 2023-12-07 19:47:37 |
Launchpad Janitor |
multipath-tools (Ubuntu Focal): status |
Fix Committed |
Fix Released |
|
