mtr 0.86 doesn't respect terminal colors

Bug #1581186 reported by Adam Conrad on 2016-05-12
18
This bug affects 3 people
Affects Status Importance Assigned to Milestone
mtr (Debian)
Fix Released
Unknown
mtr (Ubuntu)
Undecided
Adam Conrad
Xenial
Undecided
Adam Conrad

Bug Description

[ SRU Justification ]
mtr 0.86 added more colours to the curses output, but this broke how it blends in with dark terminals with non-standard colours, and light terminals in general.

While this is purely cosmetic, it's pretty ugly compared to mtr 0.85, and the fix is trivial and trivially verified as correct (or, more correct than 0.86) on several different terminal colour schemes. As a man who uses mtr daily, it's been driving me mildly nuts.

[ Solution ]
Two commits upstream fix this, so it's a little more readable again on light terminals, and doesn't mess with non-standard terminals:

63a1f1493bfbaf7e55eb7e20b3791fc8b14cf92d
7571201cf7a3394e0dcd2b037aba1836089cc084

[ Test Case ]
Run old and new mtr on a variety of terminal schemes (default gnome-terminal, inverted gnome-terminal, default and inverted xterm, etc) to see if it's (a) as readable or more than before, (b) now shows sanely default bg colours, (c) works correctly with transparent backgrounds.

The first point is somewhat subjective, though a quick test here shows that on "xterm -rv", the bold text has switched from some barely-readable grey-on-white to something approaching black-on-white, so I think this is moving in a winning direction.

Adam Conrad (adconrad) on 2016-05-12
Changed in mtr (Ubuntu):
status: New → Fix Committed
Changed in mtr (Ubuntu Xenial):
status: New → In Progress
Changed in mtr (Ubuntu):
assignee: nobody → Adam Conrad (adconrad)
Changed in mtr (Ubuntu Xenial):
assignee: nobody → Adam Conrad (adconrad)

Hello Adam, or anyone else affected,

Accepted mtr into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/mtr/0.86-1ubuntu0.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in mtr (Ubuntu Xenial):
status: In Progress → Fix Committed
tags: added: verification-needed
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package mtr - 0.86-1ubuntu1

---------------
mtr (0.86-1ubuntu1) yakkety; urgency=medium

  * Pull commits from upstream to fix terminal colours (LP: #1581186)

 -- Adam Conrad <email address hidden> Thu, 12 May 2016 12:34:22 -0600

Changed in mtr (Ubuntu):
status: Fix Committed → Fix Released
Changed in mtr (Debian):
status: Unknown → New

It seems fixed in 0.86-1ubuntu0.1

tags: added: verification-done
removed: verification-needed
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package mtr - 0.86-1ubuntu0.1

---------------
mtr (0.86-1ubuntu0.1) xenial; urgency=medium

  * Pull commits from upstream to fix terminal colours (LP: #1581186)

 -- Adam Conrad <email address hidden> Thu, 12 May 2016 12:34:22 -0600

Changed in mtr (Ubuntu Xenial):
status: Fix Committed → Fix Released

The verification of the Stable Release Update for mtr has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Changed in mtr (Debian):
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.