several bugs with filename

[balrok]

Binary package hint: mp32ogg

1. if a filename starts with "-" then it doesn't work
2. if the extension is in uppercase it wouldn't notice that this is an mp3-file
(all upercased MP3-files are ignored)
3. why you use: die "Could not determine MP3 version, aborting" if ($fileinfo->{VERSION}=="");
it would be better if you ask if the user wants to proceed or not.. (better:skip/skip all/abort)

i hope you'll do this soon cause i'm not so good in perl^^
thank you =)

[Dan O'Huiginn (daniel-ohuiginn)]

confirmed. I'll have a look at this at some point, since the original author isn't maintaining mp32ogg any more.

[Fede (fedefede0101)]

about the .mP3/.Mp3/.MP3 extension problem (num.2) even if I'm not good with perl...here is a small fix :)

hope it will help someone...

bye

[Michael D. Stemle, Jr. (manchicken)]

Here's something that should help with the VERSION dying. This script is a mess but this patch should do the trick.

This solution is just going to return with nothing from the ConvertFile() function when this exception case comes up. It'll give the user the option to skip or abort (with abort being the default option) and it'll only die if the user chooses to abort.

[Rich Johnson (nixternal)]

I know the case patch works, but could you all please test the patch for dying that Michael attached and let me know if it works and I will upload ASAP. Thanks!

[Fede (fedefede0101)]

Micheal's patch works nice.

here is the test for both Skip and Abort...

fede@SC-BUNTU:~/Desktop$ mp32ogg --delete --quality=6 --verbose tmp/
mp32ogg v0.11
(c) 2000-2002 Nathan Walp
Released without warranty under the terms of the Artistic License

Could not determine MP3 version: (S)kip or (A)bort? [A]:S
Converting author - song.mp3 to OGG...
Length: 04:15 Freq: 44.1 kHz
MP3 Bitrate: 192 OGG Quality Level: 6
 Artist: author
  Album: album
  Title: song
   Year: 2005
  Genre:
Track #: 11
Comment:
author - song.ogg done!
fede@SC-BUNTU:~/Desktop$ mp32ogg --delete --quality=6 --verbose tmp/
mp32ogg v0.11
(c) 2000-2002 Nathan Walp
Released without warranty under the terms of the Artistic License

Could not determine MP3 version: (S)kip or (A)bort? [A]:A
Aborting. at /usr/bin/mp32ogg line 142, <STDIN> line 1.

thanks for the fix!!

@michael
is it possible to modify the patch in order to skip ALL the files by default without typing S or A and at the and of the conversion print out all the skipped files?? with many files to be converted I think it would be a better solution...

thanks again..

[Fede (fedefede0101)]

by reading the ubuntu wiki and some tutorials I'm trying to learn "the art of debian packaging" :)

could someone take a look at my .debdiff and explain to me the mistakes I've made, if there are?

it would be usefull to learn more and improve my knowledge!!

thanks :)

[Rich Johnson (nixternal)]

Quick comments about your debdiff (which honestly should be off list but oh well):

1) No need to clean up rules especially this late in the game
2) You can't be maintainer of a universe package, Ubuntu MOTU Developers or if you had an @ubuntu.com email address then you could
3) Why did you pick dpatch? (nothing wrong with that, just want to know your answer)
4) Why did you name the patches the way you did? (nothing wrong, just want to know your answer)
5) changelog file could use a little more info, when you say 'Cleaned up rules', what did you clean up, gotta be specific just in case of future merges from Debian, the next person to work on the package knows what to keep and what to throw out.

Otherwise, I think you are well on your way :)

If you would like the added functionality for mp32ogg, file a new bug on that and we can set it to wishlist and let Michael work on it for Intrepid, since new functionality isn't going to get in right now that easy.

[Fede (fedefede0101)]

Thanks for your time Richard ;)

1) About the clean up, I've removed everything that wasn't necessary for the packaging, and I think that a cleaned rules file is the best way to be sure that in the future anyone can work on the package without problems.
2) Asdasd, sorry about that...actually I haven't understand yet very well the maintainer policy :(
3) I use dpatch because it looks to me the easiest and better way...
4) I've named the patches in that way, to be informative about what the patches do also with the filename...

Thanks again for your tips and suggestions!! :)

[Michael D. Stemle, Jr. (manchicken)]

Here's a patch that has a skip all ability. Feel free to tweak the options if you'd like, I couldn't think of good options.

[Rich Johnson (nixternal)]

Is this still an issue? Seems this report has become stale. I do use mp32ogg religiously now, but I don't think I do any of the advanced things you all were doing that caused the issue. Thanks!

[Launchpad Janitor (janitor)]

[Expired for mp32ogg (Ubuntu) because there has been no activity for 60 days.]