| 2017-04-13 20:34:55 |
Brian Vincent |
bug |
|
|
added bug |
| 2017-04-14 12:03:52 |
Launchpad Janitor |
mozjs38 (Ubuntu): status |
New |
Confirmed |
|
| 2017-04-14 21:27:23 |
Brian Murray |
bug |
|
|
added subscriber Jeremy Bicha |
| 2017-04-14 21:29:19 |
Brian Murray |
mozjs38 (Ubuntu): status |
Confirmed |
Triaged |
|
| 2017-04-14 21:29:23 |
Brian Murray |
mozjs38 (Ubuntu): importance |
Undecided |
High |
|
| 2017-04-14 21:29:33 |
Brian Murray |
tags |
|
zesty |
|
| 2017-04-14 21:32:51 |
Brian Murray |
bug |
|
|
added subscriber Brian Murray |
| 2017-04-15 00:33:58 |
Jeremy Bícha |
bug watch added |
|
https://bugzilla.mozilla.org/show_bug.cgi?id=1245783 |
|
| 2017-04-15 17:40:50 |
Jeremy Bícha |
description |
A friend and I are seeing frequent gnome-shell crashes on Ubuntu 17.04 on 3 different computers. Here's an example:
Apr 12 22:35:00 ******** kernel: gnome-shell[2592]: segfault at 10 ip 00007f0e3ccc26d7 sp 00007ffdd31b4d90 error 4 in libmozjs-38.so.0.0.0[7f0e3c93e000+6c7000]
I've analyzed the issue for a while and I actually believe I've found the solution.
If I simply download the apt source package and build it using gcc 6.3.0, and then go to js/src and execute:
$ make check-jstests | grep -c UNEXPECTED-FAIL
49
Upon examination, those test failures are all because of segfaults.
If I rebuild and retests with gcc 5, all tests pass.
I've discovered that adding the flag -fno-strict-aliasing causes all of the tests to pass with gcc 6. |
Impact
------
This enables build tests to run and pass. This was done by building without -fstrict-aliasing and skipping 3 ICU tests. (Those 3 tests don't work right with the system ICU that Ubuntu 17.04 is using to build mozjs38.)
Test Case
---------
1. Since the tests will now fail the build if they fail, make sure that mozjs38 builds on all architectures
2. Install the new version and make sure GNOME Shell seems to still work.
Regression Potential
--------------------
I don't know much about strict-aliasing, but I believe it's safer to disable it on a large old codebase like this. Since it makes the build tests pass now, it seems like disabling strict-aliasing may fix some bugs.
Other Info
----------
mozjs is the SpiderMonkey JavaScript engine from Firefox. This version is from Firefox 38.
Original Bug Description
------------------------
A friend and I are seeing frequent gnome-shell crashes on Ubuntu 17.04 on 3 different computers. Here's an example:
Apr 12 22:35:00 ******** kernel: gnome-shell[2592]: segfault at 10 ip 00007f0e3ccc26d7 sp 00007ffdd31b4d90 error 4 in libmozjs-38.so.0.0.0[7f0e3c93e000+6c7000]
I've analyzed the issue for a while and I actually believe I've found the solution.
If I simply download the apt source package and build it using gcc 6.3.0, and then go to js/src and execute:
$ make check-jstests | grep -c UNEXPECTED-FAIL
49
Upon examination, those test failures are all because of segfaults.
If I rebuild and retests with gcc 5, all tests pass.
I've discovered that adding the flag -fno-strict-aliasing causes all of the tests to pass with gcc 6. |
|
| 2017-04-15 21:13:53 |
Jeremy Bícha |
description |
Impact
------
This enables build tests to run and pass. This was done by building without -fstrict-aliasing and skipping 3 ICU tests. (Those 3 tests don't work right with the system ICU that Ubuntu 17.04 is using to build mozjs38.)
Test Case
---------
1. Since the tests will now fail the build if they fail, make sure that mozjs38 builds on all architectures
2. Install the new version and make sure GNOME Shell seems to still work.
Regression Potential
--------------------
I don't know much about strict-aliasing, but I believe it's safer to disable it on a large old codebase like this. Since it makes the build tests pass now, it seems like disabling strict-aliasing may fix some bugs.
Other Info
----------
mozjs is the SpiderMonkey JavaScript engine from Firefox. This version is from Firefox 38.
Original Bug Description
------------------------
A friend and I are seeing frequent gnome-shell crashes on Ubuntu 17.04 on 3 different computers. Here's an example:
Apr 12 22:35:00 ******** kernel: gnome-shell[2592]: segfault at 10 ip 00007f0e3ccc26d7 sp 00007ffdd31b4d90 error 4 in libmozjs-38.so.0.0.0[7f0e3c93e000+6c7000]
I've analyzed the issue for a while and I actually believe I've found the solution.
If I simply download the apt source package and build it using gcc 6.3.0, and then go to js/src and execute:
$ make check-jstests | grep -c UNEXPECTED-FAIL
49
Upon examination, those test failures are all because of segfaults.
If I rebuild and retests with gcc 5, all tests pass.
I've discovered that adding the flag -fno-strict-aliasing causes all of the tests to pass with gcc 6. |
Impact
------
This enables build tests to run on all architectures. The tests now fail the build on all architectures except arm64, ppc64el and s390x. (On arm64 and ppc64el, the tests fail and I wasn't able to test s390x before uploading. This means that there is a decent chance the gnome-shell does not work on these architectures but Ubuntu GNOME only officially supports gnome-shell on i386 and amd64.)
This was done by building without -fstrict-aliasing and skipping 3 ICU tests. (Those 3 tests don't work right with the system ICU that Ubuntu 17.04 is using to build mozjs38.)
Test Case
---------
1. Since the tests will now fail the build if they fail, make sure that mozjs38 builds on all architectures
2. Install the new version and make sure GNOME Shell seems to still work.
Regression Potential
--------------------
I don't know much about strict-aliasing, but I believe it's safer to disable it on a large old codebase like this. Since it makes the build tests pass now, it seems like disabling strict-aliasing may fix some bugs.
Other Info
----------
mozjs is the SpiderMonkey JavaScript engine from Firefox. This version is from Firefox 38.
Original Bug Description
------------------------
A friend and I are seeing frequent gnome-shell crashes on Ubuntu 17.04 on 3 different computers. Here's an example:
Apr 12 22:35:00 ******** kernel: gnome-shell[2592]: segfault at 10 ip 00007f0e3ccc26d7 sp 00007ffdd31b4d90 error 4 in libmozjs-38.so.0.0.0[7f0e3c93e000+6c7000]
I've analyzed the issue for a while and I actually believe I've found the solution.
If I simply download the apt source package and build it using gcc 6.3.0, and then go to js/src and execute:
$ make check-jstests | grep -c UNEXPECTED-FAIL
49
Upon examination, those test failures are all because of segfaults.
If I rebuild and retests with gcc 5, all tests pass.
I've discovered that adding the flag -fno-strict-aliasing causes all of the tests to pass with gcc 6. |
|
| 2017-04-15 21:13:58 |
Jeremy Bícha |
mozjs38 (Ubuntu): status |
Triaged |
In Progress |
|
| 2017-04-18 18:14:40 |
Adam Conrad |
mozjs38 (Ubuntu Zesty): status |
In Progress |
Fix Committed |
|
| 2017-04-18 18:14:44 |
Adam Conrad |
bug |
|
|
added subscriber Ubuntu Stable Release Updates Team |
| 2017-04-18 18:14:45 |
Adam Conrad |
bug |
|
|
added subscriber SRU Verification |
| 2017-04-18 18:14:51 |
Adam Conrad |
tags |
zesty |
verification-needed zesty |
|
| 2017-04-18 18:32:06 |
Brian Murray |
removed subscriber Brian Murray |
|
|
|
| 2017-04-20 03:41:53 |
David John Dudson |
tags |
verification-needed zesty |
verification-done zesty |
|
| 2017-04-22 09:28:43 |
Launchpad Janitor |
mozjs38 (Ubuntu): status |
Fix Committed |
Fix Released |
|
| 2017-04-25 19:36:43 |
Launchpad Janitor |
mozjs38 (Ubuntu Zesty): status |
Fix Committed |
Fix Released |
|
| 2017-04-25 19:36:46 |
Brian Murray |
removed subscriber Ubuntu Stable Release Updates Team |
|
|
|
