Comment 54 for bug 1113166

Revision history for this message
In , Landry-openbsd (landry-openbsd) wrote :

Still works fine on openbsd, i have two minor nits :

- i was wrong in comment 42, yarr jit doesnt work on sparc64 and i got the logic reversed (at some point it was the list of archs to exclude, now it's the list of archs where yarr is available) - so please just put 'sparc' in the list of archs, not 'sparc*'

- the construct you use for DLL_SUFFIX doesnt work, here with SO_VERSION set in the env it still uses 1.0. Can you use such construct as seen in m-c/configure.in ? See https://bugzilla.mozilla.org/show_bug.cgi?id=648721 for the background.

2307 if test "$SO_VERSION"; then
2308 DLL_SUFFIX=".so.$SO_VERSION"
2309 else
2310 DLL_SUFFIX=".so.1.0"
2311 fi

Here it does weird stuff such as
./js/src/config/autoconf.mk:DLL_SUFFIX = .so.$(if $(SO_VERSION),$(SO_VERSION),1.0)
./js/src/config/expandlibs_config.py:DLL_SUFFIX = normalize_suffix(".so.$(if $(SO_VERSION),$(SO_VERSION),1.0)")
./js/src/config.log:configure:14534: cc -shared -fPIC -pthread -o libconftest.so.$(if $(SO_VERSION),$(SO_VERSION),1.0) -Wl
./js/src/config.log:cc: $(SO_VERSION),$(SO_VERSION),1.0): No such file or directory
./js/src/js-confdefs.h:#define MOZ_DLL_SUFFIX ".so.$(if $(SO_VERSION),$(SO_VERSION),1.0)"

Tested on amd64, will test it on other exotic archs i have around. spidermonkey currently builds on amd64/ppc/i386/alpha/mips64{,el}/sparc64/hppa, i'd like to get the same coverage..it only badly fails at runtime on mips64/sparc64 & hppa.