NoScript brings up XSS and ABE bugs; blocking U1 'Confirm Device Access'---document workaround rule

Bug #405581 reported by Stephen
110
This bug affects 19 people
Affects Status Importance Assigned to Milestone
Ubuntu One Servers
Won't Fix
Medium
Unassigned
mozilla-noscript (Ubuntu)
Confirmed
Undecided
Unassigned

Bug Description

A workaround is documented at: https://answers.launchpad.net/ubuntuone-client/+faq/957

When setting up Ubuntu One, if you have the No-Script firefox extension, No-Script will prevent execution of the page that allows you to 'Confirm Device Access'. As a workaround, go into the NoScript options and temporarily disable the SYSTEM ruleset in the Advanced > ABE tab.

Tags: desktop+
Paul Sladen (sladen)
affects: ubuntuone-client → ubunet
summary: - No-Script prevents Ubuntu One setup
+ No-Script prevents Ubuntu One blocks 'Confirm Device Access' setup page
summary: - No-Script prevents Ubuntu One blocks 'Confirm Device Access' setup page
+ No-Script prevents Ubuntu One 'Confirm Device Access' page
summary: - No-Script prevents Ubuntu One 'Confirm Device Access' page
+ No-Script prevents Ubuntu One 'Confirm Device Access' page blocked by
+ No-Script
Paul Sladen (sladen)
summary: - No-Script prevents Ubuntu One 'Confirm Device Access' page blocked by
- No-Script
+ Ubuntu One 'Confirm Device Access' page blocked by No-Script
Revision history for this message
Rick McBride (rmcbride) wrote : Re: Ubuntu One 'Confirm Device Access' page blocked by No-Script

The specific reason this is happening is that page retrieves the local hostname in order to present a human readable default name for the machine that is being added. Previously we used non-intuitive guid strings, which were not terribly easy to tell apart.

Revision history for this message
Stephen (sjspams) wrote :

I'm not quite sure how either piece of software works (Ubunet or NoScript) but it seems logical enough that if the hostname-fetching script fails, or is blocked, the Confirm Device Access page should gracefully recognize what is happening, and to at least attempt to inform the user of the situation. Creating an exception in NoScript would be illogical because blocking this kind of thing is its entire purpose.

Also, I just checked my account information, and the computer on my account that is listed (the one used in discovering this problem) was listed as what appeared to be a UUID-type string.

Revision history for this message
Elliot Murphy (statik) wrote : Re: [Bug 405581] Re: Ubuntu One 'Confirm Device Access' page blocked by No-Script

We definitely need to investigate whether we can show a more useful
error, and show a friendlier name for the computer.

The best I can tell, NoScript is breaking correctly functioning OAuth
token exchange, and I consider NoScript to be a suspicious piece of
software. However, we should do our best to give the user enough
information to figure out that they need to remove or temporarily
disable NoScript, because hitting this bug will be very frustrating for
users.

--
Elliot Murphy | https://launchpad.net/~statik/

Revision history for this message
Rick McBride (rmcbride) wrote :

Elliot Murphy wrote:
> We definitely need to investigate whether we can show a more useful
> error, and show a friendlier name for the computer.
>
> The best I can tell, NoScript is breaking correctly functioning OAuth
> token exchange, and I consider NoScript to be a suspicious piece of
> software. However, we should do our best to give the user enough
> information to figure out that they need to remove or temporarily
> disable NoScript, because hitting this bug will be very frustrating for
> users.
>

I've encountered this and mentioned it in a previous bug report.

a new Noscript feature, Application Boundary Enforcer (ABE) takes issue
with our collection of the local host name for the confirm Device Access
page. Turning that feature off solves the issue. No other aspect of
Noscript needs to be removed or turned off to make it work.

Revision history for this message
Paul Sladen (sladen) wrote : Re: Ubuntu One 'Confirm Device Access' page blocked by No-Script

So the solutions are:

  (a) Get a hardcoded exception in no-script;
  (b) Cope with failing to get a pretty hostname and just fallback to the long hashes used before (or ask for a nickname)

tags: added: desktop+
Changed in ubunet:
assignee: nobody → Joshua Blount (jblount)
status: New → Triaged
Paul Sladen (sladen)
summary: - Ubuntu One 'Confirm Device Access' page blocked by No-Script
+ Noscript brings up XSS and ABE bugs; blocking U1 'Confirm Device Access'
Revision history for this message
Noel J. Bergman (noeljb) wrote : Re: Noscript brings up XSS and ABE bugs; blocking U1 'Confirm Device Access'

From Bug 411477:

Host: Ubuntu 9.04

NoScript 1.9.7.9

When installing Ubuntu One, if people have the NoScript extension installed (and everyone should), there are some issues.

One is an XSS notice between UbuntuOne and LaunchPad. That is easy to get around.

Another happens when trying to Add Computer. To get around that, you need to temporarily disable the Application Boundaries Enforcer (NoScript->Options->Advanced->ABE, clear the Enable ABE checkbox).

Joshua Blount (jblount)
Changed in ubunet:
assignee: Joshua Blount (jblount) → nobody
Changed in ubunet:
importance: Undecided → Medium
Paul Sladen (sladen)
summary: Noscript brings up XSS and ABE bugs; blocking U1 'Confirm Device Access'
+ ---document workaround rule
Revision history for this message
mike (ubuntu-holmesfamily) wrote :

This might be to simple, but I would rather you just ask me what I want to call the computer, then you take that name and display it to me, and use the guid internally if you need to.

I think you could just use the name I give you and check its unique within my account, by all means if there is no error suggest the machine name to me in the dialog box, however warn me before you potentially set off the SW I rely on to catch bad sites I stumble on, I immediately don't trust Ubuntu-one once noscript flags it.

Personally I would much rather have no-script than UbuntuOne if I have to chose.

Revision history for this message
MG (mg-viic) wrote :

Change your SYSTEM ABE rules to this:

# Prevent Internet sites from requesting LAN resources.
Site LOCAL
Accept from LOCAL
Site one.ubuntu.com
Accept
Deny

It'll fix your problem.

Revision history for this message
Abel Cheung (abelcheung) wrote :

Instead of throwing out the baby with bath water, the following SYSTEM ABE rule can be a bit more fine grained:

Site LOCAL
Accept from LOCAL
Accept GET from one.ubuntu.com
Deny

Revision history for this message
nomnex (nomnex) wrote :

Abel, what difference between the 2 rule syntaxes? Maone gives the former on his forum see [1]

[1] http://forums.informaction.com/viewtopic.php?f=7&t=3156

Revision history for this message
Abel Cheung (abelcheung) wrote :

@nomnex
Mine only allows GET requests from one.ubuntu.com to local private IP, instead of allowing all kinds of requests.

Revision history for this message
nomnex (nomnex) wrote : Re: [Bug 405581] Re: Noscript brings up XSS and ABE bugs; blocking U1 'Confirm Device Access'---document workaround rule

On Thu, 2010-02-04 at 20:58 +0000, Abel Cheung wrote:
> Mine only allows GET requests from one.ubuntu.com to local private IP

Wise, thanks Abel.

Revision history for this message
Joshua Hoover (joshuahoover) wrote :

Thank you Abel for the ABE rule! I created a new FAQ for this: https://answers.edge.launchpad.net/ubuntuone-client/+faq/957 As a result, I'm marking this bug as Won't Fix, as this bug is specific to NoScript users and there is a good workaround.

Changed in ubuntuone-servers:
status: Triaged → Won't Fix
description: updated
Revision history for this message
Cullen Newsom (cullennewsom) wrote :

Thanks MG, nommex, and Abel Cheung. That did the trick.

summary: - Noscript brings up XSS and ABE bugs; blocking U1 'Confirm Device Access'
+ NoScript brings up XSS and ABE bugs; blocking U1 'Confirm Device Access'
---document workaround rule
Revision history for this message
Launchpad Janitor (janitor) wrote :

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in mozilla-noscript (Ubuntu):
status: New → Confirmed
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.