Ubuntu
mozilla-firefox-locale-all package

[edgy] Keyboard shortcuts for "Add page to bookmarks..." and "Save page as..." are the same

Bug #61875 reported by Petr Tomeš on 2006-09-22

Affects		Status	Importance	Assigned to	Milestone
	mozilla-firefox-locale-all (Ubuntu)	Fix Released	Low	Martin Pitt	Ubuntu ubuntu-6.10

Bug Description

Keyboard shortcuts for "Add page to bookmarks..." and "Save page as..." are the same

Where: Updated Edgy.

Mozilla/5.0 (X11; U; Linux i686; cs-CZ; rv:1.8.1b2) Gecko/20060601 BonEcho/2.0b2 (Ubuntu-edgy)

See original description

Tags:

Petr Tomeš (ptomes) on 2006-09-22

description:

updated

Revision history for this message

Petr Tomeš (ptomes) wrote on 2006-09-22: Re: Keyboard shortcuts for "Add page to bookmarks..." and "Save page as..." are the same

Screenshot of Firefox Ffile menu Edit (147.0 KiB, image/png)

Revision history for this message

Petr Tomeš (ptomes) wrote on 2006-09-22:

Screenshot of Firefox Bookmarks menu Edit (75.2 KiB, image/png)

Revision history for this message

Petr Tomeš (ptomes) wrote on 2006-09-22:

Screenshot of Firefox Bookmarks menu Edit (136.4 KiB, image/png)

Revision history for this message

Daniel Robitaille (robitaille) wrote on 2006-09-25:

I don't see this problem on my computer. The add a bookmark is "Ctrl-D" instead of "Ctrl-S" like in yours. But I have the "en-US" version of Ubuntu's Firefox instead of "cs-CZ", which it seems make a difference.

Revision history for this message

Martin Böhm (martin.bohm) wrote on 2006-09-29:

I can confirm this bug when using the cs-CZ translation. The shortcut changes only when using this very translation. It still is a bug, though.

Martin Böhm (martin.bohm) on 2006-09-29

Changed in mozilla-firefox-locale-all:
status:	Unconfirmed → Confirmed

Revision history for this message

Martin Böhm (martin.bohm) wrote on 2006-09-29:

The fixed cs.jar file Edit (257.2 KiB, text/plain)

The only thing needed to fix is the shortcut definition in the browser/browser.dtd file in the cs.jar archive. The diff is here:

61c61
< <!ENTITY addCurPageAsCmd.commandkey "d">
---
> <!ENTITY addCurPageAsCmd.commandkey "s">

The fixed cs.jar file is attached as well.

Martin Pitt (pitti) on 2006-09-29

Changed in mozilla-firefox-locale-all:
assignee:	nobody → pitti
importance:	Undecided → Low
status:	Confirmed → In Progress

Martin Pitt (pitti) on 2006-10-05

Changed in mozilla-firefox-locale-all:
status:	In Progress → Fix Committed

Revision history for this message

Martin Pitt (pitti) wrote on 2006-10-05:

mozilla-firefox-locale-all (2.0~beta2-3) edgy; urgency=low
.
   * Add debian/patches/cs-CZ.diff: Fix Czech keyboard shortcut
     for 'Add bookmark' to be Ctrl+D instead of Ctrl+S (which is already 'Save
     page as'). Closes: LP#61875
   * debian/patches/en-GB.diff: disc -> disk. Closes: LP#61092