Incorrect parsing of OpenID team ACL

Bug #798358 reported by Andrew Glen-Young
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
moin (Ubuntu)
Triaged
Medium
Unassigned

Bug Description

MoinMoin incorrectly parses team ACLs when using the openid_teams auth option.

The regular expression that parses the ACL is not anchored correctly, causing the parser to return false positives or false negatives.

The fix is rather trivial. See the attached patch which should apply cleanly to MoinMoin 1.9.2 and 1.9.3

Example scenario:
- user 'foobar' already exists in the team ACL page.
- user 'foo' does not exist in the team ACL page.
- user 'foo' needs to be added to the team ACL page on login.

Example team ACL:
#acl Known:read All:
 * bar
 * baz
 * foobar

What happens:
- Upon successful authentication of user 'foo' the parser mistakenly matches user 'foo' as user 'foobar' and the team ACL is not updated.
- User 'foo' is denied access to the resource he is expected to access.

What should happen:
- Upon successful authentication of user 'foo', given that 'foo' is in the correct team, the team ACL should be updated with his username.

Additional details:

Ubuntu release: Lucid Lynx
Package version: python-moinmoin-1.9.2-2ubuntu3.1

Tags: patch
Revision history for this message
Andrew Glen-Young (aglenyoung) wrote :
tags: added: patch
Revision history for this message
James Page (james-page) wrote :

Still and issue in the latest package in utopic - marking as Medium/Triaged.

Changed in moin (Ubuntu):
status: New → Triaged
importance: Undecided → Medium
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.