Regression in ModemManager

Bug #1828102 reported by yparitcher on 2019-05-07
14
This bug affects 1 person
Affects Status Importance Assigned to Milestone
modemmanager (Ubuntu)
Status tracked in Eoan
Bionic
High
Unassigned
Cosmic
High
Till Kamppeter
Disco
High
Till Kamppeter
Eoan
High
Unassigned

Bug Description

[Impact]

ModemManager disconnects from CDMA modem after 30 sec failing to check signal status due to incorrect error handling

[Test case]

connect to a cdma device without an extra AT channel (Eg. Samsung brightside phone) and modemmanager will terminate the connection

[Regression potential]

The patch is tiny, fixing an obvious overlook, and it only affects CDMA broadband modems, so the risk of a regression is very low.

[Original description]

ModemManager disconnects after ~30 sec

caused by a typo in 1.8

see https://bugs.launchpad.net/ubuntu/+source/modemmanager/+bug/1819615
and
https://gitlab.freedesktop.org/mobile-broadband/ModemManager/issues/119
for details

needs a SRU for cosmic and dingo

patch attached

yechiel

yparitcher (yparitcher) wrote :
Changed in modemmanager (Ubuntu Eoan):
status: New → Fix Released
Till Kamppeter (till-kamppeter) wrote :

debdiff for SRU for disco.

Changed in modemmanager (Ubuntu Disco):
status: New → In Progress
Till Kamppeter (till-kamppeter) wrote :

debdiff for SRU for cosmic.

Changed in modemmanager (Ubuntu Cosmic):
status: New → In Progress
description: updated
Till Kamppeter (till-kamppeter) wrote :

yparitcher, thank you very much for this bug report and the patch. To start the SRU approval process could you please edit the initial description, filling in the [Impact] and [Test case] sections? The first is to describe what impact this bug has to the users, the second is for describing how to reproduce the bug.

yparitcher (yparitcher) wrote :

launchpad errors whenever i try to update or post a comment directly from a bug. it only works from the comment/attachment page so here is the updated desc.

[Impact]

ModemManager disconnects from CDMA modem after 30 sec failing to check signal status due to incorrect error handling

[Test case]

connect to a cdma device without an extra AT channel (Eg. Samsung brightside phone) and modemmanager will terminate the connection

[Regression potential]

The patch is tiny, fixing an obvious overlook, and it only affects CDMA broadband modems, so the risk of a regression is very low.

[Original description]

ModemManager disconnects after ~30 sec

caused by a typo in 1.8

see https://bugs.launchpad.net/ubuntu/+source/modemmanager/+bug/1819615
and
https://gitlab.freedesktop.org/mobile-broadband/ModemManager/issues/119
for details

needs a SRU for cosmic and dingo

patch attached

yechiel

summary: - regression in modemmanager
+ Regression in ModemManager
Changed in modemmanager (Ubuntu Cosmic):
assignee: nobody → Till Kamppeter (till-kamppeter)
Changed in modemmanager (Ubuntu Disco):
assignee: nobody → Till Kamppeter (till-kamppeter)
description: updated
Till Kamppeter (till-kamppeter) wrote :

Added description changes from comment #5.

Please could someone with appropriate rights sponsor the uploads of the attached debdiffs (SRUs)? Thanks.

It would be great if at least the SRU for Disco could get uploaded and rolled out. Cosmic is very close before EOL, so it can easily happen that the SRU does not get published in time, so Disco is much more important.

Dan Streetman (ddstreet) wrote :

Cosmic has reached EOL, today:
https://lists.ubuntu.com/archives/ubuntu-announce/2019-July/000246.html

However, I uploaded this for disco.

Note to sru reviewers, this patch was applied to bionic already in bug 1819615

Changed in modemmanager (Ubuntu Bionic):
status: New → Fix Released
Changed in modemmanager (Ubuntu Cosmic):
status: In Progress → Won't Fix
Ken VanDine (ken-vandine) wrote :

I've sponsored this for disco

Dan Streetman (ddstreet) wrote :

> I've sponsored this for disco

lol, looks like we collided :)

since our uploads are identical (I assume) it shouldn't matter which the ubuntu-sru team approves.

Hello yparitcher, or anyone else affected,

Accepted modemmanager into disco-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/modemmanager/1.10.0-1ubuntu0.19.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-disco to verification-done-disco. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-disco. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in modemmanager (Ubuntu Disco):
status: In Progress → Fix Committed
tags: added: verification-needed verification-needed-disco
tags: added: regression-update
Changed in modemmanager (Ubuntu Bionic):
importance: Undecided → High
Changed in modemmanager (Ubuntu Cosmic):
importance: Undecided → High
Changed in modemmanager (Ubuntu Disco):
importance: Undecided → High
Changed in modemmanager (Ubuntu Eoan):
importance: Undecided → High
tags: added: regression-release
removed: regression-update
Mathew Hodson (mathew-hodson) wrote :

For Bionic, this bug was fixed in the package modemmanager - 1.10.0-1~ubuntu18.04.2

---------------
modemmanager (1.10.0-1~ubuntu18.04.2) bionic; urgency=medium

  * debian/patches/error-propagation-fix.patch: mm-broadband-modem: Fix error
    propagation in CDMA service status (LP: #1819615, Upstream Issue #119).

tags: added: regression-proposed
Dan Streetman (ddstreet) wrote :

@till-kamppeter are you able to verify this for disco?

@ddstreet, unfortunately, I cannot verify this as the bug only occured for CDMA phones and the CDMA system is only available in the US where the rest of the world only uses GSM and UMTS systems for cell phones. So we need someone in the US to verify this fix.

yparitcher (yparitcher) wrote :

I verified This for Bionic, I dont have Disco so i cant verify, But it is the exact same patch - just fixing a typo. so it should be good.

Dan Streetman (ddstreet) wrote :

@yparitcher is it possible for you verify with disco using a live cd?
https://tutorials.ubuntu.com/tutorial/try-ubuntu-before-you-install

Typically, we want to see srus verified by testing the specific code/release, if possible. Even with simple patches, sometimes things can go wrong.

Dan Streetman (ddstreet) wrote :

> is it possible for you verify with disco using a live cd?

to clarify, actually installing disco to test/verify is preferred, but I suggested the live cd as that will let you reproduce the problem and verify the fix, without having to actually install disco to your hard drive - the live cd runs in memory only.

yparitcher (yparitcher) wrote :

No, I no longer use ubuntu, and don't have the patience to verify on a live cd.
the patch works, it is literally fixing a one word typo.

Dan Streetman (ddstreet) wrote :

Based on the below items, and the assumption that there is nobody currently available to actually manually verify this for disco, I'm marking this as verification-done-disco, although I have not personally verified it for disco. I leave it up to ~ubuntu-sru team to decide if this is enough to release the package to disco-updates.

1. existing verification of this patch for bionic (comment 14)

2. the modemmanager codebase being almost identical between bionic and disco:
 modemmanager | 1.10.0-1~ubuntu18.04.2 | bionic-updates | source, amd64, arm64, armhf, i386, ppc64el, s390x
 modemmanager | 1.10.0-1ubuntu0.19.04.1 | disco-proposed | source, amd64, arm64, armhf, i386, ppc64el, s390x
$ git diff --stat pkg/ubuntu/bionic-devel..pkg/ubuntu/disco-devel
 debian/changelog | 14 ++++++-------
 debian/libmm-glib0.symbols | 236 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++--------------------------------------------------------------------------------------------------------------
 debian/patches/error-propagation-fix.patch | 2 +-
 3 files changed, 125 insertions(+), 127 deletions(-)

3. the simplicity and obviousness of the patch:
--- a/src/mm-broadband-modem.c
+++ b/src/mm-broadband-modem.c
@@ -8231,7 +8231,7 @@
     GError *inner_error = NULL;
     gboolean value;

- value = g_task_propagate_boolean (G_TASK (res), error);
+ value = g_task_propagate_boolean (G_TASK (res), &inner_error);
     if (inner_error) {
         g_propagate_error (error, inner_error);
         return FALSE;

tags: added: verification-done-disco
removed: verification-needed
tags: added: verification-done
removed: verification-needed-disco
Chris Halse Rogers (raof) wrote :

I'll accept that rationale; releasing to Disco.

Launchpad Janitor (janitor) wrote :

This bug was fixed in the package modemmanager - 1.10.0-1ubuntu0.19.04.1

---------------
modemmanager (1.10.0-1ubuntu0.19.04.1) disco; urgency=medium

  * debian/patches/error-propagation-fix.patch: mm-broadband-modem: Fix error
    propagation in CDMA service status (LP: #1828102, Upstream Issue #119).

 -- Till Kamppeter <email address hidden> Mon, 13 May 2019 19:19:19 +0200

Changed in modemmanager (Ubuntu Disco):
status: Fix Committed → Fix Released

The verification of the Stable Release Update for modemmanager has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.