support for https in is_url()

Bug #1935756 reported by Moses Moore
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
moc (Ubuntu)
Confirmed
Undecided
Unassigned

Bug Description

MOC will recognize filenames starting with "http://" and "ftp://" as URLs, and use libcurl.
But it will not recognize filenames starting with "https://"

Just need to add another condition in the "is_url(const char *str)" function in files.c and recompile.

Tags: patch
Revision history for this message
Rolf Leggewie (r0lf) wrote (last edit ):

Thank you for the suggestion. This is best dealt with upstream. Have you contacted upstream? https://github.com/jonsafari/mocp

Revision history for this message
Moses Moore (moses-ubuntu) wrote :

Author disabled the "issues" feature so there's no means for making a bug report. Guess I'll clone the repo, fork it to my own github, write the patch and then submit a pull request. If the pull is accepted, do I return here to ask for a version bump in this package?

Revision history for this message
Moses Moore (moses-ubuntu) wrote :
Revision history for this message
Launchpad Janitor (janitor) wrote :

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in moc (Ubuntu):
status: New → Confirmed
Revision history for this message
Rolf Leggewie (r0lf) wrote :

Thank you so much for your work. Here's me hoping it will be merged soon.

tags: added: patch
Revision history for this message
Moses Moore (moses-ubuntu) wrote :

That was submitted four years ago, and the original author hasn't made an update in six years. How can I submit a patch to be included in building the the Debian or Ubuntu .deb package? I'm pretty sure changes from the upstream source are allowed.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.