please sync mldonkey 2.8.2-2 from Debian unstable (main) (was: Urgent patch to solve upload problem)

[spiralvoice]

Hi,

MLDonkey has a very serious bug which leeds to uploading
data blocks twice to eMule clients.

This is due to the fact that MLDonkey gets confused by
eMule rotating block request scheme.

http://hydranode.com/docs/ed2k/ed2kproto.php#upload
> Namely, eMule (and compatible) clients use "rotational chunkrequest" scheme,
> where each REQCHUNKS packet contains one new chunk and two older chunks
> ...
> This can lead to duplicate data being sent by mldonkeys, if a rotational
> chunkrequest scheme is used when communicating with them.

More infos about it, including logs proving the problem, can be found here:
http://mldonkey.sourceforge.net/forums/viewtopic.php?t=4576

On https://savannah.nongnu.org/patch/index.php?5664 you will find patches
for all MLDonkey versions since 2.6.0. I tested the patch with 2.6.0,
without it it uploaded 700MB for a 350MB file to eMule 0.47c, with the
patch it send 350MB, nothing more.

Please update all MLDonkey ebuilds present in Ubuntu.

[Kai Kasurinen (kai-kasurinen)]

Fixed in Debian:

mldonkey (2.8.2-2) unstable; urgency=low
 .
   * Added avoid-duplicate-sending to fix a serious bug which lead mldonkey to
     uploading data blocks twice to eMule clients, closes: #406247.
   * Added useradd.dpatch to be able to add users using useradd command. However
     adding mldonkey users in postinst is a broken behaviour; not doing it
     anymore, closes: #397497. Not installing mldonkey_users anymore since it is
     not compatible with the new users.ini format.
   * Change uid of mldonkey on startup, closes: #405173.

[Matti Lindell (mlind)]

Confirming.
Ubuntu package has no changes. Package builds cleanly with Feisty sbuild.
Kai already posted the new Debian changes.

[Daniel T Chen (crimsun)]

Sync request ACKed.

[Martin Pitt (pitti)]

 * Trying to add mldonkey...
  - <mldonkey_2.8.2.orig.tar.gz: already in distro - downloading from librarian>
  - <mldonkey_2.8.2-2.diff.gz: downloading from http://ftp.debian.org/debian/>
  - <mldonkey_2.8.2-2.dsc: downloading from http://ftp.debian.org/debian/>
I: mldonkey [universe] -> mldonkey-server_2.8.2-1 [universe].
I: mldonkey [universe] -> mldonkey-gui_2.8.2-1 [universe].

[spiralvoice (spiralvoice)]

On https://savannah.nongnu.org/patch/index.php?5664
are also patches for these packages:

edgy: 2.8.1-1
dapper: 2.7.1-2ubuntu2

Please include these patches as well.

If you need a patch for hoary/breezy/warty please
post a request here in this bug report or on Savannah.

[Matti Lindell (mlind)]

spiralvoice, please open separate backport tickets for Edgy and Dapper versions, thanks.