miro.real crashed with KeyError in wrapper() (Miro keeps running)

[Eugene]

Binary package hint: miro

Just seemed to crash when I switched to the Miro app.

TraceBack with 3.0 (not uploaded yet):
Traceback (most recent call last):
  File "/usr/lib/pymodules/python2.6/miro/frontends/widgets/gtk/weakconnect.py", line 49, in handle_callback
    return real_method(obj, *(args + self.user_args))
  File "/usr/lib/pymodules/python2.6/miro/frontends/widgets/gtk/base.py", line 90, in on_hierarchy_changed
    window = wrappermap.wrapper(toplevel)
  File "/usr/lib/pymodules/python2.6/miro/frontends/widgets/gtk/wrappermap.py", line 46, in wrapper
    raise KeyError("Widget wrapper no longer exists")

ProblemType: Crash
Architecture: amd64
Date: Wed Mar 10 21:22:19 2010
DistroRelease: Ubuntu 10.04
ExecutablePath: /usr/bin/miro.real
InstallationMedia: Ubuntu 10.04 "Lucid Lynx" - Alpha amd64 (20100224.1)
InterpreterPath: /usr/bin/python2.6
Package: miro 2.5.4-1ubuntu1
ProcCmdline: /usr/bin/python2.6 /usr/bin/miro.real
ProcEnviron:
 LANG=en_CA.utf8
 SHELL=/bin/bash
ProcVersionSignature: Ubuntu 2.6.32-15.22-generic
PythonArgs: ['/usr/bin/miro.real']
SourcePackage: miro
Title: miro.real crashed with KeyError in wrapper()
Uname: Linux 2.6.32-15-generic x86_64
UserGroups: adm admin cdrom dialout lpadmin plugdev sambashare

[miegiel (nix-miegiel)]

It seems solved to me.

At the moment I can't reproduce the bug anymore. I used to get the "crash detected" warning the first time (and only the first time) I selected one of the feeds in the sidebar after starting miro. Miro seemed to continue to run, regardless of the warning.

[elgabi-launchpad (elgabionline-membresia)]

I selected "Legal Torrents" in the sidebar after starting miro at first time. Miro seemed to continue to run, regardless of the warning.

[Daniel Hahler (blueyed)]

Yes, this appears to be non-crashing error: the app keeps running.

[Daniel Hahler (blueyed)]

For me this is reproducible by selecting any of the Websites in the left sidebar, like "Legal Torrents" as pointed out before.

Also, this might be the reason why the canvas is not drawn anymore when going to another Website (where the error happens again - looking at the console) and back to a previously selected website.

willkg on #miro-hackers said it's probably related to lucid / xulrunner.

[Ben Dean-Kawamura (ben-pculture)]

I'm pretty sure that this is caused from a XULRunner bug. Here's a test script that shows the problem. If you run it you should see a GtkMozEmbed widget. Then click the button. This should remove the widget. So far everything's fine. However, when you click the button again, the script will try to show the widget and this will crash.

I'm pretty sure the GTK code is completely valid. It seems to have to do with GtkMozEmbed using an offscreen window to hold onto it's widget when it's unrealized (see MozEmbedPrivate.cpp in the mozilla tree)

[Ben Dean-Kawamura (ben-pculture)]

Here's a patch that works around the issue for me. It's definitely not a pretty solution, we just short-circuit the code that mozilla has to handle un-realize/re-realize. At the very least this is a memory leak, however it only leaks when the user deletes sites, which isn't going to happen very often. I'm also a little worried that the unrealize code is important for other reasons, however I haven't got xulrunner to crash in my testing.

Can other people test it out and see if they have problems? I think that we should have a cleaner solution for 3.1, but for a quick and dirty fix for only lucid, maybe it could work.

[Ben Dean-Kawamura (ben-pculture)]

Sorry, my first attempt was a patch against master. Here's one against the 3.0 branch, which is used in lucid.

[Ben Dean-Kawamura (ben-pculture)]

Upgrading to xulrunner-1.9.2.3 fixed the issue for me. Does it fix it for others?

[Brian Rogers (brian-rogers)]

I'm still getting the error message.

$ apt-cache policy miro xulrunner-1.9.2 | grep Installed
  Installed: 3.0.1-0ubuntu1
  Installed: 1.9.2.3+nobinonly-0ubuntu2

[Brian Rogers (brian-rogers)]

Your patch did the trick, though.

[Ben Dean-Kawamura (ben-pculture)]

I don't think it was upgrading that fixed the issue directly. What happened is that Miro started using xulrunner-1.9.1 rather than xulrunner 1.9.2. I'm not sure why that happened exactly, but I just checked in some code that forces it to happen and I think that does the trick.

So here's what I think is the correct solution:

1) Get the latest version of the 3.0 branch, make sure it includes this changeset:
 http://git.pculture.org/miro/commit/?h=Miro-3.0&id=318bad719793114443bd97746c7a24a00cd1794d

2) Apply this patch to force Miro to link to xulrunner-1.9.1:
http://bugzilla.pculture.org/attachment.cgi?id=2395

As far as I can tell that solves the problem, can others test it out? I think it's much cleaner than my original patch.

[Micah Gersten (micahg)]

This is not a good solution as we are dropping xulrunner-1.9.1 from Lucid.

On 04/19/2010 04:31 PM, Ben Dean-Kawamura wrote:
> I don't think it was upgrading that fixed the issue directly. What
> happened is that Miro started using xulrunner-1.9.1 rather than
> xulrunner 1.9.2. I'm not sure why that happened exactly, but I just
> checked in some code that forces it to happen and I think that does the
> trick.
>
> So here's what I think is the correct solution:
>
> 1) Get the latest version of the 3.0 branch, make sure it includes this
changeset:
>
http://git.pculture.org/miro/commit/?h=Miro-3.0&id=318bad719793114443bd97746c7a24a00cd1794d
>
> 2) Apply this patch to force Miro to link to xulrunner-1.9.1:
> http://bugzilla.pculture.org/attachment.cgi?id=2395
>
> As far as I can tell that solves the problem, can others test it out? I
> think it's much cleaner than my original patch.
>

[Brian Rogers (brian-rogers)]

Ben, your patch looks fine and fairly clean to me. Even if it's a workaround for what is ultimately a xulrunner issue, I think a workaround in Miro would be preferred over patching xulrunner this late in the Lucid development cycle. So I'd say don't worry for now that something needs to be fixed in xulrunner.

[Launchpad Janitor (janitor)]

This bug was fixed in the package miro - 3.0.1-0ubuntu2

---------------
miro (3.0.1-0ubuntu2) lucid; urgency=low

  * debian/patches/102_xulrunner_bug_workaround.patch:
    Workaround bug in xulrunner 1.9.2. (LP: #537050)
 -- Daniel Hahler <email address hidden> Tue, 20 Apr 2010 20:07:07 +0200

[dino99 (9d9)]

Eol reached or near to be; Time to move to a newer release now.

[Alberto Salvia Novella (es20490446e)]

I'm unsuscribing the Ubuntu Bug Control team.