[regression] Mir server command line options are unpredictable/nondeterministic (--vt is sometimes not recognised)
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Mir |
Fix Released
|
High
|
Mir development team | ||
0.18 |
Fix Released
|
High
|
Mir development team | ||
mir (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
Mir server platform command line options are unpredictable/
I keep thinking I'm imagining things. Sometimes --vt works and sometimes it doesn't (from a Gnome Terminal). Well both are true. Now I have two separate wily machines with the same packages. One fails but the other works:
FAILING MACHINE:
$ sudo mir_proving_server --vt 1
[1444966151.185585] mirplatform: Found graphics driver: mesa-x11
[1444966151.187021] mirplatform: Found graphics driver: mesa-kms
Unknown command line options: --vt 1
$ dpkg -l | grep mir-demos
ii mir-demos 0.16.0+
WORKING MACHINE:
$ sudo mir_proving_server --vt 1
[1444965570.300933] mirplatform: Found graphics driver: mesa-kms
[1444965570.302119] mirplatform: Found graphics driver: mesa-x11
[1444965570.304409] mircommon: Loading modules from: /usr/lib/
[1444965570.304465] mircommon: Loading module: /usr/lib/
[1444965570.304486] mircommon: Loading module: /usr/lib/
[1444965570.305801] mirplatform: Found graphics driver: mesa-kms
[1444965570.306531] mirplatform: Found graphics driver: mesa-x11
[1444965570.306617] mirserver: Selected driver: mesa-kms (version 0.16.0)
...
$ dpkg -l | grep mir-demos
ii mir-demos 0.16.0+
It appears the unpredictability might be arising from which driver it finds on the filesystem first.
Related branches
- PS Jenkins bot (community): Approve (continuous-integration)
- Andreas Pokorny (community): Approve
- Alan Griffiths: Approve
- Alexandros Frantzis (community): Approve
-
Diff: 140 lines (+36/-11)5 files modifiedsrc/platforms/mesa/server/kms/platform_symbols.cpp (+21/-3)
src/platforms/mesa/server/x11/graphics/graphics.cpp (+1/-1)
tests/unit-tests/graphics/mesa/kms/test_platform.cpp (+2/-2)
tests/unit-tests/graphics/mesa/x11/test_platform.cpp (+2/-2)
tests/unit-tests/graphics/test_platform_prober.cpp (+10/-3)
- PS Jenkins bot (community): Approve (continuous-integration)
- Daniel van Vugt: Approve
- Cemil Azizoglu (community): Needs Information
-
Diff: 126 lines (+11/-29)5 files modifiedsrc/platforms/mesa/server/kms/platform_symbols.cpp (+3/-21)
src/platforms/mesa/server/x11/graphics/graphics.cpp (+1/-1)
tests/unit-tests/graphics/mesa/kms/test_platform.cpp (+2/-2)
tests/unit-tests/graphics/mesa/x11/test_platform.cpp (+2/-2)
tests/unit-tests/graphics/test_platform_prober.cpp (+3/-3)
- PS Jenkins bot (community): Approve (continuous-integration)
- Alan Griffiths: Approve
- Alberto Aguirre (community): Approve
-
Diff: 182 lines (+64/-11)5 files modifiedsrc/platforms/mesa/server/kms/platform_symbols.cpp (+28/-3)
src/platforms/mesa/server/x11/graphics/graphics.cpp (+1/-1)
tests/unit-tests/graphics/mesa/kms/test_platform.cpp (+2/-2)
tests/unit-tests/graphics/mesa/x11/test_platform.cpp (+2/-2)
tests/unit-tests/graphics/test_platform_prober.cpp (+31/-3)
tags: | added: vt |
Changed in mir: | |
milestone: | none → 0.18.0 |
Changed in mir: | |
assignee: | nobody → Cemil Azizoglu (cemil-azizoglu) |
importance: | Undecided → High |
Changed in mir: | |
status: | Fix Committed → Triaged |
Changed in mir: | |
assignee: | nobody → Mir development team (mir-team) |
status: | Triaged → In Progress |
Changed in mir: | |
status: | Fix Committed → Fix Released |
Changed in mir: | |
status: | Fix Released → Fix Committed |
Changed in mir (Ubuntu): | |
status: | New → Fix Released |
I think the problem came from this:
------- ------- ------- ------- ------- ------- ------- ------- ----
revno: 2756 [merge]
author: Cemil Azizoglu <email address hidden>
committer: Tarmac
branch nick: development-branch
timestamp: Sun 2015-07-19 01:26:23 +0000
message:
Use command line options during platform probe.
Introduce a new PlatformPriority value (dummy) which is lower than what real platforms use (supported/best). Return best when a platform-specific option is passed in. This will help in differentiating between Mesa and X11 platforms when the server is launched from an xterm depending on the presence of the "--vt" option.
Approved by PS Jenkins bot, Alberto Aguirre. ------- ------- ------- ------- ------- ------- ------- ----
-------