tests are sleeping, not waiting for a condition

[Alan Griffiths]

This is bad test design as the tests are inherently flaky unless the time is "excessive", and slow as "excessive" waits add to the total runtime.

$ grep this_thread::sleep_for -R tests/ | wc -l
96

[Daniel van Vugt (vanvugt)]

I think the focus should be on build times more than this. Build times are at least an order of magnitude more than test run times, even on a fast machine.

[Alan Griffiths (alan-griffiths)]

There has been some small improvement:

$ grep this_thread::sleep_for -R tests/ | wc -l
83

[Michał Sawicz (saviq)]

Syncing task from Mir.