Mir touchpad does not support relative mouse events
Bug #1479463 reported by
Brandon Schaefer
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Mir |
Fix Released
|
High
|
Andreas Pokorny | ||
| mir (Ubuntu) |
New
|
Undecided
|
Unassigned | ||
Bug Description
The touchpad should be treated as a pointer when doing relative mouse events, but its treated as a touch device for those and get no relative dx/dy events.
Related branches
lp:~andreas-pokorny/mir/load-all-supported-input-platforms
- PS Jenkins bot (community): Approve (continuous-integration)
- Cemil Azizoglu (community): Approve
- Alan Griffiths: Abstain
- Daniel van Vugt: Needs Fixing
- Chris Halse Rogers: Approve
-
Diff: 774 lines (+366/-77)22 files modifiedbenchmarks/frame-uniformity/touch_producing_server.cpp (+0/-1)
include/platform/mir/input/platform.h (+2/-2)
include/test/mir_test_framework/executable_path.h (+1/-0)
src/include/server/mir/default_server_configuration.h (+1/-11)
src/include/server/mir/input/input_probe.h (+48/-0)
src/platform/graphics/platform_probe.cpp (+5/-1)
src/platforms/evdev/platform_factory.cpp (+1/-1)
src/platforms/mesa/server/x11/input/input.cpp (+1/-1)
src/server/input/CMakeLists.txt (+1/-0)
src/server/input/default_configuration.cpp (+16/-39)
src/server/input/input_probe.cpp (+104/-0)
src/server/symbols.map (+1/-1)
tests/mir_test_framework/CMakeLists.txt (+1/-0)
tests/mir_test_framework/executable_path.cpp (+10/-0)
tests/mir_test_framework/fake_input_device_impl.cpp (+1/-1)
tests/mir_test_framework/fake_input_server_configuration.cpp (+0/-1)
tests/mir_test_framework/input_testing_server_options.cpp (+0/-1)
tests/mir_test_framework/stub_input.cpp (+2/-2)
tests/mir_test_framework/stub_input_platform.cpp (+1/-1)
tests/umock-acceptance-tests/test_libinput.cpp (+8/-14)
tests/unit-tests/input/CMakeLists.txt (+1/-0)
tests/unit-tests/input/test_input_platform_probing.cpp (+161/-0)
| Changed in mir: | |
| importance: | Undecided → High |
Revision history for this message
| Daniel van Vugt (vanvugt) wrote | #1 |
| Changed in mir: | |
| status: | New → Incomplete |
| tags: | added: clientapi input |
Revision history for this message
| Brandon Schaefer (brandontschaefer) wrote | #2 |
| Changed in mir: | |
| status: | Incomplete → New |
Revision history for this message
| Andreas Pokorny (andreas-pokorny) wrote | #3 |
| Changed in mir: | |
| assignee: | nobody → Andreas Pokorny (andreas-pokorny) |
| milestone: | none → 0.18.0 |
| status: | New → Fix Committed |
| Changed in mir: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
I'm not sure if I totally agree with this. If you make the touchpad completely relative then multi-finger gestures don't work. For example, in a pinch/zoom you no longer have any concept of how far apart the fingers are, at any stage of the gesture.
That all said, I do agree that "relative mode" should be an option. I think the bug description needs clarification because we support both relative and absolute coordinates for mice now, simultaneously, and that's probably what you mean...?