mir fails to build with GCC 5

Bug #1475994 reported by Matthias Klose on 2015-07-19
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mir
Fix Released
Critical
Alan Griffiths
0.14
Fix Released
Critical
Alan Griffiths
mir (Ubuntu)
Critical
Unassigned
Nominated for Vivid by Alan Griffiths
Nominated for Wily by Alan Griffiths

Bug Description

as seen in silo16:

https://launchpadlibrarian.net/212029958/buildlog_ubuntu-wily-amd64.mir_0.14.0%2B15.10.20150715-0ubuntu2~gcc5.1_BUILDING.txt.gz

make[3]: Entering directory '/«BUILDDIR»/mir-0.14.0+15.10.20150715/obj-x86_64-linux-gnu'
/usr/bin/cmake -E cmake_progress_report /«BUILDDIR»/mir-0.14.0+15.10.20150715/obj-x86_64-linux-gnu/CMakeFiles
[ 10%] Building CXX object src/protobuf/CMakeFiles/mirprotobuf.dir/google_protobuf_guard.cpp.o
cd /«BUILDDIR»/mir-0.14.0+15.10.20150715/obj-x86_64-linux-gnu/src/protobuf && /usr/bin/x86_64-linux-gnu-g++ -DLOG_NDEBUG=1 -DMESA_EGL_NO_X11_HEADERS -DMIR_VERSION_MAJOR=0 -DMIR_VERSION_MICRO=0 -DMIR_VERSION_MINOR=14 -Dmirprotobuf_EXPORTS -g -O2 -fstack-protector-strong -Wformat -Werror=format-security -D_FORTIFY_SOURCE=2 -pthread -g -std=c++14 -Werror -Wall -fno-strict-aliasing -pedantic -Wnon-virtual-dtor -Wextra -fPIC -fPIC -I/«BUILDDIR»/mir-0.14.0+15.10.20150715/include/common -I/«BUILDDIR»/mir-0.14.0+15.10.20150715/src/include/common -I/«BUILDDIR»/mir-0.14.0+15.10.20150715/obj-x86_64-linux-gnu/src/protobuf -o CMakeFiles/mirprotobuf.dir/google_protobuf_guard.cpp.o -c /«BUILDDIR»/mir-0.14.0+15.10.20150715/src/protobuf/google_protobuf_guard.cpp
In file included from /«BUILDDIR»/mir-0.14.0+15.10.20150715/src/protobuf/google_protobuf_guard.cpp:19:0:
/«BUILDDIR»/mir-0.14.0+15.10.20150715/src/include/common/mir/protobuf/google_protobuf_guard.h:37:6: error: '{anonymous}::force_google_protobuf_init' defined but not used [-Werror=unused-variable]
 bool force_google_protobuf_init{(mir::protobuf::google_protobuf_guard(), true)};
      ^
/usr/bin/cmake -E cmake_progress_report /«BUILDDIR»/mir-0.14.0+15.10.20150715/obj-x86_64-linux-gnu/CMakeFiles
cc1plus: all warnings being treated as errors
make[3]: *** [src/protobuf/CMakeFiles/mirprotobuf.dir/google_protobuf_guard.cpp.o] Error 1
[ 10%] src/protobuf/CMakeFiles/mirprotobuf.dir/build.make:75: recipe for target 'src/protobuf/CMakeFiles/mirprotobuf.dir/google_protobuf_guard.cpp.o' failed
make[3]: Leaving directory '/«BUILDDIR»/mir-0.14.0+15.10.20150715/obj-x86_64-linux-gnu'
CMakeFiles/Makefile2:2622: recipe for target 'src/protobuf/CMakeFiles/mirprotobuf.dir/all' failed
make[2]: *** [src/protobuf/CMakeFiles/mirprotobuf.dir/all] Error 2

Related branches

Matthias Klose (doko) wrote :

there is more than one issue ... looks like the package never saw GCC 5 before.

here are the hacks I applied to be able to continue with other packages:
https://launchpad.net/~ci-train-ppa-service/+archive/ubuntu/landing-016/+files/mir_0.14.0%2B15.10.20150715-0ubuntu2~gcc5.1_0.14.0%2B15.10.20150715-0ubuntu2.1.diff.gz

Changed in mir:
milestone: none → 0.15.0
importance: Undecided → Critical
Changed in mir:
assignee: nobody → Alan Griffiths (alan-griffiths)
Changed in mir:
status: New → In Progress
PS Jenkins bot (ps-jenkins) wrote :

Fix committed into lp:mir at revision None, scheduled for release in mir, milestone 0.15.0

Changed in mir:
status: In Progress → Fix Committed
Changed in mir (Ubuntu):
status: Confirmed → In Progress
Matthias Klose (doko) wrote :

tests fail on armhf too

Changed in mir (Ubuntu):
status: In Progress → Fix Released
Daniel van Vugt (vanvugt) wrote :

Whoops. Just missed the 0.14.0 release. But it's landed ready for 0.14.1.

Changed in mir (Ubuntu):
status: Fix Released → In Progress
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package mir - 0.14.0+15.10.20150723.1-0ubuntu1

---------------
mir (0.14.0+15.10.20150723.1-0ubuntu1) wily; urgency=medium

  [ Andreas Pokorny ]
  * Fix missing ABI renaming in Mirplatform
  * Bump Mirserver platform graphics to 3
  * Fix mirprotobuf ABI break
  * Fix g++-5.0 compilation (LP: #1475994)

  [ CI Train Bot ]
  * New rebuild forced.

 -- CI Train Bot <email address hidden> Thu, 23 Jul 2015 16:33:09 +0000

Changed in mir (Ubuntu):
status: In Progress → Fix Released
Daniel van Vugt (vanvugt) wrote :

Confirmed fix released in the minor bump:
mir (0.14.0+15.10.20150723.1-0ubuntu1) wily; urgency=medium

Daniel van Vugt (vanvugt) wrote :

The status is actually accurate. The fix missed the 0.14.0 tag and initial release. But it was released in another wily update a day or two later. So Fix Released in Ubuntu already, but not in any upstream tagged release yet.

Changed in mir:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers