test_drm_auth_magic.cpp:142:26: warning: ‘MirWaitHandle* mir_connection_drm_auth_magic(MirConnection*, unsigned int, mir_drm_auth_magic_callback, void*)’ is deprecated

[Daniel van Vugt]

These warnings recently started to appear during Mir builds:

/home/dan/bzr/mir/dev/tests/integration-tests/test_drm_auth_magic.cpp: In member function ‘virtual void BespokeDisplayServerTestFixture_client_drm_auth_magic_calls_platform_Test::TestBody()::Client::exec()’:
/home/dan/bzr/mir/dev/tests/integration-tests/test_drm_auth_magic.cpp:142:26: warning: ‘MirWaitHandle* mir_connection_drm_auth_magic(MirConnection*, unsigned int, mir_drm_auth_magic_callback, void*)’ is deprecated (declared at /home/dan/bzr/mir/dev/include/client/mir_toolkit/mir_client_library_drm.h:35): Use mir_connection_platform_operation() with operations from mir_toolkit/mesa/platform_operation.h [-Wdeprecated-declarations]
             mir_wait_for(mir_connection_drm_auth_magic(connection, magic,
                          ^
/home/dan/bzr/mir/dev/tests/integration-tests/test_drm_auth_magic.cpp:144:63: warning: ‘MirWaitHandle* mir_connection_drm_auth_magic(MirConnection*, unsigned int, mir_drm_auth_magic_callback, void*)’ is deprecated (declared at /home/dan/bzr/mir/dev/include/client/mir_toolkit/mir_client_library_drm.h:35): Use mir_connection_platform_operation() with operations from mir_toolkit/mesa/platform_operation.h [-Wdeprecated-declarations]
                                                        &status));
                                                               ^

[Alexandros Frantzis (afrantzis)]

This is part of our deprecation strategy. The test code (and the warning) will be removed when we remove the corresponding deprecated client functions.

[Daniel van Vugt (vanvugt)]

Don't forget our quality strategy - No warnings should be visible in builds so that real mistakes are obvious (and preferably treated as errors).

[Alan Griffiths (alan-griffiths)]

OK, we don't need to discuss: it is easy to link this to the (hypothetical ATM) ABI break MP and land that.

[Michał Sawicz (saviq)]

Syncing task from Mir.