Ubuntu
mir package

Automated ABI checking is missing or broken

Bug #1451733 reported by Daniel van Vugt
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mir
Triaged
Medium
Unassigned
mir (Ubuntu)
Triaged
Medium
Unassigned

Bug Description

Mir's automated ABI checking is missing or broken. I've just proposed two intentional ABI breaks and CI failed to detect and reject either of them:

https://code.launchpad.net/~vanvugt/mir/test-abi-break-1/+merge/258160
https://code.launchpad.net/~vanvugt/mir/test-abi-break-2/+merge/258224

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Incomplete. Am I targeting the wrong branch?

Changed in mir:
status: New → Incomplete
Revision history for this message
Alberto Aguirre (albaguirre) wrote :

It's disabled by default (export MIR_ENABLE_ABI_CHECK_TEST=TRUE to enable it) as we don't want to gate MP's due to ABI breaks (since we often allow them in and bump ABI independently) .

We do need to enable it for MP's targeting mir/ubuntu however.

Also on previous discussions there was some consensus on only enabling the ABI check on a custom CI job that will report ABI breaks (if any) after every landing.

Revision history for this message
Launchpad Janitor (janitor) wrote :

[Expired for Mir because there has been no activity for 60 days.]

Changed in mir:
status: Incomplete → Expired
Daniel van Vugt (vanvugt)
Changed in mir:
importance: Undecided → Medium
status: Expired → Triaged
Revision history for this message
Michał Sawicz (saviq) wrote :

Syncing task from Mir.

Changed in mir (Ubuntu):
importance: Undecided → Medium
status: New → Triaged
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.