Acceptance tests link with static versions of client library and server components
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Mir |
Fix Released
|
High
|
Alan Griffiths | ||
mir (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
Acceptance tests link with static versions of client library and server components [1]. This is bad because:
1. mir_acceptance_
2. We can inadvertently use private symbols, so the acceptance tests won't fail if we forget to make a symbol public
The tests failures seen in https:/
a result of (1). What happens is that we register valid surfaces with the built-in (picked up from mirclient-static) version of the MirSurface:
The aforementioned MP also suffers from (2), since although I forgot to expose the new client library symbol, the tests work fine. Depending on the particular case, we may only find out about the problem after the release, when a user tries to use the symbol and fail.
[1] libmirclient-
Related branches
- Kevin DuBois (community): Approve
- Alberto Aguirre (community): Approve
- Alexandros Frantzis (community): Approve
- PS Jenkins bot (community): Approve (continuous-integration)
-
Diff: 607 lines (+111/-116)22 files modified3rd_party/CMakeLists.txt (+0/-13)
3rd_party/android-input/android/CMakeLists.txt (+4/-4)
3rd_party/xcursor/CMakeLists.txt (+1/-1)
benchmarks/android-input/CMakeLists.txt (+2/-2)
benchmarks/frame-uniformity/CMakeLists.txt (+6/-10)
src/client/CMakeLists.txt (+15/-11)
src/client/input/CMakeLists.txt (+2/-2)
src/client/lttng/CMakeLists.txt (+4/-4)
src/client/rpc/CMakeLists.txt (+1/-1)
src/client/symbols.map (+15/-0)
src/common/graphics/android/CMakeLists.txt (+1/-1)
src/common/sharedlibrary/CMakeLists.txt (+1/-1)
src/platforms/android/client/CMakeLists.txt (+1/-1)
src/platforms/android/server/CMakeLists.txt (+1/-1)
src/server/CMakeLists.txt (+4/-2)
tests/acceptance-tests/CMakeLists.txt (+7/-16)
tests/integration-tests/CMakeLists.txt (+8/-7)
tests/mir_test/CMakeLists.txt (+1/-2)
tests/mir_test_doubles/CMakeLists.txt (+7/-7)
tests/mir_test_framework/CMakeLists.txt (+14/-17)
tests/performance-tests/CMakeLists.txt (+3/-2)
tests/unit-tests/CMakeLists.txt (+13/-11)
description: | updated |
Changed in mir: | |
status: | New → Confirmed |
Changed in mir: | |
assignee: | nobody → Alan Griffiths (alan-griffiths) |
status: | Confirmed → In Progress |
Changed in mir: | |
milestone: | none → 0.13.0 |
Changed in mir: | |
status: | Fix Committed → Fix Released |
Fix committed into lp:mir at revision None, scheduled for release in mir, milestone 0.13.0