Surfaces are not properly released in CustomWindowManagement.state_change_requests_are_associated_with_correct_surface

[Alexandros Frantzis]

Memory leak in CustomWindowManagement, state_change_requests_are_associated_with_correct_surface is causing CI failures in unrelated tests.

Seen in https://jenkins.qa.ubuntu.com/job/mir-vivid-amd64-ci/1537/consoleFull:

7: ==13773== 1,359,533 (14,960 direct, 1,344,573 indirect) bytes in 17 blocks are definitely lost in loss record 127 of 127
7: ==13773== at 0x4C2C100: operator new(unsigned long) (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
7: ==13773== by 0x8E5C24: MirConnection::create_surface(MirSurfaceSpec const&, void (*)(MirSurface*, void*), void*) (mir_connection.cpp:147)
7: ==13773== by 0x8D682F: mir_surface_create (mir_surface_api.cpp:149)
7: ==13773== by 0x8D6A1A: mir_surface_create_sync (mir_surface_api.cpp:133)
7: ==13773== by 0x6D9FC7: (anonymous namespace)::Client::surface_create() const (test_custom_window_management.cpp:77)
...

It's strange that the leak is not consistently detected by valgrind.

[Alexandros Frantzis (afrantzis)]

The memory leak is the indirect result of improper linking (https://bugs.launchpad.net/mir/+bug/1445473).

The effect can be worked around by properly releasing the surfaces, instead of letting them be released at MirConnection release time.

[Alexandros Frantzis (afrantzis)]

Changed priority to low since forgetting to release the surfaces would not normally lead to a leak (since we free any forgotten surface at MirConnection release time).

[PS Jenkins bot (ps-jenkins)]

Fix committed into lp:mir at revision None, scheduled for release in mir, milestone 0.13.0

[Launchpad Janitor (janitor)]

This bug was fixed in the package mir - 0.13.1+15.10.20150520-0ubuntu1

---------------
mir (0.13.1+15.10.20150520-0ubuntu1) wily; urgency=medium

  [ Cemil Azizoglu ]
  * New upstream release 0.13.1 (https://launchpad.net/mir/+milestone/0.13.1)
    - ABI summary: No ABI break. Servers and clients do not need rebuilding.
      . Mirclient ABI unchanged at 8
      . Mircommon ABI unchanged at 4
      . Mirplatform ABI unchanged at 7
      . Mirserver ABI unchanged at 31
    - Bug fixes:
      . Can't load app purchase UI without a U1 account (LP: #1450377)
      . Crash because uncaught exception in mir::events::add_touch (LP: #1437357)

 -- CI Train Bot <email address hidden> Wed, 20 May 2015 21:20:15 +0000