[regression] clang: 'mir::test::doubles::MockSurface::visible' hides overloaded virtual function [-Woverloaded-virtual]
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Mir |
Fix Released
|
Low
|
Daniel van Vugt | ||
mir (Ubuntu) |
Fix Released
|
Low
|
Unassigned |
Bug Description
Clang says:
[ 88%] Building CXX object tests/unit-
In file included from /home/dan/
/home/dan/
'
function [-Woverloaded-
MOCK_
^
/usr/include/
from macro 'MOCK_METHOD0'
#define MOCK_METHOD0(m, ...) GMOCK_METHOD0_(, , , m, __VA_ARGS__)
/usr/include/
from macro 'GMOCK_METHOD0_'
GMOCK_RESULT_(tn, __VA_ARGS__) ct Method( \
/home/dan/
overloaded virtual function 'mir::scene:
here: different qualifiers (const vs none)
bool visible() const;
^
[ 88%] Building CXX object tests/unit-
[ 88%] Building CXX object tests/unit-
[ 89%] Building CXX object tests/unit-
In file included from /home/dan/
/home/dan/
'
function [-Woverloaded-
MOCK_
^
/usr/include/
from macro 'MOCK_METHOD0'
#define MOCK_METHOD0(m, ...) GMOCK_METHOD0_(, , , m, __VA_ARGS__)
/usr/include/
from macro 'GMOCK_METHOD0_'
GMOCK_RESULT_(tn, __VA_ARGS__) ct Method( \
/home/dan/
overloaded virtual function 'mir::scene:
here: different qualifiers (const vs none)
bool visible() const;
^
Related branches
- PS Jenkins bot (community): Approve (continuous-integration)
- Alan Griffiths: Needs Fixing
- Kevin DuBois (community): Approve
- Alexandros Frantzis (community): Approve
-
Diff: 11 lines (+1/-0)1 file modifiedinclude/test/mir_test_doubles/mock_surface.h (+1/-0)
- Alexandros Frantzis (community): Approve
- Andreas Pokorny (community): Approve
- Kevin DuBois (community): Approve
- PS Jenkins bot (community): Approve (continuous-integration)
-
Diff: 527 lines (+48/-110)19 files modifiedinclude/server/mir/default_server_configuration.h (+0/-2)
include/server/mir/frontend/surface.h (+0/-2)
include/server/mir/scene/surface_coordinator.h (+3/-3)
include/server/mir/scene/surface_ranker.h (+0/-46)
include/server/mir/shell/surface.h (+1/-1)
include/server/mir/shell/surface_factory.h (+3/-4)
include/test/mir_test_doubles/mock_surface.h (+0/-1)
include/test/mir_test_doubles/mock_surface_coordinator.h (+12/-6)
include/test/mir_test_doubles/mock_surface_factory.h (+2/-2)
src/server/scene/application_session.cpp (+1/-1)
src/server/scene/application_session.h (+2/-2)
src/server/scene/default_configuration.cpp (+0/-6)
src/server/shell/default_configuration.cpp (+1/-1)
src/server/shell/default_focus_mechanism.cpp (+4/-4)
src/server/shell/default_focus_mechanism.h (+3/-3)
src/server/shell/organising_surface_factory.cpp (+3/-13)
src/server/shell/organising_surface_factory.h (+2/-2)
tests/acceptance-tests/test_client_input.cpp (+3/-3)
tests/unit-tests/scene/test_default_focus_mechanism.cpp (+8/-8)
Changed in mir: | |
assignee: | nobody → Daniel van Vugt (vanvugt) |
status: | Triaged → In Progress |
Changed in mir: | |
milestone: | 0.1.8 → 0.1.9 |
Changed in mir: | |
status: | Fix Committed → Fix Released |
Changed in mir (Ubuntu): | |
importance: | Undecided → Low |
status: | New → Triaged |
Fixed in -r 1529 lp:~alan-griffiths/mir/make-use-of-scene-Surface