Infinite loop on processing a changefile with an unknown distribution

[Gera]

On uploading a changes file with the distribution set to an unknown/unexpected value, mini-dinstall goes into an infinite loop trying to process the same changes file over and over again.

If it's set to email on errors, it will cause a real flood of email.

This bug exists in Xenial, Bionic as well as the upstream Debian package. It might be appropriate to report and fix this upstream.

The attached patch is a minimal fix.

ProblemType: Bug
DistroRelease: Ubuntu 18.04
Package: mini-dinstall 0.6.31ubuntu1
ProcVersionSignature: Ubuntu 4.15.0-52.56-generic 4.15.18
Uname: Linux 4.15.0-52-generic x86_64
ApportVersion: 2.20.9-0ubuntu7.6
Architecture: amd64
CurrentDesktop: i3
Date: Wed Jul 3 14:21:00 2019
EcryptfsInUse: Yes
InstallationDate: Installed on 2018-06-30 (368 days ago)
InstallationMedia: Ubuntu 16.04.4 LTS "Xenial Xerus" - Release amd64 (20180228)
PackageArchitecture: all
SourcePackage: mini-dinstall
UpgradeStatus: Upgraded to bionic on 2019-02-20 (132 days ago)

[Ubuntu Foundations Team Bug Bot (crichton)]

The attachment "ignore-bad-changesfiles.patch" seems to be a patch. If it isn't, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are a member of the ~ubuntu-reviewers, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issues please contact him.]

[Launchpad Janitor (janitor)]

This bug was fixed in the package mini-dinstall - 0.7.3

---------------
mini-dinstall (0.7.3) unstable; urgency=medium

  [ Krytarik Raido ]
  * [d1d92b5] Improve handling of mail features. (Closes: #1027267, #1027268)
  * [298f88d] Fix deprecation warnings on Thread.getName() (Closes: #1055247)
  * [b2b0bf3] Fix infinite loop on faulty Changes files. (LP: #1835212)
  * [a2969f0] Fix deprecation warnings on Thread.isSet()
  * [b9730cb] Update for Python 3.12

  [ Christoph Goehre ]
  * [ad12a30] Check GPG keyrings for read access before using them.
    (Closes: #1027263)

  [ Gioele Barabucci ]
  * [887a02c] gitignore: Ignore temp files and Python cache

  [ Franz Heger ]
  * [6038d1e] Resolve aliases when rejecting changes files
  * [5819c56] Skip missing files when rejecting packages

  [ Unit 193 ]
  * [95bf5d2] Add a simple systemd user unit, disabled by default.

 -- Unit 193 <email address hidden> Wed, 22 May 2024 17:34:13 -0400