window tabbing highlight broken for maximised windows

[Chris Moore]

When I use alt-tab to switch between windows, I see the outline of the window
drawn before I let go of the alt key.

This works for all windows other than maximised ones.

The code in metacity's screen.c calculates values for 'east' and 'south' both as
zero when the window is maximised, and ends up drawing the outline outside the
visible screen area.

For example, my screen is 1024x768 pixels.

A maximised window's frame is 1024x719 pixels, and the windows (non-frame)
content is 1024x696 pixels. Note that the frame is just a 23 pixel tall title
bar across the top - maximised windows don't have the 5 pixel wide border around
them that other windows have.

The two rectangles which end up being used to draw the frame are of sizes
1023x718 and 1025x720 respectively, which don't show up on my display.

I've attached a patch which uses the #defined value of OUTLINE_WIDTH whenever a
frame of width 0 would otherwise be drawn.

http://bugzilla.gnome.org/show_bug.cgi?id=98340: http://bugzilla.gnome.org/show_bug.cgi?id=98340

[Chris Moore (dooglus)]

Created an attachment (id=4273)
proposed patch

[Sebastien Bacher (seb128)]

Thanks for your bug. I've forwarded it upstream:
http://bugzilla.gnome.org/show_bug.cgi?id=318503 with the patch

[Sebastien Bacher (seb128)]

one of the upstream has marked it as duplicate of
http://bugzilla.gnome.org/show_bug.cgi?id=98340 specifying he prefers the other
version of the patch

[Daniel Holbach (dholbach)]

 metacity (1:2.13.34-0ubuntu1) dapper; urgency=low
 .
   * New upstream release:
     - Thanks to Damien Carbery, Havoc Pennington, S<F8>ren Sandmann,
       Bj<F6>rn Lindqvist, Kjartan Maraas, Elijah Newren for improvements in
       this release.
     - manually define HOST_NAME_MAX if not already defined to fix Solaris
       compilation issue (Damien, Havoc) [#326745]
     - compositor improvements: port to changes in libcm, do it again, fix
       unrefing, make minimize animation update again (all done by S<F8>ren)
     - make sure an outline border is shown even if a window decoration's
       width is 0 (Bj<F6>rn) [#98340] (Malone: #23032)
     - correctly handle window alt-tab outlines in showing desktop mode
       (Bj<F6>rn) [#98340]
     - fix lots of tiny issues spotted by the intel compiler (Kjartan) [#321439]
     - prevent rapidly repeated visual bells from hanging metacity (Elijah)
       [#322032]
     - more careful error handling of values returned by GConf (Elijah)
       [#326615]
     - fix various initialization and default issues, especially for running
       with --disable-gconf. Make --disable-gconf actually work. (Elijah)
       [#326661]
     - fix some reading-from-free'd-data errors (S<F8>ren) [#327575]
     - fix an unitialized value problem when in raise-on-click mode (S<F8>ren)
       [#327572]
     - avoid flashing original-sized window when closing a maximized window
       (Elijah) [#317254]
     - prevent windows from sometimes getting shoved and smashed by sliding
       (and possibly auto-hiding) panels (Elijah) [#327822]
     - Translations: Ilkka Tuohela (fi), Ignacio Casal Quinteiro (gl), Tino
       Meinen (nl), Funda Wang (zh_CN)