Window Tabbing highlight broken

[Scott James Remnant (Canonical)]

In previous versions of metacity when Tabbing through windows, it would draw
round the border of the window no matter how deep in the stack it was. The
resulting effect of this is that I could tab through my windows and rather than
look at the icon and titles, just wait until I saw the border in the place I
remember the window being.

This gave a great subconcious "give me the window that was *THERE*" effect. In
fact, it was so great and subconcious, I had to have it pointed out to me that
I'd been using and relying on it for ages.

Sadly this appears to be broken in the latest version, and it's like losing a limb.

Instead of drawing the border and keeping it there, it ever-so-briefly flashes
it. In fact, it's so quick that it's almost impossible to make out. If this is
a deliberate decision, it was a very bad idea and could it be reverted? If not,
could we fix the bug.

I'd like my limbs back <g>

http://bugs.gnome.org/show_bug.cgi?id=317528: http://bugs.gnome.org/show_bug.cgi?id=317528

[Emmanuel Pacaud (emmanuel-pacaud)]

Same here on an up to date breezy.

[Daniel Holbach (dholbach)]

Thanks for your bugreport, Scott. I took the issue to the upstream bug tracker:
http://bugs.gnome.org/show_bug.cgi?id=317528

[Chris Moore (dooglus)]

*** Bug 22860 has been marked as a duplicate of this bug. ***

[Sebastien Bacher (seb128)]

iz GTK bog

[Chris Moore (dooglus)]

I was looking into this, but have had to give up due to lack of time.

One thing I did notice was in metacity's screen.c, line 1234, the value set in
inner_width assumes that the left and right borders of a window are always the
same. Is that always true?

[Chris Moore (dooglus)]

I'm going away to the inlaws for the weekend. Won't have a network connection,
but will have the bug report, source code, test cases and lots of time on my hands.

So I hope by the time I'm back online on Sunday afternoon I'll have a fix.

[Sebastien Bacher (seb128)]

The change from http://bugzilla.gnome.org/show_bug.cgi?id=316180 creates this
issue. That's a trivial change and can be easily reverted, I'll speak with
upstream about this

[Sebastien Bacher (seb128)]

This upload fixes the issue:

 metacity (1:2.12.0-0ubuntu2) breezy; urgency=low
 .
   * debian/patches/003_bordersdrawingfix.patch:
     - fix the drawing on windows border (Ubuntu: #16589).