SRU: metacity crashes while minimizing a windows that has undocked child

[Mustafa Kemal Gilor]

[General information about the SRU]
* It includes the fix for the bug https://gitlab.gnome.org/GNOME/metacity/-/issues/31
* The fix is already included in 3.46.0 release: https://gitlab.gnome.org/GNOME/metacity/-/commit/77f1d55479bfef479f76011a1ee5636f9bf6b08b#9f621eb5fd3bcb2fa5c7bd228c9b1ad42edc46c8
* The reproducer also revealed another issue with docked windows, undocked windows are not being restored after parent window is minimized and restored
* The fix for restore is included in 3.46.1 release: https://gitlab.gnome.org/GNOME/metacity/-/commit/3db07fafa1c7ff9749b6a82ccb36d8b62f2304d9
* Focal(3.36.1) and Jammy (3.44.0) needs both fixes to be backported

[Impact]
This affects users using applications that have docked windows

[Test Case]

* Install gnome-session-flashback (metacity) and reproducer's dependencies `sudo apt install lightdm gnome-session-flashback pyside2-tools python3-pyside2.qtwidgets`
* Start a graphical session with metacity
* run python3 Untitled.py
* Undock one of the application's child windows
* Minimize main window
* Result: Metacity will crash

* Fix: install fix from ppa:
* sudo add-apt-repository ppa:mustafakemalgilor/lp-2003176-0
* sudo apt update
* sudo reboot # or alternatively, restart display manager
* run python3 Untitled.py
* Undock one of the application's child windows
* Minimize main window
* Expectation: it should not crash and the application should be minimized.

[Regression Potential]
The fix is small in size and localized, it should not cause any regressions.

-----------------------------------------------------------------------------

Bug Version: 1:3.36.1-1 / 1:3.44.0-1

Metacity is running without the composite manager.

Users cannot minimize an application with an undocked child window

ProblemType: Bug
DistroRelease: Ubuntu 20.04 / Ubuntu 22.04
Package: metacity 1:3.36.1-1 / 1:3.44.0-1
ProcVersionSignature: Ubuntu 4.4.0-24.43-generic 4.4.10
Uname: Linux 4.4.0-24-generic x86_64
ApportVersion: 2.20.1-0ubuntu2.1
Architecture: amd64

[Mustafa Kemal Gilor (mustafakemalgilor)]

Reproducer script:

[Chris Halse Rogers (raof)]

Hello Mustafa, or anyone else affected,

Accepted metacity into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/metacity/1:3.36.1-1ubuntu1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-focal. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Chris Halse Rogers (raof)]

Hello Mustafa, or anyone else affected,

Accepted metacity into jammy-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/metacity/1:3.44.0-1ubuntu1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-jammy to verification-done-jammy. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-jammy. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Mustafa Kemal Gilor (mustafakemalgilor)]

Verification is done for Focal and Jammy, I've run the test case 3 times for both, and experienced no crashes while minimizing a parent window with undocked child. Also, the window is restored properly when un-minimized.

[Launchpad Janitor (janitor)]

This bug was fixed in the package metacity - 1:3.44.0-1ubuntu1

---------------
metacity (1:3.44.0-1ubuntu1) jammy; urgency=medium

  * Backport upstream patch to fix metacity crash when a parent window is
    minimized while a docked window is undocked (LP: #2003176).
  * Backport upstream patch to fix restoring docked window when the parent
    window is unminimized.

 -- Mustafa Kemal GILOR <email address hidden> Wed, 18 Jan 2023 15:50:17 +0300

[Łukasz Zemczak (sil2100)]

The verification of the Stable Release Update for metacity has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

[Launchpad Janitor (janitor)]

This bug was fixed in the package metacity - 1:3.36.1-1ubuntu1

---------------
metacity (1:3.36.1-1ubuntu1) focal; urgency=medium

  * Backport upstream patch to fix metacity crash when a parent window is
    minimized while a docked window is undocked (LP: #2003176).
  * Backport upstream patch to fix restoring docked window when the parent
    window is unminimized.

 -- Mustafa Kemal GILOR <email address hidden> Wed, 18 Jan 2023 13:10:06 +0300

[Mustafa Kemal Gilor (mustafakemalgilor)]

Kinetic and above has >= 3.46.0, later series not affected.